From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f66.google.com (mail-oi0-f66.google.com [209.85.218.66]) by dpdk.org (Postfix) with ESMTP id A3BC81BE0 for ; Tue, 4 Sep 2018 13:13:45 +0200 (CEST) Received: by mail-oi0-f66.google.com with SMTP id 8-v6so5971104oip.0 for ; Tue, 04 Sep 2018 04:13:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=owM4ejKatzYCPERf5vZi7TeO3NM1G91aKE768sIgn8g=; b=S1BqIfftfbttSjbBO3VTSIRNdbfkCJkyGOAd7EGbWMmg8V6EkEhZCnLhmzWLXlR9Bn EbWkKqnTPj+lb8Oll5xrrlBfwdq3YT7hFSJp/4QwxTTpRB5c3trw/7a3UUNfXL+mUq1/ cqa21HU6d6DHJEC7XhRNCApgUK3UIAY3edfG2thjKRvUOv+pUV/TPjGU3tCDP55c0nuc ZzEPnmNIoTqK20YTuo9MG0+Jj2IbIbsqyrpfu2nne9+5xatNSt0hnghADUoXMUBIv1o9 dQ23YObLDMAtjd4x2fCzQ15cqwp20I9zEpONBlwyvxi9VdDK9Ov9QCqyWlcHaIEFn8Wj Y1hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=owM4ejKatzYCPERf5vZi7TeO3NM1G91aKE768sIgn8g=; b=Wjq/IpoThoLExOswCOkZg9A0hA/uN+aF193kg22sicQsu46pABAnoH0aUO4Ascrc/4 sbJsc42Q3N7jlYEjQtBxln+5OXIP7xyUHqKgx9Ti7Bf3NHANLriPm1nRDj6NxA78gofj cdf67FKjEjWX3p5Xu7T+6MvkhTiQraz53FA9JaMHw31J5JDPEbkjRarhvri67x2Wahj8 4H5YyCwWacUtyZ6/TZa5ch5MVpmpRK9FnESJbNz8i3jXzhBrnv5LYsgtyfiXOGPK4RYM DRjQfT9x3vNjBupR0rWc/f11LxEKlKGOp81WpuenOPkWRG7RhQp0wScmN8rQKxG25WAI YpqQ== X-Gm-Message-State: APzg51B35XXiuhx20hWxjzI/DcT3AOtidojw2T5lDuhUwQe8tMBtt6RB BS5AoaBxqHGiAZaF9qykJLr6A20KRU9vZkzp+xAJ4PrO X-Google-Smtp-Source: ANB0Vda6BBWFA4ccJPIW307sg8FQYxnR6GM3t9WAXr4eQKozf3jtWVJkspCklU+icOGGEl0HvFyabrSMvzaPkQNcaHk= X-Received: by 2002:a54:4819:: with SMTP id j25-v6mr25387613oij.116.1536059624811; Tue, 04 Sep 2018 04:13:44 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Victor Huertas Date: Tue, 4 Sep 2018 13:13:33 +0200 Message-ID: To: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] Tx vlan offload problem with igb and DPDK v17.11 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Sep 2018 11:13:46 -0000 Hi all, I have solved the issue of the PKT_TX_VLAN_PKT using the SW version rte_vlan_insert function. However I would like to tell you what I have seen during my tests. I hope it can shed a light on the issue you the developers should correct. When I use m->old_flags |=3D PKT_TX_VLAN_PKT my Wireshark captures reveals that the 802.1q and the vlan tag is attached to the output packet. The problem is the 'ether_proto' field of the vlan header, which is set again to 0x8100 (VLAN) instead of 0x0800 (IPv4). Apart from this, the rest of the packet is correct. So if this is corrected in the driver it will work, I think. Regards, El lun., 3 sept. 2018 a las 19:32, Victor Huertas () escribi=C3=B3: > Hi all, > > I have realized that the PKT_TX_VLAN_PKT flag for Tx Vlan Offload doesn't > work in my application. > > According to the NICs I have (IGB) there seems to be a problem with this > vlan offload tx feature and this version of DPDK according to the Bug 17 = : > https://bugs.dpdk.org/show_bug.cgi?id=3D17 > > I have tested it using vfio_pci and igb_uio drivers as well as SW vlan > insertion (rte_vlan_insert) and the result is exactly the same. > > Have this bug been solved so far? > > These are my NICs: > 04:00.1 Ethernet controller: Intel Corporation 82576 Gigabit Network > Connection (rev 01) > Subsystem: Super Micro Computer Inc Device 10c9 > Flags: fast devsel, IRQ 17 > Memory at fafe0000 (32-bit, non-prefetchable) [disabled] [size=3D128K= ] > Memory at fafc0000 (32-bit, non-prefetchable) [disabled] [size=3D128K= ] > I/O ports at ec00 [disabled] [size=3D32] > Memory at fafbc000 (32-bit, non-prefetchable) [disabled] [size=3D16K] > [virtual] Expansion ROM at faf80000 [disabled] [size=3D128K] > Capabilities: [40] Power Management version 3 > Capabilities: [50] MSI: Enable- Count=3D1/1 Maskable+ 64bit+ > Capabilities: [70] MSI-X: Enable- Count=3D10 Masked- > Capabilities: [a0] Express Endpoint, MSI 00 > Capabilities: [100] Advanced Error Reporting > Capabilities: [140] Device Serial Number 00-30-48-ff-ff-bb-17-02 > Capabilities: [150] Alternative Routing-ID Interpretation (ARI) > Capabilities: [160] Single Root I/O Virtualization (SR-IOV) > Kernel driver in use: vfio-pci > Kernel modules: igb > > 04:00.0 Ethernet controller: Intel Corporation 82576 Gigabit Network > Connection (rev 01) > Subsystem: Super Micro Computer Inc Device 10c9 > Flags: fast devsel, IRQ 16 > Memory at faf60000 (32-bit, non-prefetchable) [disabled] [size=3D128K= ] > Memory at faf40000 (32-bit, non-prefetchable) [disabled] [size=3D128K= ] > I/O ports at e880 [disabled] [size=3D32] > Memory at faf3c000 (32-bit, non-prefetchable) [disabled] [size=3D16K] > [virtual] Expansion ROM at faf00000 [disabled] [size=3D128K] > Capabilities: [40] Power Management version 3 > Capabilities: [50] MSI: Enable- Count=3D1/1 Maskable+ 64bit+ > Capabilities: [70] MSI-X: Enable- Count=3D10 Masked- > Capabilities: [a0] Express Endpoint, MSI 00 > Capabilities: [100] Advanced Error Reporting > Capabilities: [140] Device Serial Number 00-30-48-ff-ff-bb-17-02 > Capabilities: [150] Alternative Routing-ID Interpretation (ARI) > Capabilities: [160] Single Root I/O Virtualization (SR-IOV) > Kernel driver in use: vfio-pci > Kernel modules: igb > > Thanks for your attention > > Regards, > > PD: BTW, I have observed that capturing a, for example, an ARP message in > an rx queue which the VLAN stripped the answer is sent correctly if I set > the PKT_TX_VLAN_PKT flag and the VLAN_TCI is the same... However, if I tr= y > to set the VLAN header from a non-VLAN stripped frame then it doesnt work= . > > > > -- > Victor > --=20 Victor