From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3825A0583; Fri, 20 Mar 2020 05:17:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 969C4FEB; Fri, 20 Mar 2020 05:17:40 +0100 (CET) Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by dpdk.org (Postfix) with ESMTP id 29388F90 for ; Fri, 20 Mar 2020 05:17:39 +0100 (CET) Received: by mail-il1-f194.google.com with SMTP id k29so4444242ilg.0 for ; Thu, 19 Mar 2020 21:17:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7IaIUIn+/nMXFiRg6c7kZZe33aVFZWP/p0NLHZWnA7U=; b=P50puTSDUyW5RfSb4mg2X1b8ieLiDGdc5qY00uzed/5n4+VP54GO85Gnc9magXNgo5 ghpamnVVt0+mkMZGE/rMnHStupZcAX9CqqzYfUF4mVPdRmwhILeOW0t8SFDmnycaJI+Y R6QyjpX8w8557J+iZZ3LzNC4huA/by4H4iID0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7IaIUIn+/nMXFiRg6c7kZZe33aVFZWP/p0NLHZWnA7U=; b=JV4FrqF0BVwuERf9GeUz3quZv746v6XIT2xMAujBhn4BrtfYV8n/nU/3Q0gNdtA4AU dgjO3RhPdcTddHsdABuxvzlLdE5sMpwB+6bKmD5l+W0tvafw9bhY4spvEWNqsWGn1XZW Hh2pBLbXZvYlDAZlGNrEREJIAQ+Qt+dCSLgC1No46EnW4qsRBWWS3RnA+jlO9Wxiu1E2 8QTNqJlKNC/9A0zM1quNrsEMgjCjM424bunPbNtANbAZRnq+UkNGrNLVOsHrYV1VHJeb oBsYqUIJtH1pQPn/l2+/umUa2ASsJOKwuSUmIB5xq4LHDvxKpkPLiS7iJmo1+fRs0IC1 McFA== X-Gm-Message-State: ANhLgQ3E44VGkXcJi3Rf2LICXCJKgoQ6fGp2825gJCTJCmiLQ8f4m5fK fxxmUFZwleY9KzTLFKK4mZ+mqZ68faHOXBgKyrxW7w== X-Google-Smtp-Source: ADFU+vui8WUgZieiS2QvVgWQ4wRC+m8bzg34p3zwd6xHBt7djJoFcmTxW8BRqDOTyj9/mgWF/ZrcbhhvRJKDBGrGEiM= X-Received: by 2002:a05:6e02:511:: with SMTP id d17mr5990389ils.36.1584677858303; Thu, 19 Mar 2020 21:17:38 -0700 (PDT) MIME-Version: 1.0 References: <20200318152227.3931-1-muhammad.ahmad@emumba.com> <20200319074400.14139-1-muhammad.ahmad@emumba.com> In-Reply-To: <20200319074400.14139-1-muhammad.ahmad@emumba.com> From: Kalesh Anakkur Purayil Date: Fri, 20 Mar 2020 09:47:26 +0530 Message-ID: To: Muhammad Ahmad Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com, ferruh.yigit@intel.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3] testpmd: added rte_eth_dev_fw_version_get in testpmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Muhammad, Could you update the commit title as: "app/testpmd: add fw version in port info" Regards, Kalesh On Thu, Mar 19, 2020 at 1:16 PM Muhammad Ahmad wrote: > rte_eth_dev_fw_version_get() was not called in test pmd. > Added rte_eth_dev_fw_version_get() in testpmd under > show port info > > Bugzilla ID: 225 > > Cc: dev@dpdk.org > > Reported-by: Thomas Monjalon > Signed-off-by: Muhammad Ahmad > --- > app/test-pmd/config.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 8cf84ccd3..66f3de908 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -52,6 +52,8 @@ > > #include "testpmd.h" > > +#define ETHDEV_FWVERS_LEN 32 > + > static char *flowtype_to_str(uint16_t flow_type); > > static const struct { > @@ -523,6 +525,7 @@ port_infos_display(portid_t port_id) > uint16_t mtu; > char name[RTE_ETH_NAME_MAX_LEN]; > int ret; > + char fw_version[ETHDEV_FWVERS_LEN]; > > if (port_id_is_invalid(port_id, ENABLED_WARN)) { > print_valid_ports(); > @@ -544,6 +547,13 @@ port_infos_display(portid_t port_id) > rte_eth_dev_get_name_by_port(port_id, name); > printf("\nDevice name: %s", name); > printf("\nDriver name: %s", dev_info.driver_name); > + > + if (rte_eth_dev_fw_version_get(port_id, fw_version, > + ETHDEV_FWVERS_LEN) == 0) > + printf("\nFirmware-version: %s", fw_version); > + else > + printf("\nFirmware-version: %s", "not available"); > + > if (dev_info.device->devargs && dev_info.device->devargs->args) > printf("\nDevargs: %s", dev_info.device->devargs->args); > printf("\nConnect to socket: %u", port->socket_id); > -- > 2.17.1 > > -- Regards, Kalesh A P