From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A3C4A04DB; Thu, 10 Dec 2020 15:25:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3BA03BE75; Thu, 10 Dec 2020 15:23:44 +0100 (CET) Received: from mail-yb1-f195.google.com (mail-yb1-f195.google.com [209.85.219.195]) by dpdk.org (Postfix) with ESMTP id 3005CBC88 for ; Thu, 10 Dec 2020 15:23:42 +0100 (CET) Received: by mail-yb1-f195.google.com with SMTP id o144so4361734ybc.0 for ; Thu, 10 Dec 2020 06:23:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wdpHacUp6ud4nyDiBWk8M7t1lfwtoo//5TGxsah9u50=; b=eibLq+ILRGMr4+ZITAgqKJ8AS213K1ye07uN/UA8nw3mvOUpgjXwCFwNmazjar+MqZ RGPDsGUM571Wm/Xo7u49F2T5Z2Uea4p2/Hlv0IT7d1mfh2N3fV5fGqT0mxwAhf8nn6ZA WUqkoSZGCibjOwsWPm8pAQcHHu+/iIHnBWxU/0aOhr5yT+qxTgUeN5gwtzfOh3ieyV3j fZtK5awcHUVGUvgCQQlVC8635SqWQbxB2hDhUUrF9GCYxdoyhW5Sgs+h/rL8qLi7QqPl 4d7w5B12SvIUhFQniiVq2Ro1XWR0NyrXVlSRvt037ciY0795bKnfPUv7Qh/6L3ImYpSG 1x9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wdpHacUp6ud4nyDiBWk8M7t1lfwtoo//5TGxsah9u50=; b=HH3YVMPk/6nxdRtWqlFwM6YISbM09MTRvB3k1jGF+nJhD+ySvOSrNNGPy2ojAZrEg5 l3RP/+F8HBe0RaSjHpydWax7tfeJshkmrGFnAmP1auQTzQmqWrTLH8+s8zqq8z+FjI8g nKt8W9+JSOalhxpIaLd+IevngVYKtxwzFe1RmL3jxcDMfga4b/+OJTV85kp0Fujnfn1T QKiRIXYwqN1u1ocH+A6PXDb/yzlSKRQQeKyqJ63AcQgvxmy09Ov44ZMgDr+1rA3egteH lRRCXbIcez4JR+19hfdohdSRanUBiZ09Eamiy+EX8y1Rzpln86sEdIDpIr9cNoHhoyVe YEQQ== X-Gm-Message-State: AOAM532h9fiRblyq4n0Y4W9RxjqZb2xLJhJnQ855E8Z5ws5faJjchqSR dKrl7LWZVfC+K4o2Hb91fE2PeYKkjCcvR6reo6s= X-Google-Smtp-Source: ABdhPJysykVFOgwULtEt1aPmYl7/mmGX3CCBbKmAbZLEviRrHygy8nbK5fc72Atmq1BgacJxNcVV2GOjrwmQwkaJEBQ= X-Received: by 2002:a25:8283:: with SMTP id r3mr11309955ybk.66.1607610221690; Thu, 10 Dec 2020 06:23:41 -0800 (PST) MIME-Version: 1.0 References: <20201209192233.6518-1-ajit.khaparde@broadcom.com> <20201209235347.16180-1-ajit.khaparde@broadcom.com> <20201209235347.16180-18-ajit.khaparde@broadcom.com> In-Reply-To: <20201209235347.16180-18-ajit.khaparde@broadcom.com> From: Lance Richardson Date: Thu, 10 Dec 2020 09:23:30 -0500 Message-ID: To: Ajit Khaparde Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 17/17] net/bnxt: modify ring index logic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Dec 9, 2020 at 6:59 PM Ajit Khaparde wrote: > > Change the ring logic so that the index increments > unbounded and mask it only when needed. > > Modify the existing macros so that the index is not masked. > Add a new macro RING_IDX() to mask it only when needed. > - > v2->v3: Updated the index calculation in Tx completion processing. > > Signed-off-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_cpr.h | 10 ++- > drivers/net/bnxt/bnxt_hwrm.c | 4 +- > drivers/net/bnxt/bnxt_reps.c | 4 +- > drivers/net/bnxt/bnxt_ring.c | 39 +++++---- > drivers/net/bnxt/bnxt_ring.h | 40 ++++++--- > drivers/net/bnxt/bnxt_rxr.c | 110 +++++++++++++----------- > drivers/net/bnxt/bnxt_rxr.h | 4 +- > drivers/net/bnxt/bnxt_rxtx_vec_common.h | 14 +-- > drivers/net/bnxt/bnxt_rxtx_vec_neon.c | 16 ++-- > drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 16 ++-- > drivers/net/bnxt/bnxt_txr.c | 51 ++++++----- > drivers/net/bnxt/bnxt_txr.h | 6 +- > 12 files changed, 179 insertions(+), 135 deletions(-) > Acked-by: Lance Richardson (Note: sending from a personal email account to avoid incompatible footer forced by corporate policy. Ideally I would submit a patch to add a mailmap entry with this email address, but we don't seem to have a .mailmap file for this repository.)