From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7256BA04DB; Thu, 10 Dec 2020 17:00:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D4094C982; Thu, 10 Dec 2020 17:00:04 +0100 (CET) Received: from mail-yb1-f194.google.com (mail-yb1-f194.google.com [209.85.219.194]) by dpdk.org (Postfix) with ESMTP id 506CBC980 for ; Thu, 10 Dec 2020 17:00:02 +0100 (CET) Received: by mail-yb1-f194.google.com with SMTP id k78so5138072ybf.12 for ; Thu, 10 Dec 2020 08:00:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QA5tijrDQkleAcFF4bnjBf+PRKbdQFt8zThtCHjifKk=; b=i5c7DQO74CY3wfRw01cOwM85GImPzlUXDjEjHv5PazsEk0c/t+Yq+iuXGjkmlJdD1P tb/eCv29JfGMYVOwGbUxuOjR6SK8Yw/a6Pj5CKHgJO8JRv9TTt/BM3NnyNTbToBSTC2b zG9EHO/s1hLSQJkglDJvNa9akCBm8D+ltNZH559v27amKuQsJTl4LlSmU1ZDxOb7zSl0 BpfhlnRSuUoxHOGyZZ0LU//mIULWJ4LSSMw0f8pvJk9NUig1CI6GOVAzvA1dPtaTNvvr f0dL76oNu46S8rDivbK0ja7S2kwB6Yo1fgjt6omOpyUix3P1uctS1hUqsH0OAwoQDU+6 rEAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QA5tijrDQkleAcFF4bnjBf+PRKbdQFt8zThtCHjifKk=; b=d2WTEAQoV3rd8bVnkhEaXos6uDVELxO3rJy/0CQ4KDBYB7p7aruVnTQYiwP/F9cp6h Qwl0iFSTbLftkD0giz0KFr+BGQndScj1mozbKBzp64x4YcLpib5yHKboGJagA6TOcCPN 94cUaBAKCA7tcugKKN3Y++LsuXS0cdYoWZkoorJ6SPnHsGpYfCBPBPWqPFi+zEF8/OPD ct6qtKPNqhmKkRAynUlb812WJ7vJ9CLi4NBb1QEO0nzDpoHYcg9ba0Gm/ZshhN+H8IeT cn33bIARyLuK+7OwVUt6/G8D/4mLvNrirnIerVRuxSfykv5B3BLq0oKd9TmCig76XAeT XChw== X-Gm-Message-State: AOAM533YpNloN2/scw6YeQ9FZUdLQ/KBfhimYZh4MwrQSSUc+rdmaPTS admFIMnR/gBzu19LJE5d6AEzPMS9Prz090iMKWs= X-Google-Smtp-Source: ABdhPJw4/O1lnhbmqI2hZrhZzSNJ9j54Xx5e3coB/4/pnw7+YG1GLrtZFJGofNds4WZJTEp9Y8dhFSRvCquLBLuHixk= X-Received: by 2002:a25:5052:: with SMTP id e79mr12211076ybb.51.1607616001762; Thu, 10 Dec 2020 08:00:01 -0800 (PST) MIME-Version: 1.0 References: <20201209192233.6518-1-ajit.khaparde@broadcom.com> <20201209235347.16180-1-ajit.khaparde@broadcom.com> <20201209235347.16180-16-ajit.khaparde@broadcom.com> In-Reply-To: <20201209235347.16180-16-ajit.khaparde@broadcom.com> From: Lance Richardson Date: Thu, 10 Dec 2020 10:59:51 -0500 Message-ID: To: Ajit Khaparde Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 15/17] net/bnxt: changes to indentation and coding style X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Dec 9, 2020 at 6:59 PM Ajit Khaparde wrote: > > Indentation and coding style fixes. > > Signed-off-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt.h | 4 ++-- > drivers/net/bnxt/bnxt_ethdev.c | 9 ++++----- > drivers/net/bnxt/bnxt_reps.c | 2 +- > drivers/net/bnxt/bnxt_ring.c | 3 +-- > 4 files changed, 8 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h > index 2a318efaf..556e99203 100644 > --- a/drivers/net/bnxt/bnxt.h > +++ b/drivers/net/bnxt/bnxt.h > @@ -127,9 +127,9 @@ > */ > #ifdef RTE_EXEC_ENV_FREEBSD > /* In FreeBSD OS, nic_uio driver does not support interrupts */ > -#define BNXT_NUM_ASYNC_CPR(bp) 0 > +#define BNXT_NUM_ASYNC_CPR(bp) 0U > #else > -#define BNXT_NUM_ASYNC_CPR(bp) 1 > +#define BNXT_NUM_ASYNC_CPR(bp) 1U > #endif > > #define BNXT_MISC_VEC_ID RTE_INTR_VEC_ZERO_OFFSET > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 21d9e26ca..9d5c8aa0f 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -1264,11 +1264,10 @@ static int bnxt_dev_start_op(struct rte_eth_dev *eth_dev) > return -EINVAL; > } > > - if (bp->rx_cp_nr_rings > RTE_ETHDEV_QUEUE_STAT_CNTRS) { > + if (bp->rx_cp_nr_rings > RTE_ETHDEV_QUEUE_STAT_CNTRS) > PMD_DRV_LOG(ERR, > - "RxQ cnt %d > RTE_ETHDEV_QUEUE_STAT_CNTRS %d\n", > - bp->rx_cp_nr_rings, RTE_ETHDEV_QUEUE_STAT_CNTRS); > - } > + "RxQ cnt %d > RTE_ETHDEV_QUEUE_STAT_CNTRS %d\n", > + bp->rx_cp_nr_rings, RTE_ETHDEV_QUEUE_STAT_CNTRS); > > do { > rc = bnxt_hwrm_if_change(bp, true); > @@ -1622,7 +1621,7 @@ int bnxt_link_update_op(struct rte_eth_dev *eth_dev, int wait_to_complete) > out: > /* Timed out or success */ > if (new.link_status != eth_dev->data->dev_link.link_status || > - new.link_speed != eth_dev->data->dev_link.link_speed) { > + new.link_speed != eth_dev->data->dev_link.link_speed) { > rte_eth_linkstatus_set(eth_dev, &new); > > rte_eth_dev_callback_process(eth_dev, > diff --git a/drivers/net/bnxt/bnxt_reps.c b/drivers/net/bnxt/bnxt_reps.c > index 167c46ad4..12d677d32 100644 > --- a/drivers/net/bnxt/bnxt_reps.c > +++ b/drivers/net/bnxt/bnxt_reps.c > @@ -56,7 +56,7 @@ bnxt_vfr_recv(uint16_t port_id, uint16_t queue_id, struct rte_mbuf *mbuf) > > /* Put this mbuf on the RxQ of the Representor */ > prod_rx_buf = &rep_rxr->rx_buf_ring[rep_rxr->rx_prod & mask]; > - if (!*prod_rx_buf) { > + if (*prod_rx_buf == NULL) { > *prod_rx_buf = mbuf; > vfr_bp->rx_bytes[que] += mbuf->pkt_len; > vfr_bp->rx_pkts[que]++; > diff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c > index 579c48d8c..f83bcaba2 100644 > --- a/drivers/net/bnxt/bnxt_ring.c > +++ b/drivers/net/bnxt/bnxt_ring.c > @@ -599,8 +599,7 @@ int bnxt_alloc_hwrm_rx_ring(struct bnxt *bp, int queue_index) > > if (rxq->rx_started) { > if (bnxt_init_one_rx_ring(rxq)) { > - PMD_DRV_LOG(ERR, > - "bnxt_init_one_rx_ring failed!\n"); > + PMD_DRV_LOG(ERR, "bnxt_init_one_rx_ring failed!\n"); > bnxt_rx_queue_release_op(rxq); > rc = -ENOMEM; > goto err_out; > -- > 2.21.1 (Apple Git-122.3) > Acked-by: Lance Richardson