From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A079CA04DB; Thu, 10 Dec 2020 17:02:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 67153C982; Thu, 10 Dec 2020 17:02:25 +0100 (CET) Received: from mail-yb1-f193.google.com (mail-yb1-f193.google.com [209.85.219.193]) by dpdk.org (Postfix) with ESMTP id DB559C980 for ; Thu, 10 Dec 2020 17:02:23 +0100 (CET) Received: by mail-yb1-f193.google.com with SMTP id t13so5052394ybq.7 for ; Thu, 10 Dec 2020 08:02:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HDcfafoVJrtxUy2b+V5BzylOPe3DjSjjaElDnIb5b8o=; b=EDR5UHTExY5iFpIrdV806lGmBZNFXItJRWa6C2DOtwp1wakoYWjykMRSfEH3ff/vVI N+D/JliXnrzsB0QOpoLcJZDPVDCPH6X82gx0u/ZlD7dt7NWwFHX9Qecm7Jba3CJnHmcq mMMXfMPlz85jqFR/jR8ReLEUwtb/nJn2mwVL+GLOYOoMExyaA/CceMhyE1ujECQnPF0H Wl/ZGE5hukWekScHTVdiukzK0hkZXn34TyqVWAMUjfqxAV4RIXWsiudDteYMsBjY35yF YcE/Gh5f0HPieYdpcN7OleMQ29/hBvrc9UJEh1FS/9/FJmyDt3/hxrPIENCIXRlNy6KA /gQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HDcfafoVJrtxUy2b+V5BzylOPe3DjSjjaElDnIb5b8o=; b=Q1boaeExDNKw4BxcHiitZDgXbSbR+gZ3k8TpCHWkwvQmJ3XQXLE8FZ79wAGDFyasQE f0x28Trs6uof+/RYzOVMlAbYHCTqvSxfNYyZN1lpdWwJmbZa3y7LFnQ7FxlOv6PY6dL/ x60JLFJSRRHwzBx8mvJrq6w68Jt7l8j6UFuR3ixt1air9okbIjREJ+ioO2j2dOOReRrk y4ru1Ua0foT5s3HMxINwayRCGJG8y9gehXFXJ5W0E4VbRlVC7OL3PhHOeoRwZNkD5AJl 6+oCN9IYgsnRIafkr2mJzHIrkYkWmyyA37bpQtyVo94s8KLYrPfni7+XoCgHGdqPjjg9 k26Q== X-Gm-Message-State: AOAM531s5nL+OTjgQuK93nRd8oyh8xTg4ECofKM/G8+N8KmsoMqbleQo QLjGu1Y0XhPmoHIpDlscosjf7zauJvgPZ9sZxlU= X-Google-Smtp-Source: ABdhPJyzSl6Nr3RP7YafDH8i0kNqiPCTysVg9ilL4nx6du4yyYzTvM9bJcAMw0G74DruXd5k7DWBhFeqa27wzHX/gdw= X-Received: by 2002:a25:6583:: with SMTP id z125mr12110062ybb.313.1607616140220; Thu, 10 Dec 2020 08:02:20 -0800 (PST) MIME-Version: 1.0 References: <20201209192233.6518-1-ajit.khaparde@broadcom.com> <20201209235347.16180-1-ajit.khaparde@broadcom.com> <20201209235347.16180-17-ajit.khaparde@broadcom.com> In-Reply-To: <20201209235347.16180-17-ajit.khaparde@broadcom.com> From: Lance Richardson Date: Thu, 10 Dec 2020 11:02:09 -0500 Message-ID: To: Ajit Khaparde Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 16/17] net/bnxt: add missing comments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Dec 9, 2020 at 6:59 PM Ajit Khaparde wrote: > > Add and update some missing comments in the code. > > Signed-off-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt.h | 6 ++++++ > drivers/net/bnxt/tf_ulp/ulp_template_db_act.c | 5 +++++ > drivers/net/bnxt/tf_ulp/ulp_template_db_class.c | 6 ++++++ > 3 files changed, 17 insertions(+) > > diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h > index 556e99203..07d39ee93 100644 > --- a/drivers/net/bnxt/bnxt.h > +++ b/drivers/net/bnxt/bnxt.h > @@ -724,7 +724,13 @@ struct bnxt { > void *hwrm_short_cmd_req_addr; > rte_iova_t hwrm_short_cmd_req_dma_addr; > rte_spinlock_t hwrm_lock; > + /* synchronize between dev_configure_op and int handler */ > pthread_mutex_t def_cp_lock; > + /* synchronize between dev_start_op and async evt handler > + * Locking sequence in async evt handler will be > + * def_cp_lock > + * health_check_lock > + */ > pthread_mutex_t health_check_lock; > uint16_t max_req_len; > uint16_t max_resp_len; > diff --git a/drivers/net/bnxt/tf_ulp/ulp_template_db_act.c b/drivers/net/bnxt/tf_ulp/ulp_template_db_act.c > index 00ada607a..509af7c58 100644 > --- a/drivers/net/bnxt/tf_ulp/ulp_template_db_act.c > +++ b/drivers/net/bnxt/tf_ulp/ulp_template_db_act.c > @@ -8,6 +8,10 @@ > #include "ulp_template_struct.h" > #include "ulp_rte_parser.h" > > +/* > + * Action signature table: > + * maps hash id to ulp_act_match_list[] index > + */ > uint16_t ulp_act_sig_tbl[BNXT_ULP_ACT_SIG_TBL_MAX_SZ] = { > [BNXT_ULP_ACT_HID_015a] = 1, > [BNXT_ULP_ACT_HID_00eb] = 2, > @@ -93,6 +97,7 @@ uint16_t ulp_act_sig_tbl[BNXT_ULP_ACT_SIG_TBL_MAX_SZ] = { > [BNXT_ULP_ACT_HID_0b4e] = 82 > }; > > +/* Array for the act matcher list */ > struct bnxt_ulp_act_match_info ulp_act_match_list[] = { > [1] = { > .act_hid = BNXT_ULP_ACT_HID_015a, > diff --git a/drivers/net/bnxt/tf_ulp/ulp_template_db_class.c b/drivers/net/bnxt/tf_ulp/ulp_template_db_class.c > index fdb26da3e..d904a04cb 100644 > --- a/drivers/net/bnxt/tf_ulp/ulp_template_db_class.c > +++ b/drivers/net/bnxt/tf_ulp/ulp_template_db_class.c > @@ -8,6 +8,11 @@ > #include "ulp_template_struct.h" > #include "ulp_rte_parser.h" > > +/* Define the template structures */ > +/* > + * Classification signature table: > + * maps hash id to ulp_class_match_list[] index > + */ > uint16_t ulp_class_sig_tbl[BNXT_ULP_CLASS_SIG_TBL_MAX_SZ] = { > [BNXT_ULP_CLASS_HID_0138] = 1, > [BNXT_ULP_CLASS_HID_03f0] = 2, > @@ -227,6 +232,7 @@ uint16_t ulp_class_sig_tbl[BNXT_ULP_CLASS_SIG_TBL_MAX_SZ] = { > [BNXT_ULP_CLASS_HID_01b4] = 216 > }; > > +/* Array for the proto matcher list */ > struct bnxt_ulp_class_match_info ulp_class_match_list[] = { > [1] = { > .class_hid = BNXT_ULP_CLASS_HID_0138, > -- > 2.21.1 (Apple Git-122.3) > Acked-by: Lance Richardson