From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by dpdk.org (Postfix) with ESMTP id 90A141B20D; Mon, 15 Apr 2019 23:40:13 +0200 (CEST) Received: by mail-ed1-f49.google.com with SMTP id y67so2768731ede.2; Mon, 15 Apr 2019 14:40:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SDhK3U/3UhomF4uJ+SMaJCF5pxYQ5Pr0rn+pUKx1OjU=; b=ZbmrJwngvDYsjf3Jo5J3hjc2xm4Wo9lApMCZ7vBpc6fpJbMF/YxPbGu/lXNGknr5aa 78xrPc/uis9s6KvH6/bYmVy6E8a/tZqnkKAYABqoPwxVNmjcxghin2tkCNMfW3XRR7ZC 7R3xqGhPvGJVfqDF9frLYijWOwsoLvxliCsv5pttPdDyLW+EgF+8xltwMYZAFtOTqLiX bJSiT7T6PUpKtFAe2SJhPHePP3ZOR5hIbQv0KyW/r3BqdhVdZa1L33VZVoLervG4pFeb K/CHOcbQkJUOFX/JAMmdNa9qWYCgTiVXk7DSjY0y/Uga1rxXgWU/r6/N6S33H04YcS8B UAEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SDhK3U/3UhomF4uJ+SMaJCF5pxYQ5Pr0rn+pUKx1OjU=; b=Agav6vmo2f3HbHxCmra9Xa0hXWIChb6As9YPYhgqE6XyHj4e5d5IIwPRMaAlJHKcnf E9FRvlDdfkWjz0PuT5ex/KHmrqtdywTIxJaST4k2SRLYmqupsQoi0bOs4Yjlp0rR3/73 U3niiqTJsfW+A8NDj6hHcbfSQSaKlwdAZ2DwWX5M65n3yJHP2vQoe1k1D/B895FegQZQ FTeXRSvOK/oSPv4cLSiY4zf6bvuRZ74rpRBIe8J1xjoN8yeuIkI61RXoadegtcSZb2Ju NdKvMIKYQkpMGpsuUMqzjbrpaDxekkvZKir3SrRi0XYiH0Scc+Akb2lyvLdA8mXLr9AE WVTw== X-Gm-Message-State: APjAAAXNmEYWTFxVUAaVua3/WZiSOqkm8q2g9Rd0nZpLXs7xJoAtKe5Q EwICE/IrQudUkhz5HDBbH8sIgHoFcP5xSJ4GGy4= X-Google-Smtp-Source: APXvYqzN7eRd9xQkK07SdXSAjhgkDqBLMGKQPvL8zZ9rL1Xm8Tpc+LB2uwuaxYTRRpR10n2rb1MqnNXex6nW93+IKNM= X-Received: by 2002:a17:906:4a48:: with SMTP id a8mr17378379ejv.57.1555364413228; Mon, 15 Apr 2019 14:40:13 -0700 (PDT) MIME-Version: 1.0 References: <1555077139-244831-1-git-send-email-ying.a.wang@intel.com> <1555077139-244831-3-git-send-email-ying.a.wang@intel.com> In-Reply-To: <1555077139-244831-3-git-send-email-ying.a.wang@intel.com> From: Rami Rosen Date: Tue, 16 Apr 2019 00:40:05 +0300 Message-ID: To: Wang Ying A Cc: wenzhuo.lu@intel.com, qiming.yang@intel.com, dev@dpdk.org, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 2/2] net/ice: fix promiscuous mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Apr 2019 21:40:13 -0000 Wang Ying A =E2=80=8F: > When device promiscuous mode has already been enabled, > if user re-enables the promisc mode, he/she should be > prompted with "Promisc has already been enabled" > rather than "Failed to enable promisc". > > Fixes: c945e4bf9063 ("net/ice: support promiscuous mode") > Cc: stable@dpdk.org > > Signed-off-by: Wang Ying A > --- > Reviewed-by: Rami Rosen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DD8DDA00E6 for ; Mon, 15 Apr 2019 23:40:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A03541B429; Mon, 15 Apr 2019 23:40:15 +0200 (CEST) Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by dpdk.org (Postfix) with ESMTP id 90A141B20D; Mon, 15 Apr 2019 23:40:13 +0200 (CEST) Received: by mail-ed1-f49.google.com with SMTP id y67so2768731ede.2; Mon, 15 Apr 2019 14:40:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SDhK3U/3UhomF4uJ+SMaJCF5pxYQ5Pr0rn+pUKx1OjU=; b=ZbmrJwngvDYsjf3Jo5J3hjc2xm4Wo9lApMCZ7vBpc6fpJbMF/YxPbGu/lXNGknr5aa 78xrPc/uis9s6KvH6/bYmVy6E8a/tZqnkKAYABqoPwxVNmjcxghin2tkCNMfW3XRR7ZC 7R3xqGhPvGJVfqDF9frLYijWOwsoLvxliCsv5pttPdDyLW+EgF+8xltwMYZAFtOTqLiX bJSiT7T6PUpKtFAe2SJhPHePP3ZOR5hIbQv0KyW/r3BqdhVdZa1L33VZVoLervG4pFeb K/CHOcbQkJUOFX/JAMmdNa9qWYCgTiVXk7DSjY0y/Uga1rxXgWU/r6/N6S33H04YcS8B UAEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SDhK3U/3UhomF4uJ+SMaJCF5pxYQ5Pr0rn+pUKx1OjU=; b=Agav6vmo2f3HbHxCmra9Xa0hXWIChb6As9YPYhgqE6XyHj4e5d5IIwPRMaAlJHKcnf E9FRvlDdfkWjz0PuT5ex/KHmrqtdywTIxJaST4k2SRLYmqupsQoi0bOs4Yjlp0rR3/73 U3niiqTJsfW+A8NDj6hHcbfSQSaKlwdAZ2DwWX5M65n3yJHP2vQoe1k1D/B895FegQZQ FTeXRSvOK/oSPv4cLSiY4zf6bvuRZ74rpRBIe8J1xjoN8yeuIkI61RXoadegtcSZb2Ju NdKvMIKYQkpMGpsuUMqzjbrpaDxekkvZKir3SrRi0XYiH0Scc+Akb2lyvLdA8mXLr9AE WVTw== X-Gm-Message-State: APjAAAXNmEYWTFxVUAaVua3/WZiSOqkm8q2g9Rd0nZpLXs7xJoAtKe5Q EwICE/IrQudUkhz5HDBbH8sIgHoFcP5xSJ4GGy4= X-Google-Smtp-Source: APXvYqzN7eRd9xQkK07SdXSAjhgkDqBLMGKQPvL8zZ9rL1Xm8Tpc+LB2uwuaxYTRRpR10n2rb1MqnNXex6nW93+IKNM= X-Received: by 2002:a17:906:4a48:: with SMTP id a8mr17378379ejv.57.1555364413228; Mon, 15 Apr 2019 14:40:13 -0700 (PDT) MIME-Version: 1.0 References: <1555077139-244831-1-git-send-email-ying.a.wang@intel.com> <1555077139-244831-3-git-send-email-ying.a.wang@intel.com> In-Reply-To: <1555077139-244831-3-git-send-email-ying.a.wang@intel.com> From: Rami Rosen Date: Tue, 16 Apr 2019 00:40:05 +0300 Message-ID: To: Wang Ying A Cc: wenzhuo.lu@intel.com, qiming.yang@intel.com, dev@dpdk.org, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 2/2] net/ice: fix promiscuous mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190415214005.TuJrFotLnMp5Zn_s3HoM01INkCw2Jq48NzDxgBP2LCo@z> Wang Ying A =E2=80=8F: > When device promiscuous mode has already been enabled, > if user re-enables the promisc mode, he/she should be > prompted with "Promisc has already been enabled" > rather than "Failed to enable promisc". > > Fixes: c945e4bf9063 ("net/ice: support promiscuous mode") > Cc: stable@dpdk.org > > Signed-off-by: Wang Ying A > --- > Reviewed-by: Rami Rosen