From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by dpdk.org (Postfix) with ESMTP id 262A13572 for ; Wed, 13 Mar 2019 20:35:54 +0100 (CET) Received: by mail-ed1-f66.google.com with SMTP id d6so2016194eds.2 for ; Wed, 13 Mar 2019 12:35:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uQYCDYlmKN6Ao4AWrqoigQfTMc5lIODnKjOyGbtlAOM=; b=N0IYu0d1/G6Ys9llucL6LvbFgrWHgwH1Wt72+FDMcH6XNcFVstZd2qNtUTT4cSVsqp zBasKKrAqdCcq2NBEv0EosJhnK3BsxvtsRwSra1P9irFNNbSOvlXY9sdDWBymDVtuuhY xs+Bi+TwCEoznIRuPeUkB5xH5Q4slvrK9juhfjjN8wiVIawgL8bX50y7OW7WXh/cBhRJ jZDowszwFzhxfpciIIPPbhMGkRK+24YL7iIz3gos3gYoeuyVohArwhG2jCtCnoB2MZ6A cwF6Gk8C+ON3hUD+FxZKu1Zh10Rm2I35dLnZj+Im9s9YvV0o688Ft8JEp+vIw5H21k88 MzhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uQYCDYlmKN6Ao4AWrqoigQfTMc5lIODnKjOyGbtlAOM=; b=mf6K/1NlWg6RPHO3It7Lbxfw2FnSDkejuMYw5acGLZFwgE3s9r0BSN9ttUIsG/IjZ9 yL77KYupXMMpKYa03awAqk80K7W8DYNZCLrWt1oFKWM8tCuezM3Q1ALrDCl6bgDaPF59 YheYCV6jnx6Pzweqqjiz6SFJr7VkWYdfJb8DKgwUqC5/T6BwGAS0NVaP2JQFMkKPj444 nuzXKH4ASG8GDxJRs5EqafskdIhcUBXzAj8cnHblVBZgZOMkKp0K4IpXpg0VkCybh+aN RDAkjIKaqUya/qYWOX47IqMc0tjh/5AE6k8fOUaDBNShOd9x2hhZOLGV/3TmYzPG5Pe5 7nlw== X-Gm-Message-State: APjAAAXCvx4SwW9DF7QjsHC2H6+k6XNG/hv05SubN25VOJIkFxGYwX91 nL9SUmtFkod73KQdSxc+DJbXpRwrhP3HZ8TS2YA= X-Google-Smtp-Source: APXvYqzO4KnrYpsCAreTFbYcG9hQmGDA0xIWqJ4dsf71+YFyBOuI+rORVhus3LRRCXQ0CnyqHQDphU6Ek1nqYjEKngk= X-Received: by 2002:a17:906:b7c2:: with SMTP id fy2mr30759454ejb.9.1552505753519; Wed, 13 Mar 2019 12:35:53 -0700 (PDT) MIME-Version: 1.0 References: <20190312192703.18554-1-stephen@networkplumber.org> In-Reply-To: <20190312192703.18554-1-stephen@networkplumber.org> From: Rami Rosen Date: Wed, 13 Mar 2019 21:35:41 +0200 Message-ID: To: Stephen Hemminger Cc: jerinj@marvell.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/octeontx: fix vdev name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Mar 2019 19:35:54 -0000 > The octeontx driver is creating vdev with name "OCTEONTX_PMD" > which is an artifact from how RTE_PMD_REGISTER_VDEV arguments > work. > > Change to use the same convention as all the other network > driverse ("net_octeontx"). > > Signed-off-by: Stephen Hemminger > --- > 1. Actuaully in the patch itself it is: +#define OCTEONTX_PMD net_octeon Shouldn't it be "net_octeontx" as in the commit log ? 2. Typo in commit log: driverse->drivers Reviewed-by: Rami Rosen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7898DA0096 for ; Wed, 13 Mar 2019 20:35:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 282F9374E; Wed, 13 Mar 2019 20:35:55 +0100 (CET) Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by dpdk.org (Postfix) with ESMTP id 262A13572 for ; Wed, 13 Mar 2019 20:35:54 +0100 (CET) Received: by mail-ed1-f66.google.com with SMTP id d6so2016194eds.2 for ; Wed, 13 Mar 2019 12:35:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uQYCDYlmKN6Ao4AWrqoigQfTMc5lIODnKjOyGbtlAOM=; b=N0IYu0d1/G6Ys9llucL6LvbFgrWHgwH1Wt72+FDMcH6XNcFVstZd2qNtUTT4cSVsqp zBasKKrAqdCcq2NBEv0EosJhnK3BsxvtsRwSra1P9irFNNbSOvlXY9sdDWBymDVtuuhY xs+Bi+TwCEoznIRuPeUkB5xH5Q4slvrK9juhfjjN8wiVIawgL8bX50y7OW7WXh/cBhRJ jZDowszwFzhxfpciIIPPbhMGkRK+24YL7iIz3gos3gYoeuyVohArwhG2jCtCnoB2MZ6A cwF6Gk8C+ON3hUD+FxZKu1Zh10Rm2I35dLnZj+Im9s9YvV0o688Ft8JEp+vIw5H21k88 MzhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uQYCDYlmKN6Ao4AWrqoigQfTMc5lIODnKjOyGbtlAOM=; b=mf6K/1NlWg6RPHO3It7Lbxfw2FnSDkejuMYw5acGLZFwgE3s9r0BSN9ttUIsG/IjZ9 yL77KYupXMMpKYa03awAqk80K7W8DYNZCLrWt1oFKWM8tCuezM3Q1ALrDCl6bgDaPF59 YheYCV6jnx6Pzweqqjiz6SFJr7VkWYdfJb8DKgwUqC5/T6BwGAS0NVaP2JQFMkKPj444 nuzXKH4ASG8GDxJRs5EqafskdIhcUBXzAj8cnHblVBZgZOMkKp0K4IpXpg0VkCybh+aN RDAkjIKaqUya/qYWOX47IqMc0tjh/5AE6k8fOUaDBNShOd9x2hhZOLGV/3TmYzPG5Pe5 7nlw== X-Gm-Message-State: APjAAAXCvx4SwW9DF7QjsHC2H6+k6XNG/hv05SubN25VOJIkFxGYwX91 nL9SUmtFkod73KQdSxc+DJbXpRwrhP3HZ8TS2YA= X-Google-Smtp-Source: APXvYqzO4KnrYpsCAreTFbYcG9hQmGDA0xIWqJ4dsf71+YFyBOuI+rORVhus3LRRCXQ0CnyqHQDphU6Ek1nqYjEKngk= X-Received: by 2002:a17:906:b7c2:: with SMTP id fy2mr30759454ejb.9.1552505753519; Wed, 13 Mar 2019 12:35:53 -0700 (PDT) MIME-Version: 1.0 References: <20190312192703.18554-1-stephen@networkplumber.org> In-Reply-To: <20190312192703.18554-1-stephen@networkplumber.org> From: Rami Rosen Date: Wed, 13 Mar 2019 21:35:41 +0200 Message-ID: To: Stephen Hemminger Cc: jerinj@marvell.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/octeontx: fix vdev name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190313193541.r6CA4T3qx3Pm04mrbovadI2vTz2O1w4ZAeIe-rC6mJs@z> > The octeontx driver is creating vdev with name "OCTEONTX_PMD" > which is an artifact from how RTE_PMD_REGISTER_VDEV arguments > work. > > Change to use the same convention as all the other network > driverse ("net_octeontx"). > > Signed-off-by: Stephen Hemminger > --- > 1. Actuaully in the patch itself it is: +#define OCTEONTX_PMD net_octeon Shouldn't it be "net_octeontx" as in the commit log ? 2. Typo in commit log: driverse->drivers Reviewed-by: Rami Rosen