Re: [dpdk-dev] [PATCH] net/mlx5: call generic strlcpy

[Rami Rosen <ramirose@gmail.com>]

Checked on Fedora 28

Reviewed-by: Rami Rosen <ramirose at gmail.com>


On Mon, Feb 25, 2019 at 12:42 AM Thomas Monjalon <thomas@monjalon.net>
wrote:

> The call to strlcpy uses either libc, libbsd or internal rte_strlcpy.
> No need to call the DPDK flavor explictly.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  drivers/net/mlx5/mlx5.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
> index df71707ccb..bda909eaa5 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -785,7 +785,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
>         }
>         /* Build device name. */
>         if (!switch_info->representor)
> -               rte_strlcpy(name, dpdk_dev->name, sizeof(name));
> +               strlcpy(name, dpdk_dev->name, sizeof(name));
>         else
>                 snprintf(name, sizeof(name), "%s_representor_%u",
>                          dpdk_dev->name, switch_info->port_name);
> --
> 2.20.1
>
>

-- 
regards,
Rami Rosen