* [dpdk-dev] [PATCH] net/mlx5: call generic strlcpy
@ 2019-02-24 22:42 Thomas Monjalon
2019-02-25 6:26 ` Rami Rosen
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2019-02-24 22:42 UTC (permalink / raw)
To: Shahaf Shuler, Yongseok Koh; +Cc: dev, ophirmu
The call to strlcpy uses either libc, libbsd or internal rte_strlcpy.
No need to call the DPDK flavor explictly.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
drivers/net/mlx5/mlx5.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index df71707ccb..bda909eaa5 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -785,7 +785,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
}
/* Build device name. */
if (!switch_info->representor)
- rte_strlcpy(name, dpdk_dev->name, sizeof(name));
+ strlcpy(name, dpdk_dev->name, sizeof(name));
else
snprintf(name, sizeof(name), "%s_representor_%u",
dpdk_dev->name, switch_info->port_name);
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: call generic strlcpy
2019-02-24 22:42 [dpdk-dev] [PATCH] net/mlx5: call generic strlcpy Thomas Monjalon
@ 2019-02-25 6:26 ` Rami Rosen
2019-03-07 8:35 ` Shahaf Shuler
0 siblings, 1 reply; 3+ messages in thread
From: Rami Rosen @ 2019-02-25 6:26 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: Shahaf Shuler, Yongseok Koh, dev, ophirmu
Checked on Fedora 28
Reviewed-by: Rami Rosen <ramirose at gmail.com>
On Mon, Feb 25, 2019 at 12:42 AM Thomas Monjalon <thomas@monjalon.net>
wrote:
> The call to strlcpy uses either libc, libbsd or internal rte_strlcpy.
> No need to call the DPDK flavor explictly.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> drivers/net/mlx5/mlx5.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
> index df71707ccb..bda909eaa5 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -785,7 +785,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
> }
> /* Build device name. */
> if (!switch_info->representor)
> - rte_strlcpy(name, dpdk_dev->name, sizeof(name));
> + strlcpy(name, dpdk_dev->name, sizeof(name));
> else
> snprintf(name, sizeof(name), "%s_representor_%u",
> dpdk_dev->name, switch_info->port_name);
> --
> 2.20.1
>
>
--
regards,
Rami Rosen
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: call generic strlcpy
2019-02-25 6:26 ` Rami Rosen
@ 2019-03-07 8:35 ` Shahaf Shuler
0 siblings, 0 replies; 3+ messages in thread
From: Shahaf Shuler @ 2019-03-07 8:35 UTC (permalink / raw)
To: Rami Rosen, Thomas Monjalon; +Cc: Yongseok Koh, dev, Ophir Munk
Applied to next-net-mlx, thanks.
From: Rami Rosen <ramirose@gmail.com>
Sent: Monday, February 25, 2019 8:26 AM
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Shahaf Shuler <shahafs@mellanox.com>; Yongseok Koh <yskoh@mellanox.com>; dev <dev@dpdk.org>; Ophir Munk <ophirmu@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: call generic strlcpy
Checked on Fedora 28
Reviewed-by: Rami Rosen <ramirose at gmail.com<https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgmail.com&data=02%7C01%7Cshahafs%40mellanox.com%7Ca6471d19ffc94a63e8f308d69aea31bf%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636866727983375321&sdata=JE%2BULD6LG98IBEf6D%2F3bW98LivPLm2QD7xlshkdQDdc%3D&reserved=0>>
On Mon, Feb 25, 2019 at 12:42 AM Thomas Monjalon <thomas@monjalon.net<mailto:thomas@monjalon.net>> wrote:
The call to strlcpy uses either libc, libbsd or internal rte_strlcpy.
No need to call the DPDK flavor explictly.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net<mailto:thomas@monjalon.net>>
---
drivers/net/mlx5/mlx5.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index df71707ccb..bda909eaa5 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -785,7 +785,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
}
/* Build device name. */
if (!switch_info->representor)
- rte_strlcpy(name, dpdk_dev->name, sizeof(name));
+ strlcpy(name, dpdk_dev->name, sizeof(name));
else
snprintf(name, sizeof(name), "%s_representor_%u",
dpdk_dev->name, switch_info->port_name);
--
2.20.1
--
regards,
Rami Rosen
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-07 8:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-24 22:42 [dpdk-dev] [PATCH] net/mlx5: call generic strlcpy Thomas Monjalon
2019-02-25 6:26 ` Rami Rosen
2019-03-07 8:35 ` Shahaf Shuler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).