From: Rami Rosen <ramirose@gmail.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] eal: fix check when retrieving current cpu affinity
Date: Thu, 21 Feb 2019 20:58:05 +0200 [thread overview]
Message-ID: <CAHLOa7T8rLetqx4BCnd4apZVD+FoBW3wTWKh8cn-U_TPZWB39Q@mail.gmail.com> (raw)
In-Reply-To: <1550608693-12882-1-git-send-email-david.marchand@redhat.com>
Reviewed-by: Rami Rosen <ramirose@gmail.com>
בתאריך יום ג׳, 19 בפבר׳ 2019, 22:38, מאת David Marchand <
david.marchand@redhat.com>:
> pthread_getaffinity_np returns a >0 value when failing.
>
> This is mainly for the sake of correctness.
> The only case where it could fail is when passing an incorrect cpuset
> size wrt to the kernel.
>
> Fixes: 2eba8d21f3c9 ("eal: restrict cores auto detection")
> Cc: stable@dpdk.org
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Changelog since v1:
> - added missing Cc: stable@dpdk.org
>
> ---
> lib/librte_eal/common/eal_common_options.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_options.c
> b/lib/librte_eal/common/eal_common_options.c
> index 6c96f45..1f45f82 100644
> --- a/lib/librte_eal/common/eal_common_options.c
> +++ b/lib/librte_eal/common/eal_common_options.c
> @@ -1343,10 +1343,9 @@ static int xdigit2val(unsigned char c)
> unsigned int lcore_id;
> unsigned int removed = 0;
> rte_cpuset_t affinity_set;
> - pthread_t tid = pthread_self();
>
> - if (pthread_getaffinity_np(tid, sizeof(rte_cpuset_t),
> - &affinity_set) < 0)
> + if (pthread_getaffinity_np(pthread_self(), sizeof(rte_cpuset_t),
> + &affinity_set))
> CPU_ZERO(&affinity_set);
>
> for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
> --
> 1.8.3.1
>
>
prev parent reply other threads:[~2019-02-21 18:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 13:27 [dpdk-dev] [PATCH] " David Marchand
2019-02-14 16:44 ` Burakov, Anatoly
2019-02-14 17:41 ` David Marchand
2019-02-19 11:40 ` Burakov, Anatoly
2019-02-19 11:55 ` David Marchand
2019-02-19 20:38 ` [dpdk-dev] [PATCH v2] " David Marchand
2019-02-20 16:02 ` Burakov, Anatoly
2019-03-07 15:36 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-02-21 18:58 ` Rami Rosen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHLOa7T8rLetqx4BCnd4apZVD+FoBW3wTWKh8cn-U_TPZWB39Q@mail.gmail.com \
--to=ramirose@gmail.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).