From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by dpdk.org (Postfix) with ESMTP id 449E68E76; Thu, 11 Apr 2019 01:59:05 +0200 (CEST) Received: by mail-ed1-f41.google.com with SMTP id s39so3589986edb.2; Wed, 10 Apr 2019 16:59:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=L9b5NF5eys6SfD7425XFQxzEAe8sKLYH9Nu+q+WZcJM=; b=ggsiyFydJyD1Zr6FTzjjFX5jwfO7ZKEbHPamyfYHiPFttV1AkhNdnSC5M8TIIIY7rH Hx25nv7VazIP3A+lkniXTd1TskR4QtQ68shV3Sg8nI/q1URS9v2Vc62Q0x3ZW2wS29pW phQlsfn4qCTkCg+ZmIRj293ZHzETSOEmot3GwzKUHkHxFC0Dgz/9VjIhlkuEpjwELPFz vlivVxRZ5lKN3GhlbQGsUje4/BOxXjKWjFBuN6YSorq3lij4S2VM5LZMZ33lVpPUYuiQ fjsUsEYHi1ly5bUvGm1v49JU3NGRJ/5/s//z/U+ujDfAU4WIJssPZaU5Pr+hTf8Uqq5y PKFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L9b5NF5eys6SfD7425XFQxzEAe8sKLYH9Nu+q+WZcJM=; b=qxP60UpwarwPBsnO+88rw8UMSO2hpZEe/tEvAj6DLa/cEE+12V9aS6IzxkgzcUlpv2 4IljrO0VOOwesA7P6oHiDZEr4AWfkRB5jokYVmoQYrGV+KMyagiIX6ae2k5YLy2TXkch Z6ePQ+dlrsnlOC6C3xIuIBARu37UUCeE6JrLdIn+YLZ/ERV6r2pcXtLe0TBdZbIQI5/N lY2/mXo8KPpc2qYkVplu1j/9fzlhyfYlH3vLYBhUxqos4PE3x6GuW2Bt2K8zAQGqspDX djt0oPQsNjq8cllfNsmEDRLjyUVZLoTb8Qlbo1wL6Pw6Es/3/XIWTtCVpWxuun/EVIa8 QVrg== X-Gm-Message-State: APjAAAUhNpZ45kybAODdfHl6wLUZkdX1wRh2tWxsnC/p3vFi37W47R3t qk/pBE8h0t68sEUsXecdZilZUc4wvES5u+6m0tg= X-Google-Smtp-Source: APXvYqwZS0R2sswJuB7WAJMXsS59pBQGdIyBzR6bTvN9L+C0SNsdfoqD58Z5ynSGrXzRZgS+Ff73U2SECQJ9x35t7lo= X-Received: by 2002:a50:a4e4:: with SMTP id x33mr29234046edb.61.1554940744775; Wed, 10 Apr 2019 16:59:04 -0700 (PDT) MIME-Version: 1.0 References: <20190410131348.25287-1-david.hunt@intel.com> In-Reply-To: <20190410131348.25287-1-david.hunt@intel.com> From: Rami Rosen Date: Thu, 11 Apr 2019 02:58:57 +0300 Message-ID: To: David Hunt Cc: dev@dpdk.org, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix unreachable code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2019 23:59:05 -0000 David Hunt =E2=80=8F: > A for loop to MAX_VFS had a break as the last line, so the w++ > would never get called, breaking out of the loop after the > first iteration. Remove the break so that the loop can execute > properly. > > Fixes: ace158c4a821 ("examples/vm_power: add check for port count") > Coverity issue: 337682 > > Signed-off-by: David Hunt > --- > Acked-by: Rami Rosen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C73D9A0096 for ; Thu, 11 Apr 2019 01:59:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BA337D0B2; Thu, 11 Apr 2019 01:59:05 +0200 (CEST) Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by dpdk.org (Postfix) with ESMTP id 449E68E76; Thu, 11 Apr 2019 01:59:05 +0200 (CEST) Received: by mail-ed1-f41.google.com with SMTP id s39so3589986edb.2; Wed, 10 Apr 2019 16:59:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=L9b5NF5eys6SfD7425XFQxzEAe8sKLYH9Nu+q+WZcJM=; b=ggsiyFydJyD1Zr6FTzjjFX5jwfO7ZKEbHPamyfYHiPFttV1AkhNdnSC5M8TIIIY7rH Hx25nv7VazIP3A+lkniXTd1TskR4QtQ68shV3Sg8nI/q1URS9v2Vc62Q0x3ZW2wS29pW phQlsfn4qCTkCg+ZmIRj293ZHzETSOEmot3GwzKUHkHxFC0Dgz/9VjIhlkuEpjwELPFz vlivVxRZ5lKN3GhlbQGsUje4/BOxXjKWjFBuN6YSorq3lij4S2VM5LZMZ33lVpPUYuiQ fjsUsEYHi1ly5bUvGm1v49JU3NGRJ/5/s//z/U+ujDfAU4WIJssPZaU5Pr+hTf8Uqq5y PKFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L9b5NF5eys6SfD7425XFQxzEAe8sKLYH9Nu+q+WZcJM=; b=qxP60UpwarwPBsnO+88rw8UMSO2hpZEe/tEvAj6DLa/cEE+12V9aS6IzxkgzcUlpv2 4IljrO0VOOwesA7P6oHiDZEr4AWfkRB5jokYVmoQYrGV+KMyagiIX6ae2k5YLy2TXkch Z6ePQ+dlrsnlOC6C3xIuIBARu37UUCeE6JrLdIn+YLZ/ERV6r2pcXtLe0TBdZbIQI5/N lY2/mXo8KPpc2qYkVplu1j/9fzlhyfYlH3vLYBhUxqos4PE3x6GuW2Bt2K8zAQGqspDX djt0oPQsNjq8cllfNsmEDRLjyUVZLoTb8Qlbo1wL6Pw6Es/3/XIWTtCVpWxuun/EVIa8 QVrg== X-Gm-Message-State: APjAAAUhNpZ45kybAODdfHl6wLUZkdX1wRh2tWxsnC/p3vFi37W47R3t qk/pBE8h0t68sEUsXecdZilZUc4wvES5u+6m0tg= X-Google-Smtp-Source: APXvYqwZS0R2sswJuB7WAJMXsS59pBQGdIyBzR6bTvN9L+C0SNsdfoqD58Z5ynSGrXzRZgS+Ff73U2SECQJ9x35t7lo= X-Received: by 2002:a50:a4e4:: with SMTP id x33mr29234046edb.61.1554940744775; Wed, 10 Apr 2019 16:59:04 -0700 (PDT) MIME-Version: 1.0 References: <20190410131348.25287-1-david.hunt@intel.com> In-Reply-To: <20190410131348.25287-1-david.hunt@intel.com> From: Rami Rosen Date: Thu, 11 Apr 2019 02:58:57 +0300 Message-ID: To: David Hunt Cc: dev@dpdk.org, stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v1] examples/vm_power_manager: fix unreachable code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190410235857.WwHgeYg-t-scYzAVoRQWd1Fg-dLo4AFBS4VweKaN9_g@z> David Hunt =E2=80=8F: > A for loop to MAX_VFS had a break as the last line, so the w++ > would never get called, breaking out of the loop after the > first iteration. Remove the break so that the loop can execute > properly. > > Fixes: ace158c4a821 ("examples/vm_power: add check for port count") > Coverity issue: 337682 > > Signed-off-by: David Hunt > --- > Acked-by: Rami Rosen