* [dpdk-dev] [PATCH] ixgbe 82599: Query assignment of queues to Virtual Function
@ 2013-10-21 14:11 Qinglai Xiao
2013-10-23 9:19 ` [dpdk-dev] [PATCH] ixgbe: query assignment of queues to VF Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Qinglai Xiao @ 2013-10-21 14:11 UTC (permalink / raw)
To: dev
Physical Function assignes Tx/Rx queues to each VF according to
different schemes[1]. By querying through mailbox, VF is able to
get number of Tx/Rx queues assigned to it.
Note that current Intel ixgbe driver ixgbe-3.18.7 does not fully
support mailbox message IXGBE_VF_GET_QUEUES. The service routine
for IXGBE_VF_GET_QUEUES must be fixed, otherwise PF always return
1 as Tx/Rx queue number.
[1] See section 7.2.1.2.1, 7.1.2.2 and 7.10.2.7.2 of Intel 82599 10
Gbe Controller Datasheet.
Signed-off-by: Qinglai Xiao <jigsaw@gmail.com>
---
lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 19 +++++++++++++++++++
1 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
index f217564..e269ad7 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
@@ -750,6 +750,22 @@ eth_ixgbe_dev_init(__attribute__((unused)) struct eth_driver *eth_drv,
return 0;
}
+static void ixgbevf_get_queue_num(struct ixgbe_hw *hw)
+{
+ /* Traffic classes are not supported by now */
+ unsigned int tcs, tc;
+
+ /*
+ * Must let PF know we are at mailbox API 11 level.
+ * Otherwise PF won't answer properly.
+ * In case that PF fails to provide Rx/Tx queue number,
+ * max_tx_queues and max_rx_queues remain to be 1.
+ */
+ if (!ixgbevf_negotiate_api_version(hw, ixgbe_mbox_api_11))
+ ixgbevf_get_queues(hw, &tcs, &tc);
+}
+
+
/*
* Virtual Function device init
*/
@@ -818,6 +834,9 @@ eth_ixgbevf_dev_init(__attribute__((unused)) struct eth_driver *eth_drv,
return (diag);
}
+ /* Get Rx/Tx queue count via mailbox, which is ready after reset_hw */
+ ixgbevf_get_queue_num(hw);
+
/* Allocate memory for storing MAC addresses */
eth_dev->data->mac_addrs = rte_zmalloc("ixgbevf", ETHER_ADDR_LEN *
hw->mac.num_rar_entries, 0);
--
1.7.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] ixgbe: query assignment of queues to VF
2013-10-21 14:11 [dpdk-dev] [PATCH] ixgbe 82599: Query assignment of queues to Virtual Function Qinglai Xiao
@ 2013-10-23 9:19 ` Thomas Monjalon
2013-10-23 12:26 ` jigsaw
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Monjalon @ 2013-10-23 9:19 UTC (permalink / raw)
To: Qinglai Xiao; +Cc: dev
21/10/2013 16:11, Qinglai Xiao :
> Physical Function assignes Tx/Rx queues to each VF according to
> different schemes[1]. By querying through mailbox, VF is able to
> get number of Tx/Rx queues assigned to it.
>
> Note that current Intel ixgbe driver ixgbe-3.18.7 does not fully
> support mailbox message IXGBE_VF_GET_QUEUES. The service routine
> for IXGBE_VF_GET_QUEUES must be fixed, otherwise PF always return
> 1 as Tx/Rx queue number.
>
> [1] See section 7.2.1.2.1, 7.1.2.2 and 7.10.2.7.2 of Intel 82599 10
> Gbe Controller Datasheet.
>
> Signed-off-by: Qinglai Xiao <jigsaw@gmail.com>
Acked and applied with light modifications:
- * Must let PF know we are at mailbox API 11 level.
+ * Must let PF know we are at mailbox API version 1.1.
> +}
> +
> +
> /*
> * Virtual Function device init
Only 1 empty line is sufficient here.
Thanks for your patch.
Please, keep us informed about the needed PF patch.
--
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] ixgbe: query assignment of queues to VF
2013-10-23 9:19 ` [dpdk-dev] [PATCH] ixgbe: query assignment of queues to VF Thomas Monjalon
@ 2013-10-23 12:26 ` jigsaw
2013-10-24 8:48 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: jigsaw @ 2013-10-23 12:26 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
Hi Thomas,
>>Please, keep us informed about the needed PF patch.
First of all, where and how should I post the patch to PF driver?
And secondly I have only 82599, so I cannot run test for 82598 and
X540. Is it possible that you could test on different NIC?
thx &
rgds,
-ql
On Wed, Oct 23, 2013 at 12:19 PM, Thomas Monjalon
<thomas.monjalon@6wind.com> wrote:
> 21/10/2013 16:11, Qinglai Xiao :
>> Physical Function assignes Tx/Rx queues to each VF according to
>> different schemes[1]. By querying through mailbox, VF is able to
>> get number of Tx/Rx queues assigned to it.
>>
>> Note that current Intel ixgbe driver ixgbe-3.18.7 does not fully
>> support mailbox message IXGBE_VF_GET_QUEUES. The service routine
>> for IXGBE_VF_GET_QUEUES must be fixed, otherwise PF always return
>> 1 as Tx/Rx queue number.
>>
>> [1] See section 7.2.1.2.1, 7.1.2.2 and 7.10.2.7.2 of Intel 82599 10
>> Gbe Controller Datasheet.
>>
>> Signed-off-by: Qinglai Xiao <jigsaw@gmail.com>
>
> Acked and applied with light modifications:
>
> - * Must let PF know we are at mailbox API 11 level.
> + * Must let PF know we are at mailbox API version 1.1.
>
>> +}
>> +
>> +
>> /*
>> * Virtual Function device init
>
> Only 1 empty line is sufficient here.
>
> Thanks for your patch.
> Please, keep us informed about the needed PF patch.
> --
> Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] ixgbe: query assignment of queues to VF
2013-10-23 12:26 ` jigsaw
@ 2013-10-24 8:48 ` Thomas Monjalon
2013-10-24 9:38 ` jigsaw
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Monjalon @ 2013-10-24 8:48 UTC (permalink / raw)
To: jigsaw; +Cc: dev
23/10/2013 14:26, jigsaw :
> First of all, where and how should I post the patch to PF driver?
You should send your patch to kernel.org via the netdev mailing list:
http://vger.kernel.org/vger-lists.html#netdev
> And secondly I have only 82599, so I cannot run test for 82598 and
> X540. Is it possible that you could test on different NIC?
I don't know if I'll have access to 82598 and X540 in the next weeks.
Is there anybody else who would like to help with tests ?
--
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] ixgbe: query assignment of queues to VF
2013-10-24 8:48 ` Thomas Monjalon
@ 2013-10-24 9:38 ` jigsaw
0 siblings, 0 replies; 5+ messages in thread
From: jigsaw @ 2013-10-24 9:38 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev
Hi Thomas,
Thanks for your answer. I'll try to send the patch to netdev list and
let you know the result.
BTW, I double checked 82598 and find that it doesn't have mailbox at
all, meaning this patch is for 82599 and X540 only.
So the test is only needed for X540.
thx &
rgds,
-ql
On Thu, Oct 24, 2013 at 11:48 AM, Thomas Monjalon
<thomas.monjalon@6wind.com> wrote:
> 23/10/2013 14:26, jigsaw :
>> First of all, where and how should I post the patch to PF driver?
>
> You should send your patch to kernel.org via the netdev mailing list:
> http://vger.kernel.org/vger-lists.html#netdev
>
>> And secondly I have only 82599, so I cannot run test for 82598 and
>> X540. Is it possible that you could test on different NIC?
>
> I don't know if I'll have access to 82598 and X540 in the next weeks.
> Is there anybody else who would like to help with tests ?
>
> --
> Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-10-24 9:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-10-21 14:11 [dpdk-dev] [PATCH] ixgbe 82599: Query assignment of queues to Virtual Function Qinglai Xiao
2013-10-23 9:19 ` [dpdk-dev] [PATCH] ixgbe: query assignment of queues to VF Thomas Monjalon
2013-10-23 12:26 ` jigsaw
2013-10-24 8:48 ` Thomas Monjalon
2013-10-24 9:38 ` jigsaw
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).