From: jigsaw <jigsaw@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] Need comment on 82599 TSO
Date: Fri, 4 Oct 2013 20:28:25 +0300 [thread overview]
Message-ID: <CAHVfvh5PWhvHfeYZh6n3PCoqBE_YDQ-jUjGm-MbSABo9DhN2cg@mail.gmail.com> (raw)
In-Reply-To: <20131004094122.0166e406@nehalam.linuxnetplumber.net>
Hi Stephen,
Thanks for comment. Pls check the other thread that I just posted.
thx &
rgds,
-Qinglai
On Fri, Oct 4, 2013 at 7:41 PM, Stephen Hemminger
<stephen@networkplumber.org> wrote:
> On Fri, 4 Oct 2013 15:44:19 +0300
> jigsaw <jigsaw@gmail.com> wrote:
>
>> Hi,
>>
>> I'm working on TSO for 82599, and encounter a problem: nowhere to store MSS.
>>
>> TSO must be aware of MSS, or gso in skb of kernel.
>> But MSS nees 16 bits per mbuf. And we have no spare 16 bits in
>> rte_mbuf or rte_pktmbuf.
>> If we add 16 bit field in rte_pktmbuf, the size of rte_mbuf will be
>> doubled, coz currently the size is at the edge of cacheline(32 byte).
>>
>> I have two solutions here:
>>
>> 1. Store MSS in struct rte_eth_conf.
>> This is actually a very bad idea, coz MSS is not bound to device.
>>
>> 2. Turn on and off TSO with rte_ctrlmbuf.
>> I found that rte_ctrlmbuf is not used at all. So it could be the first
>> use case of it.
>> With rte_ctrlmbuf we have enough space to store MSS.
>>
>> Looking forward to your comments.
>>
>> thx &
>> rgds,
>> -Qinglai
>
> The mbuf needs to grow to 2 cache lines. There are other things that need
> to be added to mbuf eventually as well. For example the QoS bitfield is
> too small when crammed into 32 bits. Ideally the normal small packet
> stuff would be in the first cacheline; and the other part of the struct
> would have things less likely to be used.
next prev parent reply other threads:[~2013-10-04 17:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 12:44 jigsaw
2013-10-04 16:41 ` Stephen Hemminger
2013-10-04 17:28 ` jigsaw [this message]
2013-10-04 18:09 ` Venkatesan, Venky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHVfvh5PWhvHfeYZh6n3PCoqBE_YDQ-jUjGm-MbSABo9DhN2cg@mail.gmail.com \
--to=jigsaw@gmail.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).