From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-x22e.google.com (mail-ie0-x22e.google.com [IPv6:2607:f8b0:4001:c03::22e]) by dpdk.org (Postfix) with ESMTP id CDF17683B for ; Wed, 25 Sep 2013 16:55:30 +0200 (CEST) Received: by mail-ie0-f174.google.com with SMTP id u16so10743829iet.19 for ; Wed, 25 Sep 2013 07:56:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Qa5339tuXTlLHkoU8Aa/D+h9FPN0GvMz8ewynOrQD2s=; b=MsKDC2Cgj6V4xQft8gQQMLKnbt2zMs3BDONNZwgEW3Qr/5VyXSl+RSq7sYAP+YzbJB rRFirqYegDTM1WPgKUf16dEbafe9tmf8GCS38olQMZlj12yTJRo5+bETkBx7QzUTYETm Rxp/T5+uH5yt3yWfoZS/61L6NltVdUJTbmqfH/N5+3W9OIM2H2u7622IyZBu7G2kvzuD SNlXPsUcW3dIwVeykOsHkDi6067x2TkpbfReKTdHehOK3jBLiTVBwMU3ksG10ycG0sQ+ o5OYtbDtuS/j4znfnXL7CEN/1pa8M2oa9D+aGrgqjfMC0CU9G1JW3ldlqiAG3R8xzodq 6j1w== MIME-Version: 1.0 X-Received: by 10.42.204.4 with SMTP id fk4mr28450297icb.31.1380120971180; Wed, 25 Sep 2013 07:56:11 -0700 (PDT) Received: by 10.42.67.205 with HTTP; Wed, 25 Sep 2013 07:56:11 -0700 (PDT) In-Reply-To: <201309251647.26757.thomas.monjalon@6wind.com> References: <1379963780-5044-1-git-send-email-jigsaw@gmail.com> <1FD9B82B8BF2CF418D9A1000154491D973F50C7E@ORSMSX102.amr.corp.intel.com> <201309251647.26757.thomas.monjalon@6wind.com> Date: Wed, 25 Sep 2013 17:56:11 +0300 Message-ID: From: jigsaw To: Thomas Monjalon Content-Type: text/plain; charset=ISO-8859-1 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] Add support for 82599 Tx->Rx loopback operation. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Sep 2013 14:55:31 -0000 Hi Thomas, The patch can be made without modifying ixgbe/ at all, I will make another attempt. Please see the proposal in my previous email. The question is how to keep the lpbk_mode field in struct rte_eth_conf future-proof. Or if this is overkill to think about possible future loopback support at this moment? thx & rgds, -qinglai On Wed, Sep 25, 2013 at 5:47 PM, Thomas Monjalon wrote: > 25/09/2013 16:12, Venkatesan, Venky : >> I for one would prefer that the changes not really modify any files in the >> librte_pmd_ixgbe/ixgbe directory. Those files are derived directly from >> the BSD driver baseline, and any changes will make future merges of newer >> code more challenging. The changes should be limited to files in the >> librte_pmd_ixgbe directory (and ethdev). > > I agree with Venky. > The poll-mode drivers e1000 and ixgbe are based on drivers located in > subdirectories e1000/ and ixgbe/. And by design, these poll-mode drivers use > the base drivers without modifying it. > So please try to restrict your changes to ixgbe_ethdev.c and ixgbe_rxtx.c. > > The coding rules are not written. If needed, we could add a file for it. > > Thanks for your patch > -- > Thomas