DPDK patches and discussions
 help / color / mirror / Atom feed
From: jigsaw <jigsaw@gmail.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Subject: [dpdk-dev]  Need comment on 82599 TSO
Date: Fri, 4 Oct 2013 15:44:19 +0300	[thread overview]
Message-ID: <CAHVfvh72zK24cb4TiBQdGo1We-J3BU-=JN7rYO9y-gtMCgPMJg@mail.gmail.com> (raw)

Hi,

I'm working on TSO for 82599, and encounter a problem: nowhere to store MSS.

TSO must be aware of MSS, or gso in skb of kernel.
But MSS nees 16 bits per mbuf. And we have no spare 16 bits in
rte_mbuf or rte_pktmbuf.
If we add 16 bit field in rte_pktmbuf, the size of rte_mbuf will be
doubled, coz currently the size is at the edge of cacheline(32 byte).

I have two solutions here:

1. Store MSS in struct rte_eth_conf.
This is actually a very bad idea, coz MSS is not bound to device.

2. Turn on and off TSO with rte_ctrlmbuf.
I found that rte_ctrlmbuf is not used at all. So it could be the first
use case of it.
With rte_ctrlmbuf we have enough space to store MSS.

Looking forward to your comments.

thx &
rgds,
-Qinglai

             reply	other threads:[~2013-10-04 12:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-04 12:44 jigsaw [this message]
2013-10-04 16:41 ` Stephen Hemminger
2013-10-04 17:28   ` jigsaw
2013-10-04 18:09   ` Venkatesan, Venky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHVfvh72zK24cb4TiBQdGo1We-J3BU-=JN7rYO9y-gtMCgPMJg@mail.gmail.com' \
    --to=jigsaw@gmail.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).