From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3904AA055C; Fri, 3 Jun 2022 13:02:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC5FD40694; Fri, 3 Jun 2022 13:02:27 +0200 (CEST) Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by mails.dpdk.org (Postfix) with ESMTP id 5CE2540691 for ; Fri, 3 Jun 2022 13:02:26 +0200 (CEST) Received: by mail-ej1-f54.google.com with SMTP id me5so14694258ejb.2 for ; Fri, 03 Jun 2022 04:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emumba-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=Ldr2iS0BlcCOB370qszRtokpHVr+JHmXqHB7iwG+rLg=; b=euMmlPzG8tlYa89enqcoVTHHgmaIE5DD5iaWn8MTTbfIJZoQtMZzNX8jU+GaxUZJVa YAHAcwQLfR7jQhxsidrlL50+OvED8YO+YUKT8RYHJiEHhLxKh0gohW4cUWp01lmh7Gfr t/bC9whxuYZRlCGpgGR67NCS/2jwMiW1tFpNZh+hbSV5Lu3UGcMsldpSRsHrbmh3U1uy vg9pGDlXBSTaqQNdDYU6hpY0k2yoUv9Qvs17P3TuKcW+ivLlq17GELs7O9GASyAjW/Le KnnozxfsjTTkTaPidZ8766HrMQ17ygZbgGhEV/kQwv+FTLTcCaaZdVQdpVmEM6RrOmNy fiJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Ldr2iS0BlcCOB370qszRtokpHVr+JHmXqHB7iwG+rLg=; b=PKg8vt8ONeOS0gwx7F9xEZiqyIRgNQDmkY0OBPRZ+x3TZydsS+yFtip5bt7HxZvDYi Jk4M6655mALBNeLC2eDcvuif1JuYZ0xIpr9RmHtklW52qA+vFKNO4jPFQeKO3tqMTV3k NyT1QON9pfZE7gp1r0TEJRoD5UIv/OKXsCuPL5mlH9C3xNrEUX+Oo0d0RgnlAPPDF3Wx S+exMk1bvMlZCpJO/bXpREdrTVwi5zF7HUnhAM5ZI5y0x4Rxo6yzYWSr60j1K0XwgYPL UVorhhvMGL4CSD4XfSYJz72RNjPsvbbICYCIwHgcD9Po8fx21L6drrtVEiDBcROBCLUi vSGw== X-Gm-Message-State: AOAM531+Fp2on+YNG15d4qG8QV/zl1BW/GOftotgmh2sRb3BEKdcVUPQ U3Z/5tgNEseQSi7crfp35HQDZ1bp4oZV1KstfWd360SXjcirkw== X-Google-Smtp-Source: ABdhPJxh1IeMV3RysFzRG31lu25vOdll7wxbpCMyWZVoqeHxQw+FE+1O8i63wMhD/0B19siIPmYDOLr/eC+fE8OIw0A= X-Received: by 2002:a17:907:7ea6:b0:6ff:78da:e2e8 with SMTP id qb38-20020a1709077ea600b006ff78dae2e8mr7975159ejc.611.1654254145756; Fri, 03 Jun 2022 04:02:25 -0700 (PDT) MIME-Version: 1.0 References: <20220527064244.10224-1-usman.tanveer@emumba.com> In-Reply-To: <20220527064244.10224-1-usman.tanveer@emumba.com> From: Usman Tanveer Date: Fri, 3 Jun 2022 16:02:15 +0500 Message-ID: Subject: Re: [PATCH] ethtool: remove a redundant call to rte_eth_dev_stop() To: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, I've submitted a patch on 27th May, 2022. One of the tests is failing and I think it is not related to the patch. Following test is failing: - ci/github-robot: build Can you please rerun the tests so that the patch can be submitted. Regards, -Usman On Fri, May 27, 2022 at 11:42 AM Usman Tanveer wrote: > > There is a call to rte_eth_dev_stop() in rte_ethtool_net_open() > due to which user gets misleading message upon first open/start call. > It says that the > device is already stopped, which should not be the case. This patch > removes rte_eth_dev_stop() from rte_ethtool_net_open(). > > Signed-off-by: Usman Tanveer > --- > examples/ethtool/lib/rte_ethtool.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c > index ffaad96498..0a000d0a7b 100644 > --- a/examples/ethtool/lib/rte_ethtool.c > +++ b/examples/ethtool/lib/rte_ethtool.c > @@ -297,12 +297,6 @@ rte_ethtool_set_pauseparam(uint16_t port_id, > int > rte_ethtool_net_open(uint16_t port_id) > { > - int ret; > - > - ret = rte_eth_dev_stop(port_id); > - if (ret != 0) > - return ret; > - > return rte_eth_dev_start(port_id); > } > > -- > 2.25.1 >