From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55CA841BE4; Mon, 6 Feb 2023 02:13:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F8D440A7D; Mon, 6 Feb 2023 02:13:52 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id CAD54406A2 for ; Mon, 6 Feb 2023 02:13:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675646030; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5pXhK2/abousPRl+9o8C7oYwDZj6fEU65uTwPui3VF0=; b=AbKjQZ2YCajnkc53ac/f7xg/q4FzXJfyV/7QouGpiSQxVg7zIax3EzUZlakCfk9po+dygQ WRgoy4rZDUi6iKaExvky0pAXPs5py7YI9z3Fu7ch8SSzAHxa/tMp9cjN1qVu0NNcVKKQIX XPtIObiFUd0GeYbKSQZGzvXja778eZE= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-93-ttiwpZRpNLKB5FMRRLnUhw-1; Sun, 05 Feb 2023 20:13:49 -0500 X-MC-Unique: ttiwpZRpNLKB5FMRRLnUhw-1 Received: by mail-ej1-f72.google.com with SMTP id nd38-20020a17090762a600b00871ff52c6b5so7415420ejc.0 for ; Sun, 05 Feb 2023 17:13:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5pXhK2/abousPRl+9o8C7oYwDZj6fEU65uTwPui3VF0=; b=CjWKTfIyZ1/NKr+dCQKwA3F0pS1olpyFEQ6cPGWTYHP9DTeiVD3v94SJm7Ei2bx8SL UmbhCBms9S2Iwtwus/INzSdEKFff0xjNU6Q9fN7jjCpnXbqegNS4FNSeceOgwXHwhXAB ckkmh9zB6htJHsIiDMCtvTWixK1RndSjy2lhlkBFiWAx7n3WoROyWzdqBtR7ixwSLkuV 3TMWMAs2f7Lj4fnYY2AqLSl/Kj0WhmB8ZokFxhMa9r4CT94zX1OpS4GFEpR1oE/HmBXL wxi0CpAeN/sFWiz0t3iSKSkGckuIlGfjKSip/Oi9lOIp0ZxYdCQxxgaU5Ueqjev3bdI8 /M4Q== X-Gm-Message-State: AO0yUKW+JZG6nTAKQz4OAKniF/IXaMrbuy0uGBxMAeIQXnQt9cHYUS43 Dnn7PMENlHDNVO/7H2s2PfeN9X4Xzv+FHqgwPL6YTpWIEfnXCGAefnENn9ZZkmckl9eBFv/K1Mu ipIdBTtzM0h0No0KvGaI= X-Received: by 2002:a50:9b53:0:b0:4aa:abae:199f with SMTP id a19-20020a509b53000000b004aaabae199fmr739939edj.47.1675646027721; Sun, 05 Feb 2023 17:13:47 -0800 (PST) X-Google-Smtp-Source: AK7set8SNeRo2u/eAMGUDtZxUV0edTL93DeneKbxK/iJrJoEjo3xzPjZiKiOiRX909GeFburbFzUEU3irbDevDxrir0= X-Received: by 2002:a50:9b53:0:b0:4aa:abae:199f with SMTP id a19-20020a509b53000000b004aaabae199fmr739936edj.47.1675646027577; Sun, 05 Feb 2023 17:13:47 -0800 (PST) MIME-Version: 1.0 References: <20221206150509.772408-1-mkp@redhat.com> <20230203094545.1e91f183@hermes.local> In-Reply-To: <20230203094545.1e91f183@hermes.local> From: Mike Pattrick Date: Sun, 5 Feb 2023 20:13:36 -0500 Message-ID: Subject: Re: [PATCH v2] vhost: exclude VM hugepages from coredumps To: Stephen Hemminger Cc: Maxime Coquelin , Chenbo Xia , dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Feb 3, 2023 at 12:45 PM Stephen Hemminger wrote: > > On Tue, 6 Dec 2022 10:05:09 -0500 > Mike Pattrick wrote: > > > + > > +static __rte_always_inline void > > +mem_set_dump(__rte_unused void *ptr, __rte_unused size_t size, __rte_unused bool enable) > > +{ > > +#ifdef MADV_DONTDUMP > > + if (madvise(ptr, size, enable ? MADV_DODUMP : MADV_DONTDUMP) == -1) { > > + rte_log(RTE_LOG_INFO, vhost_config_log_level, > > + "VHOST_CONFIG: could not set coredump preference (%s).\n", strerror(errno)); > > + } > > +#endif > > +} > > Why is this inlined in vhost.h? Hardly a critical path function. > Hello Steven, I thought it was appropriate here due to the size and contents of that function. Thanks, M