From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0F5AA0503; Fri, 1 Apr 2022 11:09:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C105C4067E; Fri, 1 Apr 2022 11:09:57 +0200 (CEST) Received: from mail-vs1-f41.google.com (mail-vs1-f41.google.com [209.85.217.41]) by mails.dpdk.org (Postfix) with ESMTP id 01D264014F for ; Fri, 1 Apr 2022 11:09:56 +0200 (CEST) Received: by mail-vs1-f41.google.com with SMTP id k15so2055307vsr.11 for ; Fri, 01 Apr 2022 02:09:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=smartx-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wWDfsx7LGqEA/3MXfAZEoFYFBpl+ym0zaAwYXHTo4z4=; b=abe26mb45SOkCLIKglu/4l8KK/wVpLHhzdOIlFvy42XyHtHor+qVOn8fmYhzfGVkQZ qNN499oCk68DdP/3um4ArAqYhUgetADcStCxCvnHhOB8Ej7wI0YW1sKznpwgv9D33GTo PvAUMmc5+ohRsEO0OtJ3/jWqe392w5FP3JcehBkIrwd0ZQvUxqYr4iop4EPUHnxTIHZU u/vZL4fb5PlBHL9ge/rIYZO1/PNznGxXFPQseYTPeOUmkDYkiW9Eoum1bBpRLpoIASnW RJfixej7nXUXxQxP4bf4G56DqXftazGK4zf7Ws/HSTlqvKwqmZE8z7Hi3soeKWta4mpR gumA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wWDfsx7LGqEA/3MXfAZEoFYFBpl+ym0zaAwYXHTo4z4=; b=cerTU79xriTKbN3BiOcGupDvLx4/CBsZABRMdlSe8VDVa+u1tdITxN7VUrj/4eRmt0 4TGaQHIPYj3+bGIeNGcBxyE6zn2A9E1OfkLRitv17Y/NurxP3Rk+BHw9GRjVNsNmDs+f or0UcJs4F+MB8ebw1FvpoBswqCDB97WRT+qMXdazAXmw+aERFw/TDPksWt8GtIMlGGt0 en+jZEYDmx5FzIEwkT9X52IJ/Jc3vBfM+e+djrpEY3KUD8JEifA6ddtcdQYU6qQOPsYS V0iK5sLRiRV774ptkJ/11mvZ7XwPGNiCn50lm6DrSSg5dlPRgO+n1joOsBtrZoIAX+6X ih3Q== X-Gm-Message-State: AOAM531tpWt3eDKWObj0IWkm/8EN/YE5829aS9EBuUUs1UcoFiEHOnJI Shy3LN7VAhHnGyprdubEsQllxUAvNMW/A27rNJKVnA== X-Google-Smtp-Source: ABdhPJzU+WvadUu2AQRulhYMyCmLwuWlbo2zgYx0sxQqA4wMKDWZQR+N8rIVxBSKC1cw43C16lm3vkroOXANcLZZDCQ= X-Received: by 2002:a05:6102:34d:b0:325:7e73:cba4 with SMTP id e13-20020a056102034d00b003257e73cba4mr18692483vsa.6.1648804195413; Fri, 01 Apr 2022 02:09:55 -0700 (PDT) MIME-Version: 1.0 References: <20220308094125.2716847-1-fengli@smartx.com> In-Reply-To: From: Li Feng Date: Fri, 1 Apr 2022 17:11:15 +0800 Message-ID: Subject: Re: [PATCH] eal/linux: enable the hugepage mem dump To: "Burakov, Anatoly" Cc: dev Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Mar 31, 2022 at 10:47 PM Burakov, Anatoly wrote: > > On 08-Mar-22 9:41 AM, Li Feng wrote: > > These hugepages include important structures. We should dump these > > hugepages into a coredump file for debugging when generating a coredump. > > > > Signed-off-by: Li Feng > > --- > > lib/eal/linux/eal_memalloc.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/lib/eal/linux/eal_memalloc.c b/lib/eal/linux/eal_memalloc.c > > index f8b1588cae..d7c2eb14a1 100644 > > --- a/lib/eal/linux/eal_memalloc.c > > +++ b/lib/eal/linux/eal_memalloc.c > > @@ -623,6 +623,8 @@ alloc_seg(struct rte_memseg *ms, void *addr, int socket_id, > > goto resized; > > } > > > > + eal_mem_set_dump(va, alloc_sz, true); > > + > > /* In linux, hugetlb limitations, like cgroup, are > > * enforced at fault time instead of mmap(), even > > * with the option of MAP_POPULATE. Kernel will send > > I am amicable to the idea of including allocated hugepage data in core > dumps, but even with that assumption, i think you're setting the dump > flag a little too early, and never cleanup if something fails down the line. > > Perhaps move this to the very end of the function, after we have > succeeded in creating a new segment? Done in the v2, thanks. > > -- > Thanks, > Anatoly