From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id BC5B44C8C for ; Sat, 3 Mar 2018 17:52:11 +0100 (CET) Received: by mail-wr0-f195.google.com with SMTP id f14so13069464wre.8 for ; Sat, 03 Mar 2018 08:52:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=sw+/25wML4Z4V7grmv6DIigOq00mq8s8u58oU2pLf4o=; b=RxuVBiVDjsy/SqX6hYrDU5Di0XlAoSNd8KYvQV1WNsra0cCHLcdaH/gAZTbjYIclgk DcS+HZ3+V/5cKZQuA4NuzSuRQ4b0brK/sEFRim0X2SQTz6KdRwcRbV+2YWVdDSEq3bDx RPktqCGCr9i8EXis04hVzD6xiyR0T/NmvqEfq1FQtIctJpQVrkgSy8JMeBWxVsZ0j5Q6 qS/HpBYalJeKwhi/FlIFIA9iYquf2H8q5m7UJoxXz6LUOg/B6FLiyV6alN+19MtzpL7R V+SScFnrfsVVJabQgGlWbv75ue6c/Mp44Jd+hIf7VkzFz7nkOuOkivpP4ZTPPlE1O5E8 ZSBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=sw+/25wML4Z4V7grmv6DIigOq00mq8s8u58oU2pLf4o=; b=lX73OUiSUnu6lksLOypCrF1penuE/nlDSEv2dzS6vQpWIiIPI2E1I2+sGcaeHfTJnO tg3T76tKvMKvgoIbN0wHm29GBwzfAELDJRvLld1cjXLl83xzbmFsXIbvmei8zms3S7iO jFLkhVLsTptIw7N8eIvQlHkr7AKMASdL+Jy8rnX+4mLMsY+7AUvxJuVWPoI0Gihl8xRI IwONIcGcqOcghJ0Ra4SPKEDKzw/URWtu35Y95pan9zMOKy0Jn9w0lxD0q+woatBS0DLP u6tj3LMuuEoT6lmDlkZIEedrd2MVOlvjCpXmLU3vkvS0pDf0c4EcWB7ccEfMXygyQ8Np ZMPg== X-Gm-Message-State: APf1xPA/6gvtSpEJ6ptVG3nNOfiNdxBdqjBAAxQxBpBQrarYkntqwtel VEn7muzrOKv1IddMc0DmxDHOX9P98Wsq66qsUJhV3l761LtdRA== X-Google-Smtp-Source: AG47ELvwmDY2CNeCPnR5nseR/iZihNfJmQncLRQYiLNlKKwnDGo84/LAWNW9UGmz0fN0h9QM6v/hEhaDo4exksoqIbM= X-Received: by 10.223.138.130 with SMTP id y2mr7500959wry.242.1520095930703; Sat, 03 Mar 2018 08:52:10 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.63.79 with HTTP; Sat, 3 Mar 2018 08:52:09 -0800 (PST) In-Reply-To: References: From: Venkatesh Srinivas Date: Sat, 3 Mar 2018 10:52:09 -0600 Message-ID: To: Anatoly Burakov Cc: dev@dpdk.org, Yuanhan Liu , Maxime Coquelin , Tiwei Bie , keith.wiles@intel.com, jianfeng.tan@intel.com, andras.kovacs@ericsson.com, laszlo.vadkeri@ericsson.com, benjamin.walker@intel.com, bruce.richardson@intel.com, thomas@monjalon.net, konstantin.ananyev@intel.com, kuralamudhan.ramakrishnan@intel.com, louise.m.daly@intel.com, nelio.laranjeiro@6wind.com, yskoh@mellanox.com, pepperjo@japf.ch, jerin.jacob@caviumnetworks.com, hemant.agrawal@nxp.com, olivier.matz@6wind.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 40/41] net/virtio: use contiguous allocation for DMA memory X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Mar 2018 16:52:11 -0000 On Sat, Mar 3, 2018 at 7:46 AM, Anatoly Burakov wrote: > Signed-off-by: Anatoly Burakov > --- > > Notes: > Not sure if virtio needs to allocate DMA-capable memory, > being a software driver and all. Corrections welcome. Reviewed-by: Venkatesh Srinivas 1. The first change is correct - virtio rings need to be contiguous in guest physical address space. 2. The second change - virtio_tx_region contains both a virtio_net_hdr and indirect table. virtio devices require virtio_net_hdr to be contiguous (in pre-1.0 devices w/o F_ANY_LAYOUT) but do not require the indirect table to be contiguous w/ virtio_net_hdr. You may want this to avoid splitting up the structure though. HTH, -- vs;