From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10D01A0093; Tue, 8 Nov 2022 17:25:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A30B2400D7; Tue, 8 Nov 2022 17:25:31 +0100 (CET) Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by mails.dpdk.org (Postfix) with ESMTP id A4291400D4 for ; Tue, 8 Nov 2022 17:25:30 +0100 (CET) Received: by mail-pj1-f45.google.com with SMTP id b1-20020a17090a7ac100b00213fde52d49so13840552pjl.3 for ; Tue, 08 Nov 2022 08:25:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=aRS8xnpha0eqsi0rb53Vg/choiEqKIUTG3mTogIMTRw=; b=UQKBqDsVCO8WxlJMTbb+wV2bdkbB+G0w77hIfq0+BglrSJy+fGSs8npI/nXu6BQvkb izaqMHkrfpAHy8lv0IYJst4ON+PGIey2j0u5S8gwop9l1JJHo66VgQ1SXVT+3EQyqnqF Fb1g3txbxAexZlfEOfdSPm1EBczQTe9UKcevA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aRS8xnpha0eqsi0rb53Vg/choiEqKIUTG3mTogIMTRw=; b=UjBMyPOSqY0bnO8iMoCWM4rHCdoffSR2cHj61K5v8NkA2CxrFR2u6dv/R3Cm24gvGs Qr+mWXuqtaerA38iQC3CkiKyZojabE1OJU01UTyWgtWHZO7RN6U5YPDVERwHSF7Iglpp zuSMLt5UzMe1CCm8p2UgF6ZALh8uq/y5O73jCxcnc39WGrM3onjyHiWq92qfq//0Lkph +66efTvz5WGhIbPjAeoFWyze6m/IOFbUgoDqlF5YNw7rqzMZpYoRNHRXZputX+aqkNOJ tbQZ1SrXqoWF/9WyqR+7jMagfZwXKiLaM960eKA91R0dQwEOk4la3ruO9L6m2/T0cJSz usdw== X-Gm-Message-State: ACrzQf1NvU4XPEEiXncbwfFUCahgI3d2hQYRLg+yhwlSV4PTy82F2tTw 31jYnCyhl0DXNgA+wIuykjFLc7SuO6NZ3fHsM2Tm9Q== X-Google-Smtp-Source: AMsMyM7RP0zPPQxeuWrL/7+tbiGz6sZoJqYtEdFObFBGXTnQ/s6AmpGY+7WI+UVD/mqiixDH81I/pFdVdUYXvPLynak= X-Received: by 2002:a17:90b:2393:b0:213:ecb2:2e04 with SMTP id mr19-20020a17090b239300b00213ecb22e04mr46111435pjb.100.1667924729829; Tue, 08 Nov 2022 08:25:29 -0800 (PST) MIME-Version: 1.0 References: <11915083.eQLIkvUDd3@thomas> In-Reply-To: From: Owen Hilyard Date: Tue, 8 Nov 2022 11:24:53 -0500 Message-ID: Subject: Re: testpmd logging To: Honnappa Nagarahalli Cc: "thomas@monjalon.net" , Aman Singh , Yuying Zhang , "david.marchand@redhat.com" , "dev@dpdk.org" , Lijuan Tu , =?UTF-8?Q?Juraj_Linke=C5=A1?= , nd Content-Type: multipart/alternative; boundary="00000000000008b44905ecf7fdbb" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000008b44905ecf7fdbb Content-Type: text/plain; charset="UTF-8" On Tue, Nov 8, 2022 at 9:37 AM Honnappa Nagarahalli < Honnappa.Nagarahalli@arm.com> wrote: > + Lijuan, Owen, Juraj > > > -----Original Message----- > > From: Thomas Monjalon > > Sent: Tuesday, November 8, 2022 7:02 AM > > To: Aman Singh ; Yuying Zhang > > > > Cc: david.marchand@redhat.com; dev@dpdk.org > > Subject: testpmd logging > > > > Hello, > > > > I see testpmd is doing log with EAL entity. Example: > > RTE_LOG(ERR, EAL, "The device: %s has been added!\n" > > We could also discuss the log level. > > > > Please can we work on replacing these logs? > If we want to revisit logging in testpmd, even though I know I'm invoking a case of second system syndrome here, I would love to see some form of structured logging output. Even just writing out records to a CSV file with proper escaping would work great, or doing a json object per log record as a backup. JSON might be easier since libjansson is already in DPDK, and we could disable the json logging flag if libjansson was not present at compile time. > DTS uses some of the logs from testpmd to validate the results. I am not > sure what all logs are used. The old version of dts (the one with its own repository) is fairly tightly bound to testpmd's logging. > We need to choose how to log (printf or registered log entity) and be > > consistent. > > What do you think? > Registered log entries are much better in my opinion since they provide a more machine-friendly format and DTS has to parse testpmd output. --00000000000008b44905ecf7fdbb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Tue, Nov 8, 2022 at 9:37 AM Honnappa N= agarahalli <Honnappa.Nagarahalli@arm.com> wrote:
+ Lijuan, Owen, Juraj

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, November 8, 2022 7:02 AM
> To: Aman Singh <aman.deep.singh@intel.com>; Yuying Zhang
> <yuying= .zhang@intel.com>
> Cc: dav= id.marchand@redhat.com; dev@dpdk.org
> Subject: testpmd logging
>
> Hello,
>
> I see testpmd is doing log with EAL entity. Example:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0RTE_LOG(ERR, EAL, "The device: %s has b= een added!\n"
> We could also discuss the log level.
>
> Please can we work on replacing these logs?

<= /div>
If we want to revisit logging in testpmd, even though I know I= 9;m invoking a case of second system syndrome here, I would love to see som= e form of structured logging output. Even just writing out records to a CSV= file with proper escaping would work great, or doing a json object per log= record as a backup. JSON might be easier since libjansson is already in DP= DK, and we could disable the json logging flag if libjansson was not presen= t at compile time.=C2=A0
=C2=A0
DTS uses some of the logs from testpmd to validate the results. I am not su= re what all logs are used.
=C2=A0
The old versio= n of dts (the one with its own repository) is fairly tightly bound to testp= md's logging.=C2=A0

> We need to choose how to log (printf or registered log entity) and be<= br> > consistent.
> What do you think?

Registered log = entries are much better in my opinion since they provide a more machine-fri= endly format and DTS has to parse testpmd output.
--00000000000008b44905ecf7fdbb--