From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 87EDBA0350;
	Thu, 25 Jun 2020 16:52:37 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 316EB1BC24;
	Thu, 25 Jun 2020 16:52:36 +0200 (CEST)
Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com
 [209.85.222.176]) by dpdk.org (Postfix) with ESMTP id 4221BDE0
 for <dev@dpdk.org>; Thu, 25 Jun 2020 16:52:34 +0200 (CEST)
Received: by mail-qk1-f176.google.com with SMTP id e13so5521903qkg.5
 for <dev@dpdk.org>; Thu, 25 Jun 2020 07:52:34 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=vynny0Xdjm7e1ZPVWE3J1wIcjSCrf3XW5OueOoD3s7k=;
 b=XLi+pLFkRom5yEQ7fRJQSd3KV8VAwFCIeUGktDa4TCjMHGABZlPjLt5QipeQRI6TeQ
 MonTmTMhDjYgsau8Acc2+EEl8IfXpnqRn8pHbUUXttM/cPPnnssIcZ083u1lh5gBSgHd
 k/YG30h0dng1aVyVVFDFBLMXeGOtd8wZSJZWQ=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=vynny0Xdjm7e1ZPVWE3J1wIcjSCrf3XW5OueOoD3s7k=;
 b=f3IOO6tac4ZVGlFN4pIm0VuLb7TzqqJzDULP51tOr0oeiEdlP4PemBB0BwCa1EANI2
 fOaeZbBUZcs12r0lRO37EMogjTjc8d/WjF8Ba4wmsqW0OzCKwjQlUczLzfVgsuSCgPHZ
 S9neBVVvAsX0gMGJP+YdQMpHDMzx+42CI440p38pylgg04Wx0JOWn/J4plBfiLV4+S7S
 1/6zmpBvlrTYGyJwchnO3JwGu8XEZaZtmethfmtsR5TFxTghMbrLPgy4r6HZgu5S+bE8
 9ubQdLgEDTTHxgQqlgyhQJjauEj3sBKWMfzAW+Nth9+sfGYdMvV1eZiixq2yC3+N/Kwp
 ffLA==
X-Gm-Message-State: AOAM530e9AQ1X/e/1JV/vCPgHZ31KMdTGPyvqCzhA6oOBoAf9ixdC8T4
 TEZv2M1AZsnrfVIuB1WSGJtgZJxmpidHctTRk6l8Sw==
X-Google-Smtp-Source: ABdhPJwU43KjI2RPSx7Z1vlOJLxBrfu3xwqokrGNQuwNxmKSOeasBdD+wBUKkEdZ2ziQHY4wfOqLrcTJOonHmyln4B0=
X-Received: by 2002:a37:a204:: with SMTP id l4mr12261260qke.200.1593096753639; 
 Thu, 25 Jun 2020 07:52:33 -0700 (PDT)
MIME-Version: 1.0
References: <CAHx6DYBtSsZmAViVAmtPrA20J3J03YUYRs1D1RXxmqPUnP2rUA@mail.gmail.com>
 <2532193.hmao2X3YlT@thomas>
In-Reply-To: <2532193.hmao2X3YlT@thomas>
From: Owen Hilyard <ohilyard@iol.unh.edu>
Date: Thu, 25 Jun 2020 10:51:58 -0400
Message-ID: <CAHx6DYDhwfuuhEFH6Q76EuPvbQK3iTqo_Oz_Z4N+EOtg77=YvA@mail.gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, dts@dpdk.org, ferruh.yigit@intel.com, 
 arybchenko@solarflare.com, Olivier Matz <olivier.matz@6wind.com>, 
 david.marchand@redhat.com, ivan.malov@oktetlabs.ru, 
 bruce.richardson@intel.com, jerin.jacob@caviumnetworks.com, 
 Lincoln Lavoie <lylavoie@iol.unh.edu>, rasland@mellanox.com,
 j.hendergart@f5.com
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] Hardware Checksum Checks Offload Feature
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hello,

In regards to the outer layers, having grepped through the code for
"[\w_]+_GOOD|[\w_]+_BAD", I wasn't able to find the flags that I expected.
I expected something like PKT_RX_OUTER_IP_CKSUM_BAD and
PKT_RX_OUTER_IP_CKSUM_GOOD to show up since that seems to be the format for
flags to be printed, but there wasn't anything in the grep output related
to that. Am I missing something? I can do outer UDP fairly easily, but it
doesn't look like there is support for outer TCP and outer SCTP in TestPmd.
I will plan to add tests

> > I decided to separate out the test cases instead of doing it like the
> > other ones in that area of the test suite because I noticed that a NIC
> > doesn't necessarily need to support offloading all checksum types, and
> > if I wrote the tests in the same way as the other ones in the test, it
> > would fail everything if the first protocol wasn't supported,
>
> No, if it is not supported, the result must have a special value
"UNKNOWN".

To clarify my meaning there, I mean that the verify statements in the test
case will abort the test on the first failed statement, so I am splitting
the tests up so that I don't need to collect all of the errors and then
spit them all out at once. Also, as far as I can tell, unknown only occurs
when it is not possible to decode a layer. The NIC I am testing with
doesn't support offloading outer udp, and TestPmd gives me an error message
and then leaves the option set to software mode. When I send a packet
without any tunneling, then it gives me something like
"PKT_RX_OUTER_L4_CKSUM_UNKNOWN". Is this assessment incorrect?

>  I think you should describe all the protocols you want to test.

Could you please elaborate on this?

Thanks for your feedback