DPDK patches and discussions
 help / color / mirror / Atom feed
From: vijay mohan <vijay1054@gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, "Trahe, Fiona" <fiona.trahe@intel.com>,
	 Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] bus/pci: pcidev access from secondary process
Date: Mon, 30 Mar 2020 19:12:51 -0700	[thread overview]
Message-ID: <CAJ++VZMmB_5VuqrTeSTi0_iH808B4urnvSkCD5z42vMn+LPiZg@mail.gmail.com> (raw)
In-Reply-To: <2216574.9XhxPE3A7Q@xps>

Hi Thomas,
As long as pmd or application doesn't access
dev->mem_resource[i].addr, secondary process works with igb_uio.
But for pci devices like crypto_qat, pmd checks for
dev->mem_resource[i].addr and bails out if the address is null.

Root cause is, not initializing the mapped address in rte_pcidev when
device is exposed through igb_uio.

Thanks,
Vijay

On Mon, 30 Mar 2020 at 18:54, Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 06/03/2020 13:28, Ferruh Yigit:
> > On 3/6/2020 12:02 AM, Vijaya Mohan Guvva wrote:
> > > For pci devices presented through igb_uio, pcidev->mem_resource[] is
> > > not populated when the device is initialized for secondary process.
> > >
> > > Initialize pcidev->mem_resource[] with pci-bar mapped addresses.
> > >
> > > Signed-off-by: Vijaya Mohan Guvva <vijay1054@gmail.com>
> >
> > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Do you mean secondary process never worked with igb_uio?
> Or is there a specific case?
> What is the root cause?
> Should it be backported to stable?
>
>

  reply	other threads:[~2020-03-31  2:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-06  0:02 Vijaya Mohan Guvva
2020-03-06 12:28 ` Ferruh Yigit
2020-03-31  1:54   ` Thomas Monjalon
2020-03-31  2:12     ` vijay mohan [this message]
2020-03-31  9:11       ` Thomas Monjalon
2020-04-24 17:08 Vijaya Mohan Guvva
2020-04-25 20:28 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ++VZMmB_5VuqrTeSTi0_iH808B4urnvSkCD5z42vMn+LPiZg@mail.gmail.com \
    --to=vijay1054@gmail.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=fiona.trahe@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).