From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: Hemant Agrawal <hemant.agrawal@codeaurora.org>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org, Hemant Agrawal <hemant.agrawal@nxp.com>,
nipun.gupta@nxp.com, akhil.goyal@nxp.com
Subject: Re: [dpdk-dev] [RESEND v2 3/7] net/dpaa2: change into dynamic logging
Date: Fri, 23 Mar 2018 12:49:56 +0530 [thread overview]
Message-ID: <CAJ5mUsU+9UMLGWDG2zw6YjHp0p2+UVF8OLM1rsec3nkj=4Q6eA@mail.gmail.com> (raw)
In-Reply-To: <3c88da66-fb3b-e41c-471a-812f115c792f@codeaurora.org>
On Wed, Mar 21, 2018 at 12:01 PM, Hemant Agrawal
<hemant.agrawal@codeaurora.org> wrote:
> Hi Shreyansh,
>
> On 3/13/2018 11:14 AM, Shreyansh Jain wrote:
>>
>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>> ---
>> config/common_base | 5 -
>> config/defconfig_arm64-dpaa2-linuxapp-gcc | 9 -
>> doc/guides/nics/dpaa2.rst | 44 ++---
>> drivers/net/dpaa2/Makefile | 6 -
>> drivers/net/dpaa2/base/dpaa2_hw_dpni.c | 30 ++--
>> drivers/net/dpaa2/dpaa2_ethdev.c | 290
>> +++++++++++++++---------------
>> drivers/net/dpaa2/dpaa2_pmd_logs.h | 41 +++++
>> drivers/net/dpaa2/dpaa2_rxtx.c | 59 +++---
>> 8 files changed, 258 insertions(+), 226 deletions(-)
>> create mode 100644 drivers/net/dpaa2/dpaa2_pmd_logs.h
>>
>> diff --git a/config/common_base b/config/common_base
>> index ad03cf433..64bdfbb73 100644
>> --- a/config/common_base
>> +++ b/config/common_base
>> @@ -188,11 +188,6 @@ CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=y
>> # Compile burst-oriented NXP DPAA2 PMD driver
>> #
>> CONFIG_RTE_LIBRTE_DPAA2_PMD=n
>> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_INIT=n
>> -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER=n
>
> See the comment in PATCH 2/7 w.r.t usages of DEBUG_DRIVER macro.
>>
>> @@ -322,9 +322,9 @@ dpaa2_attach_bp_list(struct dpaa2_dev_priv *priv,
>> retcode = dpni_set_pools(dpni, CMD_PRI_LOW, priv->token,
>> &bpool_cfg);
>> if (retcode != 0) {
>> - PMD_INIT_LOG(ERR, "Error in attaching the buffer pool
>> list"
>> - " bpid = %d Error code = %d\n",
>> - bpool_cfg.pools[0].dpbp_id, retcode);
>> + DPAA2_PMD_ERR("Error configuring buffer pool on
>> interface."
>> + " bpid = %d error code = %d",
>> + bpool_cfg.pools[0].dpbp_id, retcode);
>
> Can you try to convert this and others into a single line message?
Actually, the main debug string is a single line itself. It is the
variables which are being printed that have been shifted to new line.
That way, a developer can easy search through the code using the error
context (ignoring the values printed).
Unfortunately, at this point the indentation is too much to have a
long string with 80 character limit restriction.
I will push a v3 with all other comments fixed. If you still have
second thoughts about this, I will quickly spin-up a v4.
-
Shreyansh
next prev parent reply other threads:[~2018-03-23 7:20 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 9:25 [dpdk-dev] [PATCH 0/7] Change DPAA2 to " Shreyansh Jain
2018-03-12 9:25 ` [dpdk-dev] [PATCH 1/7] bus/fslmc: change " Shreyansh Jain
2018-03-12 9:25 ` [dpdk-dev] [PATCH 2/7] mempool/dpaa2: " Shreyansh Jain
2018-03-12 9:25 ` [dpdk-dev] [PATCH 3/7] net/dpaa2: change into " Shreyansh Jain
2018-03-12 11:04 ` Ferruh Yigit
2018-03-12 12:01 ` Shreyansh Jain
2018-03-12 9:25 ` [dpdk-dev] [PATCH 4/7] event/dpaa2: change to " Shreyansh Jain
2018-03-12 9:25 ` [dpdk-dev] [PATCH 5/7] bus/fslmc: remove unused debug macros Shreyansh Jain
2018-03-12 9:25 ` [dpdk-dev] [PATCH 6/7] crypto/dpaa2_sec: fix incorrect debugging prints Shreyansh Jain
2018-03-12 9:25 ` [dpdk-dev] [PATCH 7/7] crypto/dpaa2_sec: change to dynamic logging Shreyansh Jain
2018-03-12 12:10 ` [dpdk-dev] [PATCH 0/7] Change DPAA2 " Hemant Agrawal
2018-03-12 12:37 ` Shreyansh Jain
2018-03-13 5:44 ` [dpdk-dev] [RESEND v2 " Shreyansh Jain
2018-03-13 5:44 ` [dpdk-dev] [RESEND v2 1/7] bus/fslmc: change " Shreyansh Jain
2018-03-21 6:24 ` Hemant Agrawal
2018-03-13 5:44 ` [dpdk-dev] [RESEND v2 2/7] mempool/dpaa2: " Shreyansh Jain
2018-03-21 6:27 ` Hemant Agrawal
2018-03-13 5:44 ` [dpdk-dev] [RESEND v2 3/7] net/dpaa2: change into " Shreyansh Jain
2018-03-21 6:31 ` Hemant Agrawal
2018-03-23 7:19 ` Shreyansh Jain [this message]
2018-03-13 5:44 ` [dpdk-dev] [RESEND v2 4/7] event/dpaa2: change to " Shreyansh Jain
2018-03-14 4:01 ` Nipun Gupta
2018-03-13 5:44 ` [dpdk-dev] [RESEND v2 5/7] bus/fslmc: remove unused debug macros Shreyansh Jain
2018-03-21 6:13 ` Hemant Agrawal
2018-03-13 5:44 ` [dpdk-dev] [RESEND v2 6/7] crypto/dpaa2_sec: fix incorrect debugging prints Shreyansh Jain
2018-03-21 6:12 ` Hemant Agrawal
2018-03-13 5:44 ` [dpdk-dev] [RESEND v2 7/7] crypto/dpaa2_sec: change to dynamic logging Shreyansh Jain
2018-03-21 6:18 ` Hemant Agrawal
2018-03-23 12:04 ` [dpdk-dev] [PATCH v3 0/7] Change DPAA2 " Shreyansh Jain
2018-03-23 12:04 ` [dpdk-dev] [PATCH v3 1/7] bus/fslmc: change " Shreyansh Jain
2018-03-23 12:04 ` [dpdk-dev] [PATCH v3 2/7] mempool/dpaa2: " Shreyansh Jain
2018-03-26 8:48 ` Hemant Agrawal
2018-03-23 12:04 ` [dpdk-dev] [PATCH v3 3/7] net/dpaa2: change into " Shreyansh Jain
2018-03-26 8:48 ` Hemant Agrawal
2018-03-29 15:26 ` Thomas Monjalon
2018-03-29 18:01 ` Shreyansh Jain
2018-03-23 12:04 ` [dpdk-dev] [PATCH v3 4/7] event/dpaa2: change to " Shreyansh Jain
2018-03-23 12:04 ` [dpdk-dev] [PATCH v3 5/7] bus/fslmc: remove unused debug macros Shreyansh Jain
2018-03-23 12:04 ` [dpdk-dev] [PATCH v3 6/7] crypto/dpaa2_sec: fix incorrect debugging prints Shreyansh Jain
2018-03-23 12:04 ` [dpdk-dev] [PATCH v3 7/7] crypto/dpaa2_sec: change to dynamic logging Shreyansh Jain
2018-04-02 14:05 ` [dpdk-dev] [PATCH v4 0/7] Change DPAA2 " Shreyansh Jain
2018-04-02 14:05 ` [dpdk-dev] [PATCH v4 1/7] bus/fslmc: change " Shreyansh Jain
2019-12-03 15:35 ` Ferruh Yigit
2018-04-02 14:05 ` [dpdk-dev] [PATCH v4 2/7] mempool/dpaa2: " Shreyansh Jain
2018-04-02 14:05 ` [dpdk-dev] [PATCH v4 3/7] net/dpaa2: change into " Shreyansh Jain
2018-04-02 14:05 ` [dpdk-dev] [PATCH v4 4/7] event/dpaa2: change to " Shreyansh Jain
2018-04-02 14:05 ` [dpdk-dev] [PATCH v4 5/7] bus/fslmc: remove unused debug macros Shreyansh Jain
2018-04-02 14:06 ` [dpdk-dev] [PATCH v4 6/7] crypto/dpaa2_sec: fix incorrect debugging prints Shreyansh Jain
2018-04-02 14:06 ` [dpdk-dev] [PATCH v4 7/7] crypto/dpaa2_sec: change to dynamic logging Shreyansh Jain
2018-04-02 22:03 ` [dpdk-dev] [PATCH v4 0/7] Change DPAA2 " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ5mUsU+9UMLGWDG2zw6YjHp0p2+UVF8OLM1rsec3nkj=4Q6eA@mail.gmail.com' \
--to=shreyansh.jain@nxp.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@codeaurora.org \
--cc=hemant.agrawal@nxp.com \
--cc=nipun.gupta@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).