From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0079.outbound.protection.outlook.com [104.47.1.79]) by dpdk.org (Postfix) with ESMTP id 6CE8B2C58 for ; Wed, 21 Mar 2018 10:28:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=jLmSghVTu7sIoSy8h+fuYCQeyOlGAJUHcaLt/gLhym4=; b=l6JsWQVK0XI7Qy/6++j/H8aAOVEJJF+wt0nMuD6qeQRboDvLeKRJOUxoNDg+nxN59LWC/3ekw2yREVH0/U4JfSHVpFq1LU39P99w1Wa4fkibVhuL5+W1xxmFhg+duFzqouvS85uRQc6LkmFJsgZ+S8S3aLrC+5WQReSl5/Z+LKM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; Received: from mail-wm0-f50.google.com (74.125.82.50) by DB6PR0402MB2773.eurprd04.prod.outlook.com (2603:10a6:4:96::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Wed, 21 Mar 2018 09:28:34 +0000 Received: by mail-wm0-f50.google.com with SMTP id x82so8446502wmg.1 for ; Wed, 21 Mar 2018 02:28:34 -0700 (PDT) X-Gm-Message-State: AElRT7HNJtM4R93TUfnb+FbnR39XMxD7AKsi4kkh4y9B2sfElBxJGjGZ VFMcrwUa0DkUmHYFtUj/yAqONZi525/x61UiCXQ= X-Google-Smtp-Source: AG47ELtXJkFAB0oxr9fWow2HCktSx1lXRLdAx2r2WN4fBYattU4uxD9cK8dfH3rcvs2YP0dJTjadMpzNgBrpXM4eCpg= X-Received: by 10.28.114.20 with SMTP id n20mr328647wmc.56.1521624512656; Wed, 21 Mar 2018 02:28:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.30.65 with HTTP; Wed, 21 Mar 2018 02:28:02 -0700 (PDT) In-Reply-To: <1521618694-140757-4-git-send-email-rosen.xu@intel.com> References: <1521618694-140757-1-git-send-email-rosen.xu@intel.com> <1521618694-140757-4-git-send-email-rosen.xu@intel.com> From: Shreyansh Jain Date: Wed, 21 Mar 2018 14:58:02 +0530 X-Gmail-Original-Message-ID: Message-ID: To: Rosen Xu Cc: dev@dpdk.org, declan.doherty@intel.com, Bruce Richardson , tianfei.zhang@intel.com, hao.wu@intel.com, gaetan.rivet@6wind.com Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [74.125.82.50] X-ClientProxiedBy: AM5P190CA0034.EURP190.PROD.OUTLOOK.COM (2603:10a6:206:14::47) To DB6PR0402MB2773.eurprd04.prod.outlook.com (2603:10a6:4:96::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 35c7e2eb-9e88-472d-f2b5-08d58f0e1eaf X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB6PR0402MB2773; X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2773; 3:8CVoZCi53CqyS4rswoveykx6R/2aj948OICj6qs5O8KKzKTkP7sWA25CVijz0yk0o60ZNrydKdZEOuiX/1IaIiWxF6CUApfK6XSgDtWgTMy9I/fpTnmljx1YCB87DWVImerzh9s/Tg55+n8xDhuXGss6RktK89VYnKAKfCG/eyXBkpqjNtpODm4ipPnZkThocuMRKmEjtDmajy0PDSF2yfGDZFQLmLDnS6m6olxUCHZlLBkkNjg3RaXjbORynsOL; 25:bviz1dIBSsI93Dz96zVKZaEtpPLA7LgZqVUXsZxIteR1bOaMB17tfa6yM3wEXOoxLfPkA33jLUS8gyl9kJQYGblqifLcEG5GtaJRO5Oj8TpAeetzGQZ3idx8+6ZuI6GfIXuLCmrSfy6jQRE6NrXEjeDWYUSsLk1ml56akahPXU//htyg+nYRb7DsDifaxFMpdxfyp8SYZuGWBYtVCv5ZPbIFd3Z72T8CedCNeNdTg+umI7diJPiXWRgyW0BPhrHiatHwT4EtNwmkfOvQS8EsdcFGQvmUzxOTTWhWizKhZTmq3eltSM5RX4DW0MBeRuk7w/qyHeF64V/bO4ZiMb5utw==; 31:Og+OBRR1SlUCe6z7YhQppchhrd9Mg5RM1IHH+YXzDzWmCLyeKXgiMQ3zGvVe0XdQf7b2tZ1y/Jt8m5LqMYO56Y/3PVEBooYfvCwSXWAeQzccluvW4NYp6H7zREOrqwIOVG3xgGvUJpZNi9nYimiWzATgnax8udGjkmeOoniUMr/QTipF9N4en6h8ED9QF2wOn9W50sLqqNGEfhrmKVHFNFArab6POX7/GkBxI2m5hYo= X-MS-TrafficTypeDiagnostic: DB6PR0402MB2773: X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2773; 20:m2D+WPxkMNRaLo5x4vN2Fi6kwFGY56783hdiblBELtiIpUwrgx0H9dPabjHJC34Jy36Ujjpx6fRmcdoqXq80/b+/u3F72GlFAOrvNzG9RAaPbffm7a/COK/2Dg5joUvW+0bW5ZeAy7Szy/uf7yuPq32smBx49CqBNPxajjSSgm6sq1f4XvLd0nFWapeiKanC868BMqG+d6C3xNofxef5WfHOEHR2lI1YVNJarTohyj3mshVFIgfCjytS27FX+lLpa6hilwcSl3IlPcqFs1G2pNhRvblsyoSB85BpyiVPYf0KO0b5BYwLnzeYWk5oSqt4Q5zNDa9cCPzQKijJEmf/tym63lSwe2Y6j+EmQ89c9Q4CPnRTeukmtKhU7mHs/0FRX9x89aY3OAIbkjQtcUhUw3dd4265XuKwEqWh8222FVeCL7po1UFjZbFcOR/bBfj76lHVjAkuCInvx/xDICXX4xoRQKv2mgX4gj/RKpk6oN1aZ9lqooZU+OtLNDa2l4Ek; 4:c0UwJMYh9eea0YRD4dx7ihtmFYEPV8qvUrfVwgC7f/jzS5jCIk6zNSzCPyEZr5xasd7NVEsBeyvSWcAPo6BOHPJJyxcjMHLoLtLf+LbK/KLGdPNBLg4kgjhp2q4lgy/2BY8yq1ZNnj4RQvpCqyeIxL9pv5UkUgOQQX+K7tao4KgQzUgKOgnHqzc3J17cWN4GMTHCF21yeor3ePKYbG3gX/EpMLBhbO9zFz1M4GezezUBzraz9Eo6na2jTODTuk5vKLCPvS9v+jrRSe2amC7LLAraVCUzyBtX82/Tg8sIdQ+LlHYbOy3UF/rAJF2EGXsX3kHjGveHsbHnyL46TFR3c158Z84yytgRdZGwsBaQGLc= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501321)(52105095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041310)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(6072148)(201708071742011); SRVR:DB6PR0402MB2773; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0402MB2773; X-Forefront-PRVS: 0618E4E7E1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(39860400002)(39380400002)(396003)(199004)(189003)(66066001)(42186006)(316002)(59450400001)(33896004)(6116002)(3846002)(50466002)(97736004)(55446002)(2906002)(16586007)(69596002)(23676004)(122856001)(106356001)(4326008)(6862004)(52116002)(105586002)(61726006)(93516011)(76176011)(95326003)(6306002)(229853002)(5820100001)(8676002)(966005)(9686003)(498394004)(53546011)(26005)(81166006)(81156014)(47776003)(61266001)(9896002)(53936002)(55236004)(86362001)(386003)(68736007)(5660300001)(2950100002)(6246003)(478600001)(7736002)(305945005)(186003)(107886003)(8936002)(217873001)(55456009); DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0402MB2773; H:mail-wm0-f50.google.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQUjA0MDJNQjI3NzM7MjM6QnhkcmVveklzemJIZmltOElIT0toZWpO?= =?utf-8?B?V3dackFpSDR6OVpzV1dPcEJIUEw5dkswSlZoVXpLQ0RONDlMemFwdm8yMXha?= =?utf-8?B?VkRhY1NWR1oyMHBXWjRRMDVpUHFwM29YMVNwdFJiT0lSQjRhWU9Id0ZjM3Zk?= =?utf-8?B?ekF3b08vWjQ5RTA5bVM1Ty9GYjF6ajJXeTExbk0yTTh0bVhTVnhrWnMwL1JY?= =?utf-8?B?ZDU5dlR5VjVCRkFQOGVteGVUTk1kYkNkS2ZUVnU0dkN3Z3dha25zT0RFRkJr?= =?utf-8?B?aTZTb2c0bnRBNlRNUUl3ajV6cVFxZW9tektnNFZlUGFGUms4STdNRnZXS0Zi?= =?utf-8?B?YnFUSVZGYncwc2hJdW9iblBySUJZa1A3eUZiakZ2Q1QwNml6eHA2bzNoOENy?= =?utf-8?B?THRIcVRDYm95eGQxb2dwZFFSRkFHeXp3b2NRWUY3NlFiZ1FodzNzTXJ2eWhW?= =?utf-8?B?U2FkZWdiMlo2bVJOa2lHdVBUaitWcmFvQUJGMEhiTDBnVmRZZENzM0RUOEZ6?= =?utf-8?B?MGJBa2dwVG5SaWRFVi9YVXFDUmZhakg1OVRsUDJ2ZXRqeGdsV2kyeDc3TEpq?= =?utf-8?B?MllVd0dyMUdLOVRxdHBDQ3cyUGxzQ25iZk4rWURValBaOXVsK3hTT1RIQmR3?= =?utf-8?B?VTI2c2V5TzZ0R3J5eHo5aEdaVlJ2OXVta3VtTE1QMGxHNjNYYnVUaWdNZ2Vp?= =?utf-8?B?VjBQVkI3RUF1QVlxVlZhTzlDcFBoakkvQUdra29IcmZRY2EyVW4wTFlrRjBN?= =?utf-8?B?VHozbkZVblpMSFhwRGozRlArWkZrUXN1bnBKMEFyNW54Z2tTUm9UK1FPbFBk?= =?utf-8?B?cHNseFR1ZXU5bWZlOXNxMmxtOWljblRFWGpoL251bDRiSnVZMXQwYlphbzll?= =?utf-8?B?WGlwVW4yU3BWK0RkZnRJeVVWbTZVdEU1eEdLY1dRMUFMWkYrMDlZV0wvcThD?= =?utf-8?B?M1pGcDdZb1d4eFJucHNkbDdRZWJLa0JOTDFtTTlaTGtoSTZTUDNPYU9lOFRj?= =?utf-8?B?VDF6N1hSRjRxK2llNloyYWRUNjZLaktvclJudjZrS1hGczgxSUV3S2VnRSts?= =?utf-8?B?QWt6R0dCQ3psVDFHVFdrN1RSUGFDdm9nVWNxMW8xVm9CT3hhQ0hqWVhoNFEv?= =?utf-8?B?K0xGOFpSb3hwcVFGc3hZVHVzMTZtVmdTaHdZWWVQcktpU2t1U2ZxaU83WFZF?= =?utf-8?B?RWV6RTc0ckF5MEFZWFFqSHh0YXRTUHhrV1NuVVlyUXF5elp1bXlKS21qOWxk?= =?utf-8?B?NWxoQjVySlI4STgzSVlCbm93czVCK2x0ZVVPMnc2L0JUc1FKSXBxRVViV2Rw?= =?utf-8?B?Qk1VQ3VUK1hoSmF6RmpmMTA0M3JjN1E1UjgzSkQ3b2FvWTNrR3o5QlpWMFYx?= =?utf-8?B?VS82M2lDbDROMDRTQUZ5aDRBdE5JVzdhZmF4ZXdEMnJDWXFoSGFpMEYzOTNj?= =?utf-8?B?ZS9XbmV1aVlhbG4xbTlMOUxlWnJLdVhNRlNFelc2YXo5VzdNQlJtbkkyL1M2?= =?utf-8?B?OXZ2cmFBV2ZzN2xoNnBLVUlEbEcrd2RKbEhKMnErRmp6UENLYnpTTVh5dGJ2?= =?utf-8?B?ZlJGd1ovS1RQbUYxUWg1NjhZOWV1NzVLUFY1MFNVWWRIdkR2VlRISXFiZWg3?= =?utf-8?B?ZGJENnpDWEVDUGJISFRqYm5UYVM3cldPSXlDMlVYYXlGWTlVVkFIVVNxa2t5?= =?utf-8?B?eUNuS2xWc3RoOVFLS1lGZWxGQkFhWmh1bjZIYUVvMUs2NVNiblNnMkx6cnFQ?= =?utf-8?B?aUN5aE1mdTFzeExRUkZTU0xoaDVMWHlQbThuODk1ejRhSWl2L244WVdOaWdG?= =?utf-8?B?TUpGNGVLaEM2cTl5Smh6WHMzem1ycjlVWnZFNlpxNU5EOHF2eXZTZkpQOWNk?= =?utf-8?B?U2ppZHhObWpCNHlJNDFtRmFuYkxFQlBjYkRNVDBlT0xITUxPMmp6ZkVqclJr?= =?utf-8?B?bHB5SnQvSE8rclE9PQ==?= X-Microsoft-Antispam-Message-Info: w70PA7az03YXTsiPu4I5zClTYVlyjUioEj1pG2Aw1KAgPMLciutOhEz2CfiEKUjGIcNiyCXOHSJ+axgz/9TerzflV2NA1q/EczIqzKlk5TxhZeqru7O9tPoQ0MWOxRdsnWfHRWtAVeoZ3IehshY0phftRYzgwf5IY74dPEE5WgbImEKMn5w2VOw7O9MmWD4T X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2773; 6:KP7sZs8yyy5ki934d4y3kh8BNvSB42hMYAXZebKUAZ3SXTClhj2RaBqjXgqzadt81b4iFpuYw8QWZdrA4fLVyI4OlZoKTdb7J5bsxy5D8HZGKS9361ZpLWwfMHVeCoG5Vqz39Hq7aamvw0M0qqbm6EfrCaNB5rAdWYJWv2BhVg64peLgBawX20xgaJQNlrhexVkYBA+1LI28ekNInIj1rahXMjPmS6j4mVxmy7/fPQYV3sEEXAvZ0GQIT4A32+/pJ20FCPevT4REs+ENm4sZTFhp3yE4/egRLWrvlACNqHkMfN9xtGkuj4EbVR81iiq0wJNGyBP+yyy+8IM2CqA0IAepuw++Z7VgRTfvaX7pDZE=; 5:GxrxRzMLwX9RMgG8aG5jh2koviBvYheQIB2kp0dgvKEfS85pvgPKh+NqmMUByBO8RUZvQbW9DYy6FLPzcRtku+1l2K3ySxK6s/dqAi7k4paIVgoubBODse2u3QgPSYatBtm6LoqBcQpS9iK/8JiP+Plk8ABmhirq/n9ZdMs3wAI=; 24:1y+OygtSiqni1a5JKmJVp3rM+5g6fOVGuXtdqZ2ErofEhTPCrPTSXTnH01z2BXhcuyuowXdAIJ3g2IWYc/GL0lp0vXpsPXeyiGZORLFDVyU=; 7:lGn0udDQoKt/iBFswrBitdx4fyUHQbPjSNYSXZgXDL4+MBBGhxVU6oI2hQDe+v+oibwpF05jAuE4v/lPzvqCLz8kCh+rnUR+YPpSY/zHPTxC31HhXgRfc01eJfhV1rLAPfjAdoCB9DjZO3tJA3RTRNQGEwdTrtTWcAEz9kAJMz3Iy6fvuz0/QLqI0rEGxEKxTYMnAhkb997n4GdDzUqN43RhiXR2If0rJs+QtAqeCmSipbg43Oc3UUuaWa3VLqsi SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2018 09:28:34.9954 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 35c7e2eb-9e88-472d-f2b5-08d58f0e1eaf X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2773 Subject: Re: [dpdk-dev] [PATCH V2 3/5] Add Intel FPGA BUS Lib Code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 09:28:36 -0000 Hello Rosen, inlined are some comments from a quick look... On Wed, Mar 21, 2018 at 1:21 PM, Rosen Xu wrote: > Signed-off-by: Rosen Xu > --- > drivers/bus/ifpga/Makefile | 64 ++++ > drivers/bus/ifpga/ifpga_bus.c | 573 ++++++++++++++++++++++++++++ > drivers/bus/ifpga/ifpga_common.c | 154 ++++++++ > drivers/bus/ifpga/ifpga_common.h | 25 ++ > drivers/bus/ifpga/ifpga_logs.h | 32 ++ > drivers/bus/ifpga/rte_bus_ifpga.h | 141 +++++++ > drivers/bus/ifpga/rte_bus_ifpga_version.map | 8 + > 7 files changed, 997 insertions(+) > create mode 100644 drivers/bus/ifpga/Makefile > create mode 100644 drivers/bus/ifpga/ifpga_bus.c > create mode 100644 drivers/bus/ifpga/ifpga_common.c > create mode 100644 drivers/bus/ifpga/ifpga_common.h > create mode 100644 drivers/bus/ifpga/ifpga_logs.h > create mode 100644 drivers/bus/ifpga/rte_bus_ifpga.h > create mode 100644 drivers/bus/ifpga/rte_bus_ifpga_version.map > > diff --git a/drivers/bus/ifpga/Makefile b/drivers/bus/ifpga/Makefile > new file mode 100644 > index 0000000..c71f186 > --- /dev/null > +++ b/drivers/bus/ifpga/Makefile > @@ -0,0 +1,64 @@ > +# BSD LICENSE > +# > +# Copyright(c) 2010-2017 Intel Corporation. All rights reserved. > +# All rights reserved. > +# > +# Redistribution and use in source and binary forms, with or without > +# modification, are permitted provided that the following conditions > +# are met: > +# > +# * Redistributions of source code must retain the above copyright > +# notice, this list of conditions and the following disclaimer. > +# * Redistributions in binary form must reproduce the above copyright > +# notice, this list of conditions and the following disclaimer in > +# the documentation and/or other materials provided with the > +# distribution. > +# * Neither the name of Intel Corporation nor the names of its > +# contributors may be used to endorse or promote products derived > +# from this software without specific prior written permission. > +# > +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > +# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. Did you get a chance to go through the comment in RFC? I think you should replace the boilerplate with SPDX tags. > + > +include $(RTE_SDK)/mk/rte.vars.mk > + > +# > +# library name > +# > +LIB = librte_bus_ifpga.a > +LIBABIVER := 1 > +EXPORT_MAP := rte_bus_ifpga_version.map > + > +ifeq ($(CONFIG_RTE_LIBRTE_DPAA2_DEBUG_INIT),y) I think there was a similar comment on RFC - "...DPAA2..." macro is a copy-paste error. > +CFLAGS += -O0 -g > +CFLAGS += "-Wno-error" > +else > +CFLAGS += -O3 > +CFLAGS += $(WERROR_FLAGS) > +endif > + > +CFLAGS += -I$(RTE_SDK)/drivers/bus/ifpga > +CFLAGS += -I$(RTE_SDK)/drivers/bus/pci > +CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linuxapp/eal > +CFLAGS += -I$(RTE_SDK)/lib/librte_eal/common > +#CFLAGS += -I$(RTE_SDK)/lib/librte_rawdev > +#LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring -lrte_rawdev If you don't need these lines, don't keep them. That is ok until RFC, but not in formal patch. > +LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring > +#LDLIBS += -lrte_ethdev > + > +VPATH += $(SRCDIR)/base > + > +SRCS-y += \ > + ifpga_bus.c \ > + ifpga_common.c > + > +include $(RTE_SDK)/mk/rte.lib.mk > diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c > new file mode 100644 > index 0000000..ff72b74 > --- /dev/null > +++ b/drivers/bus/ifpga/ifpga_bus.c > @@ -0,0 +1,573 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2010-2014 Intel Corporation. > + * Copyright 2013-2014 6WIND S.A. Are you sure of the above copyright? I think this is a new file. Maybe your internal HW routines can have old copyrights. Just a trivial comment, though. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > +#include > +#include > + > +#include "rte_rawdev.h" > +#include "rte_rawdev_pmd.h" > +#include "rte_bus_ifpga.h" > +#include "ifpga_logs.h" > +#include "ifpga_common.h" > + > +int ifpga_bus_logtype; > + > +/*register a ifpga bus based driver */ Comments have ' ' after the '/*'. Maybe you can refer [1] once. [1] https://dpdk.org/doc/guides/contributing/coding_style.html#coding-style > +void rte_ifpga_driver_register(struct rte_afu_driver *driver) > +{ > + RTE_VERIFY(driver); > + > + TAILQ_INSERT_TAIL(&rte_ifpga_bus.driver_list, driver, next); > +} > + [..snip..] > diff --git a/drivers/bus/ifpga/ifpga_logs.h b/drivers/bus/ifpga/ifpga_logs.h > new file mode 100644 > index 0000000..36b9b3f > --- /dev/null > +++ b/drivers/bus/ifpga/ifpga_logs.h > @@ -0,0 +1,32 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2010-2015 Intel Corporation. > + * Copyright 2013-2014 6WIND S.A. > + */ > + > +#ifndef _IFPGA_BUS_LOGS_H_ > +#define _IFPGA_BUS_LOGS_H_ Ideally this is name of the file, which is IFPFA_LOGS. But, technically this is not an issue. > + > +#include > + > +extern int ifpga_bus_logtype; > + > +#define IFPGA_LOG(level, fmt, args...) \ > + rte_log(RTE_LOG_ ## level, ifpga_bus_logtype, "%s(): " fmt "\n", \ > + __func__, ##args) > + > +#define IFPGA_BUS_LOG(level, fmt, args...) \ > + rte_log(RTE_LOG_ ## level, ifpga_bus_logtype, "%s(): " fmt "\n", \ > + __func__, ##args) > + I noticed that at some places where you have used the above macros, you have added '\n' in the call. It would lead to double '\n' as your IFPGA_LOG and IFPGA_BUS_LOG already have one '\n'. > +#define IFPGA_BUS_FUNC_TRACE() IFPGA_BUS_LOG(DEBUG, ">>") > + > +#define IFPGA_BUS_DEBUG(fmt, args...) \ > + IFPGA_BUS_LOG(DEBUG, fmt, ## args) > +#define IFPGA_BUS_INFO(fmt, args...) \ > + IFPGA_BUS_LOG(INFO, fmt, ## args) > +#define IFPGA_BUS_ERR(fmt, args...) \ > + IFPGA_BUS_LOG(ERR, fmt, ## args) > +#define IFPGA_BUS_WARN(fmt, args...) \ > + IFPGA_BUS_LOG(WARNING, fmt, ## args) > + > +#endif /* _IFPGA_BUS_LOGS_H_ */ [..snip..] > +#endif /* _RTE_BUS_IFPGA_H_ */ > diff --git a/drivers/bus/ifpga/rte_bus_ifpga_version.map b/drivers/bus/ifpga/rte_bus_ifpga_version.map > new file mode 100644 > index 0000000..e2aa7da > --- /dev/null > +++ b/drivers/bus/ifpga/rte_bus_ifpga_version.map > @@ -0,0 +1,8 @@ > +DPDK_17.11 { Should be DPDK 18.05 > + global: > + > + rte_ifpga_driver_register; > + rte_ifpga_driver_unregister; And indentation is incorrect. > + > + local: *; > +}; > -- > 1.8.3.1 >