From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Cc: dev@dpdk.org, stable@dpdk.org, Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH v1] bus/fslmc: fix find device start condition
Date: Fri, 23 Mar 2018 14:22:13 +0530 [thread overview]
Message-ID: <CAJ5mUsVfLvOh5SiRGa9TeM6OjcpKZ=91XQXp55NBRQmA2Pqf+Q@mail.gmail.com> (raw)
In-Reply-To: <20180322102844.8109-1-gaetan.rivet@6wind.com>
On Thu, Mar 22, 2018 at 3:58 PM, Gaetan Rivet <gaetan.rivet@6wind.com> wrote:
> If start is set and a device before it matches the data,
> this device is returned.
>
> Fixes: c7fe1eea8a74 ("bus: simplify finding starting point")
> Cc: stable@dpdk.org
>
> Cc: Hemant Agrawal <hemant.agrawal@nxp.com>
> Cc: Shreyansh Jain <shreyansh.jain@nxp.com>
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
>
> Hi Shreyansh, Hemant,
>
> Sorry, I did not test this.
> I found this issue while working on vdev and PCI.
>
> There is a better way to iterate on devices [1], but the gain
> is really minimal and the implementation slightly more complex.
> I preferred to avoid complex, as I could not test this patch.
>
> Regards,
>
> [1]: http://dpdk.org/ml/archives/dev/2018-March/092906.html
>
I think this change should suffice here. Thanks.
(On a side note, it seems compilation using clang is failing for this
patch [1] though it is not related to this change. I will look into
that)
[1] http://dpdk.org/ml/archives/test-report/2018-March/044684.html
Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
next prev parent reply other threads:[~2018-03-23 8:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 10:28 Gaetan Rivet
2018-03-23 8:52 ` Shreyansh Jain [this message]
2018-04-04 22:46 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ5mUsVfLvOh5SiRGa9TeM6OjcpKZ=91XQXp55NBRQmA2Pqf+Q@mail.gmail.com' \
--to=shreyansh.jain@nxp.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=hemant.agrawal@nxp.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).