From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00053.outbound.protection.outlook.com [40.107.0.53]) by dpdk.org (Postfix) with ESMTP id 8E327728E for ; Wed, 21 Mar 2018 10:08:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=mjRt21lZjVstbZWl/HVP3qZfgRA8b7NwGhKVnFSNfOM=; b=bFJj/UFd1bo/LczrZ/VV3pI20lla7Uz7lhDxcc6WOKFauNrOrqy2Qp2J6PWdYKDZg7xZHGz+wLRP6bpevbaGhwJ0WMoKJMZwDxLxfTnBVIWu8M/7teReDCrrbkQVljEXIVGgg2FLSG9ekN9O0PMvz0xAT3JZXbdw54BULXNRC9w= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; Received: from mail-wr0-f176.google.com (209.85.128.176) by HE1PR0402MB2780.eurprd04.prod.outlook.com (2603:10a6:3:d4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.588.14; Wed, 21 Mar 2018 09:08:29 +0000 Received: by mail-wr0-f176.google.com with SMTP id 80so3288917wrb.2 for ; Wed, 21 Mar 2018 02:08:29 -0700 (PDT) X-Gm-Message-State: AElRT7FYzpHIdNUpUb8EhTFDoJqtn8rSWUp2FjfdkPoUhgaNhGsPIXxJ bkYJM6eF7dkiX9CyhFU33Ub22We4a2QDf4UEM44= X-Google-Smtp-Source: AG47ELvtkE/V1cCU4JAWSx0ouORUZpDa3mz0B/PFch5+Rs/dvfIWCwGauQYGlyPSvod74/tocS3kyJtPaWA4R4bmkX0= X-Received: by 10.223.162.203 with SMTP id t11mr16523367wra.88.1521623305480; Wed, 21 Mar 2018 02:08:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.30.65 with HTTP; Wed, 21 Mar 2018 02:07:54 -0700 (PDT) In-Reply-To: <1521618694-140757-3-git-send-email-rosen.xu@intel.com> References: <1521618694-140757-1-git-send-email-rosen.xu@intel.com> <1521618694-140757-3-git-send-email-rosen.xu@intel.com> From: Shreyansh Jain Date: Wed, 21 Mar 2018 14:37:54 +0530 X-Gmail-Original-Message-ID: Message-ID: To: Rosen Xu Cc: dev@dpdk.org, declan.doherty@intel.com, Bruce Richardson , tianfei.zhang@intel.com, hao.wu@intel.com, gaetan.rivet@6wind.com Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [209.85.128.176] X-ClientProxiedBy: HE1PR05CA0127.eurprd05.prod.outlook.com (2603:10a6:7:28::14) To HE1PR0402MB2780.eurprd04.prod.outlook.com (2603:10a6:3:d4::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 4957c809-0fe3-4e96-5758-08d58f0b5003 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0402MB2780; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2780; 3:kng55ot66EIM5Ey3TpfROyZA56uI3ZYtR4xnGlhTCnOIN7hbIEd7VTX0bEGNzEJVGerobqDpunnanckmqs2BRr07FGwvHarJ0MfN9ub0KMPofAZEm2TVZ8v4EMOMikV0FNC0BYX3MZCaTr8Kf88Y22G25wCMVpwFewnCGKGM4y86kafbKHZWyXuvpRAg4h3atqopbkMpv8k+IYNmDUubz+2vAu9SIhacsMGbzR9uDQrdv97TtfjfphLCHClj7u6F; 25:QBXjTIxxLrWm3QNjKoIiwfXMQbJqOXRiUYLtxFINRq0odEfvLIDT+s+dcuEJ23/sWNd8vjJ4EPCsFXCW9zgTUV+ruHPJcXoVJfCt8t7VXoeDy+FPqqCoW8PIjJazsMO3iQdvOclZJcF6LVrdcezZW0UF9xvjzCV1w4DzazAbRkoA9Y8kzgop+g5H/I0MV6UgQ8F9ngqgkAnau30a6MCpXf6hntn3EyI7zX/WYETjX7/RnwPOKeolj5/88PSU/2BUvzX0+cxfRHT+zHrBFQXpjppeNS0U8n9GViNW760Y99D883U1ochvpikeTmQrkFCGR3SYA4Ix0qkZlJd/Eteppg==; 31:pNQ26NaLpJafNEiheZNCyZRf7qsQ8QQuuILAUP5ISsV2qhPBNLZCKnI76AvPqMbAPjZRAIY8nA6uNBVHBqS5m++p43jK1+vCD4V+ayC5UScLNaQrfH9bcRdcHI8sjge9A1uu0B7b1eVCQibRzju+gfNoE0eu4vdbL3tr1jirSIV8I+Yao0xlr/wktbYgtBSvaoZJdofP4TQtt+U2gZuIeKIAQA3Y3IUNjxOMIyARRaA= X-MS-TrafficTypeDiagnostic: HE1PR0402MB2780: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2780; 20:UvaTJqxDn2s7rgnI+SzFY43yspsdw1kDozsIslTzessKbU4Zc0LZaJNrgj1WSAVi7/8sguFITj1YxuAdL1Vp3/YeBjELJsnWCFrAQM1ZB5igMhKKMuNQdkSbRWtD9NDhYQAFCeieDyb37hWAPUmQFPn0Lg5Uc9L8dEzPJHZg945JIBFhJnJE+5ZXIUGkKoU2BDYqRqQ3lSnR6QIX9IqIKU+qkIFbgVp+SEIj3n6meVCN9xNNFv8o2Mgk5SBBinTLZmUmNtOpFP4dNn3qqCNQ614bLkWKmExM9QYO4V8sX1ZSKCd6zaOWdCArbMnJWAZr6oSgN6ZGuyBFuui9ClTYDYTDvAyunXU0HSpshfKYnEBiwJoZlyduawGHCzfA3IvsTui2Wz8jPu6iVDPwY05iShG5rM+vzatXwj+bQAS56gwpgUjKJkQpM+txEO9Nn2eQTmWdEmHmWbR5YaE4lTE+JA08Yye7UceFHil5dzEGQsl3z0WmVNwWwFW6wBMv5A95; 4:NuNJyeaqEMkNQIwo4QK9jn2HRgP2YoY0x+qVFNfucFpsbKU+zucky3wZ5W9JczMJXnZDhP0ayZCvAQbSj7WGhFfmlnFjsPR7Pb0v+Z6pXQqBe4o+Y9ZwwnshihSXIRHmca2nfX8kgIFh74q/DOWoQikYI3NmiMHyvCdYhx3yKppZruUnVBxx6NHazK9WtlZkiAc0ZgGzcVrPhUdzPvYQjgJm2pyBf0dYkLB+flt0Vq5lVvpBCApi385lueCkpWu2c2hz+Eu+YSMh7tE8M+7er6KKVR+vPOAF4mrIcAyBxcaxFXtqzHuMyK9HEKiPnqol X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231221)(944501244)(52105095)(93006095)(93001095)(3002001)(6055026)(6041310)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123564045)(6072148)(201708071742011); SRVR:HE1PR0402MB2780; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0402MB2780; X-Forefront-PRVS: 0618E4E7E1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(39380400002)(39860400002)(366004)(346002)(376002)(199004)(189003)(61726006)(69596002)(59536001)(61266001)(66066001)(47776003)(97736004)(5820100001)(478600001)(498394004)(386003)(2906002)(186003)(52116002)(16586007)(93516011)(26005)(33896004)(76176011)(23676004)(59450400001)(50466002)(3846002)(53546011)(6116002)(95326003)(81156014)(8676002)(86362001)(316002)(8936002)(9896002)(42186006)(53936002)(9686003)(107886003)(6246003)(68736007)(55446002)(81166006)(105586002)(106356001)(122856001)(4326008)(229853002)(7736002)(6862004)(2950100002)(305945005)(5660300001)(55456009)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0402MB2780; H:mail-wr0-f176.google.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA0MDJNQjI3ODA7MjM6eFk1Q2JDMmFEaGxiNkxZblZwa3VCNGlQ?= =?utf-8?B?YVJzb1MxM0FwL29NZW1WcENyN05WMnhONmkyM0Z1VWt1Z3ZSYStmaHN6dldn?= =?utf-8?B?OVF2Zm5ibFNqZko4Zk5xT25qazVZTXdKZlg0cXlqYjlVS0NGOWRrRVBJdVdN?= =?utf-8?B?aTNBbjVCTDFwM21ndEtINTV6YklJQ0dvNW91MkRqVXozWXUrcmdpb0tzY3pk?= =?utf-8?B?V2JPSHN5RXBsSk9wRkR0eUhGKytmTWRKb2puVjBDYUZET25jbWsrMng4Q1lI?= =?utf-8?B?dXlhRDdUK1pndWJGZ2VGN0hTUFRJczFlNDZIUnBrZ0xiNkpBWVNKZzd3bHdi?= =?utf-8?B?UTZWK0FXZnZkU2dBSklmZVlOZjZLWVhpdnY5L0FrM285Ny9rWGlKWXg5MGhY?= =?utf-8?B?NkEyeTVxcnh6eENHWlBuMVpDeXk2U2s2Nk1UY1l3L1lIS0I1Vlpsd0lYOXpa?= =?utf-8?B?YkpnT0xsNGQzdlhvWWk4SUFVcFdiYnU2UFFnSFNCZzRjTGRZV1IwSnd0OW9m?= =?utf-8?B?SFBZUHZVZ0JHQU5PVzRUenErZm9HMS83QzZFV1EwMnJSUUN5Y1Q0ZTVXaVdR?= =?utf-8?B?Z3hCc3hlTU1VQTJPRm9Gek1INzNyQStoOUh2Y3M3bDRLbzM5WGZQcUpxRFFO?= =?utf-8?B?N25JdUNRS3lSSjBtVGhHaVN3MlR0dVBuY0VSWkt0cXRMS1A1aVBmNklrYzRW?= =?utf-8?B?bW80cFZYOFhzVHRrbm41cTZ5Y1NaV0crejM1ZDdlTTBHN3VHUmZXdGxsc01C?= =?utf-8?B?clpiUVdpMFVoSUZ5NlplQzRkenRmeWhnODhSdW5tVnRXMEdUN3hCVWJFV2tr?= =?utf-8?B?algwanAyQUJrUHFtVUlOZXI0YlR6eU44NXZmMFB2cTVZZ20vZjFXY3RaM0dR?= =?utf-8?B?ZVEydW53SDk5WmpoK2crWVB2VVgvei9iSDVGcFJPc3V2dGNmakYyT0syYk5V?= =?utf-8?B?cjMzQ01JWW5NeDhrMmVLeFlzeEh6cWpZTy9wbWJqbzRaT0lFL2RzYTJjazRP?= =?utf-8?B?YWNiSk9ua0lrMEFWR29VU29ITzNINEJmNngzMytlaDhPOVVuRFBlNzVVczEw?= =?utf-8?B?QzBPQWgxN2RZM1RsNEk4bC9TcklHTG5UY3JnbGVzR0VDaUR5ODZBYlFjRm16?= =?utf-8?B?bGd1Rm5BSHRJeGY2MWFaZ3F6dnFsMUJyblpYZHRGYjIvWlJYNjZDU3ordHNY?= =?utf-8?B?ckxLalQvdHZDTWVVVlNHbWhYdkNFbUVEazJCMjdDVXhBQWdMK3JDOUtSTUhP?= =?utf-8?B?Y3BtWllHdVdCY0h1elRXb0s0QlJaR01BcU1SMHBxSjNiRTFGVFVlaWFSRkNQ?= =?utf-8?B?dDJTM1BFekxFM1QydE1IZXFORll3Umh2b2k5VGV6TGFLYmFDbEdDbjk0YUs0?= =?utf-8?B?cWx3S3VXRENKWSs2QU5zY2ovQnd6akZmM1pTQ1VJUW82NG5tUXE5ck82dGFX?= =?utf-8?B?bHhRSWpQWmhIcUZGczBTTUhiSzJjeE1MQ1ZrYUhLM2JYZGRSMWhLTkN6RkFI?= =?utf-8?B?czE3RHB2aUhBaUdNWlZ1WnoxN2FUU3UvYlZTWnhoMHhjMmNPYzNNeVJlaDFH?= =?utf-8?B?YlVrWVpCbmk5ZWRDbTErd09XajlqNnJ0SThtUkRSZjlHRUU5VmxGdUdBVXVE?= =?utf-8?B?djFndUpDVGp4V1FVTEd5MXRpZ1BLdTg3SVhnSSs5WnNhTEEvNWg3TWNFVjRJ?= =?utf-8?B?Y2Evak04WWp1OXNpbzdQVWwzTHBLWjJxMUVwUndMK28zbzJiN2V6STlaMzNF?= =?utf-8?B?bDYxSnNzWnhPaFlLVGdzcG94SEg3OXF1YmE0SzhTbG95N3pIVnlIY2kzVVNM?= =?utf-8?B?cWhGWlhKbTNRWlE2VHlWc01ySEZKaHZXREYzbDJsOWN5MlY4NXdtS1lhRVdP?= =?utf-8?Q?3IJfiuQhhsbYI=3D?= X-Microsoft-Antispam-Message-Info: TsAZ2eNLVbTSPLBuUyD0Un3g7ZfTGpkS3tri1f8XH3N208olXGPFraofMB1HdoCAuo+SWBuzFinxJwXCHgpS1Gq3ZRfHiZeYOE3QGeC/EvQDGxWouaKVwe9vAxNouH6OUwhGZ7WIyuTAKwm+PxGHomOEn8kc3iv2idy+B0Ksw4YUZEfqCW7uPY0SX1Gjt527 X-Microsoft-Exchange-Diagnostics: 1; HE1PR0402MB2780; 6:iGtWit+TwSEvdUkmzbJW7NbtjWSeuGh3pA3W3aykR3ikOxzBu8mm84/3tt7EaUbaJDGkVinxDPG4XIAgcZuI9n24VsX3luUY05iQRW8RhYqT2IPjStC44oqX2QrLvh+NxcFRXQ35wwhYDw/zMxX0DriyE3O6AETv+E41KAzmzT+uBJTvLFIj5mT9E2yQ4mo3+WZt0LjQMyg7SNRDyB0pH9LC2VOLQ7kaWZV4YpoWYdZSAmtyJsXC90GuJ4KANZJ35G0rpABpQt1iCMtl3Dc9AxZqRcE7C55mc4i3jFV7YVNtU1nvd9pJZ5SsHJaP4Lm3/NJtxYvZzCisHp5IFVQUYypBD/Z0kd3DznuZakj1TOQ=; 5:Z5Xy3dKWqCddiJZ6rEhxB1GmPP7kcQ8pBrh1h3ORj7zDxqHTVyRT2DFTEzNlJ3G3LOlo6iiP/qMBahGnlgTn3Nm5Aj331k7efTipvOMa/88DKXdPwgrKj9C81Zr9NXkcE2P/59noWuwSmJkcuHTFKTPKpt4EV08C0/ikmiXIisg=; 24:3VbhL5IuylEXGS1bhy5Y4paTKs1aB4zmGnXJKBMO+j/hhZsL0Y2ZfVL5tuX2XJOdGSEhwJowB/4F4h6AzuE2WNBm25qg9tbd888Uh8QKknY=; 7:ytvSAobd57SyZtgwRrQDM9H2I2Am1hQsVmKX13yuifxjSTR6wre4t2PEr5oqWrK82fxjWJvbat+otynPKZ5sWEaxosV7ZqB2oKD8jQCYmJmy6SwRlg2EB87cgms2Cqnnp8WhGOc0MaA+tvO3GVoTMfsli/S85R5X/UuS8/xhykbfIQK0WSjK0Ng6qORChAfw3pcnL1HYP5dNjgoJ8Z8OqiYlk0lrkRVm1OaO4hYR6LMfUqr+izm1lNi66hf6r3EC SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2018 09:08:29.2601 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4957c809-0fe3-4e96-5758-08d58f0b5003 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2780 Subject: Re: [dpdk-dev] [PATCH V2 2/5] Add Intel FPGA BUS Probe Code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 09:08:30 -0000 Hello Rosen, On Wed, Mar 21, 2018 at 1:21 PM, Rosen Xu wrote: > Signed-off-by: Rosen Xu > --- > lib/librte_eal/common/eal_common_bus.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c > index 3e022d5..e3bcebe 100644 > --- a/lib/librte_eal/common/eal_common_bus.c > +++ b/lib/librte_eal/common/eal_common_bus.c > @@ -87,7 +87,7 @@ struct rte_bus_list rte_bus_list = > rte_bus_probe(void) > { > int ret; > - struct rte_bus *bus, *vbus = NULL; > + struct rte_bus *bus, *vbus = NULL, *ifpga_bus = NULL; > > TAILQ_FOREACH(bus, &rte_bus_list, next) { > if (!strcmp(bus->name, "vdev")) { > @@ -95,6 +95,11 @@ struct rte_bus_list rte_bus_list = > continue; > } > > + if (!strcmp(bus->name, "ifpga")) { > + ifpga_bus = bus; > + continue; > + } > + > ret = bus->probe(); > if (ret) > RTE_LOG(ERR, EAL, "Bus (%s) probe failed.\n", > @@ -108,6 +113,13 @@ struct rte_bus_list rte_bus_list = > vbus->name); > } > > + if (ifpga_bus) { > + ret = ifpga_bus->probe(); > + if (ret) > + RTE_LOG(ERR, EAL, "Scan for (%s) bus failed.\n", > + ifpga_bus->name); > + } > + Just like my comment on RFC, I still think this is not the right thing to do. I understand you want a case where IFPGA bus gets probed only after PCI bus is probed. There can be multiple ways. Two of them which I can quickly list without much deliberation: 1. A framework which can 'defer probing' So, a bus can register for defer probe and its check_if_probe_available() function callback is called through rte_bus_probe() If it returns OK, its probe is called, else it is added to a defer list which is called once all first register buses are probed. 2. Modify the priority in RTE_REGISTER_BUS and make it as an argument or a new variant which can take an argument. It is not ok to change this function specifically for a bus is because this method is not scalable. Is there some specific reason you would like to stick to this approach? [...] - Shreyansh