From: Shreyansh Jain <shreyansh.jain@nxp.com>
To: Rosen Xu <rosen.xu@intel.com>
Cc: dev@dpdk.org, declan.doherty@intel.com, tianfei.zhang@intel.com
Subject: Re: [dpdk-dev] [RFC 4/4] drivers/raw/ifpga_rawdev: Rawdev for Intel FPGA Device, it's a PCI Driver of FPGA Device Manager
Date: Tue, 6 Mar 2018 12:51:33 +0530 [thread overview]
Message-ID: <CAJ5mUsWqgMJP4dw=WNyNQbpvUDKKyjDMc2zs=fDCsM8zjEmtWQ@mail.gmail.com> (raw)
In-Reply-To: <CAJ5mUsUigcvULWpnVVnAF_PfuTgTYW8Nzn8fjcJzPNcQZxJ0CQ@mail.gmail.com>
Just wanted to rephrase my wordings as they seem to be presenting
different meaning from what I was intending.
On Tue, Mar 6, 2018 at 12:18 PM, Shreyansh Jain <shreyansh.jain@nxp.com> wrote:
> On Tue, Mar 6, 2018 at 7:13 AM, Rosen Xu <rosen.xu@intel.com> wrote:
>> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
>> ---
>> drivers/raw/ifpga_rawdev/Makefile | 59 ++++
>> drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 343 +++++++++++++++++++++
>> drivers/raw/ifpga_rawdev/ifpga_rawdev.h | 109 +++++++
>> drivers/raw/ifpga_rawdev/ifpga_rawdev_example.c | 121 ++++++++
>
> When rawdev skeleton driver was integrated, Thomas raised this point
> of naming 'skeleton_rawdev' rather than just 'skeleton'.
Thomas questioned why not 'skeleton' and I stuck to 'skeleton_rawdev'.
Which, in hindsight, seems to me a bad decision on my part.
> So, rather than 'ifpga_rawdev' rather than 'ifpga'.
So, rather than 'ifpga_rawdev', why not use 'ifpga'.
> At that time I thought we could use <drivertype_driversubtype> as
> model. But, frankly, to me it seems a bad choice now. Extra '_rawdev'
> doesn't serve any purpose here.
>
> So, feel free to change your naming to a more appropriate
> "drivers/raw/ifpga/" or "drivers/raw/ifpga_sample" etc.
>
> Probably I too can change the skeleton_rawdev to skeleton.
[snip]
next prev parent reply other threads:[~2018-03-06 7:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 1:43 [dpdk-dev] [RFC 0/4] Intel FPGA Bus Rosen Xu
2018-03-06 1:43 ` [dpdk-dev] [RFC 1/4] drivers/bus/ifpga:Intel FPGA Bus Lib Code Rosen Xu
2018-03-06 6:09 ` Shreyansh Jain
2018-03-06 9:24 ` Xu, Rosen
2018-03-06 10:05 ` Gaëtan Rivet
2018-03-09 15:34 ` Xu, Rosen
2018-03-06 1:43 ` [dpdk-dev] [RFC 2/4] lib/librte_eal/common:Add Intel FPGA Bus Running Command Parse Code Rosen Xu
2018-03-06 1:43 ` [dpdk-dev] [RFC 3/4] lib/librte_eal/common: Add Intel FPGA Bus Second Scan, it should be scanned after PCI Bus Rosen Xu
2018-03-06 6:20 ` Shreyansh Jain
2018-03-06 10:42 ` Xu, Rosen
2018-03-06 10:46 ` Gaëtan Rivet
2018-03-06 11:36 ` Bruce Richardson
2018-03-06 11:59 ` Gaëtan Rivet
2018-03-15 1:17 ` Xu, Rosen
2018-03-15 1:29 ` Xu, Rosen
2018-03-06 1:43 ` [dpdk-dev] [RFC 4/4] drivers/raw/ifpga_rawdev: Rawdev for Intel FPGA Device, it's a PCI Driver of FPGA Device Manager Rosen Xu
2018-03-06 6:48 ` Shreyansh Jain
2018-03-06 7:21 ` Shreyansh Jain [this message]
2018-03-07 4:10 ` Zhang, Tianfei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ5mUsWqgMJP4dw=WNyNQbpvUDKKyjDMc2zs=fDCsM8zjEmtWQ@mail.gmail.com' \
--to=shreyansh.jain@nxp.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=rosen.xu@intel.com \
--cc=tianfei.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).