From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f178.google.com (mail-ig0-f178.google.com [209.85.213.178]) by dpdk.org (Postfix) with ESMTP id 55D1A2952 for ; Wed, 2 Mar 2016 22:30:10 +0100 (CET) Received: by mail-ig0-f178.google.com with SMTP id z8so4184792ige.0 for ; Wed, 02 Mar 2016 13:30:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=84ZeDA3PbgJIR92wpGsXvhY3XJfND8oAolhr4IBGH9Q=; b=FQGFq5cub+t2K3EDqlIzcnKUL5SMxC5ja5rFpzUWC3gbBq+8UzgnAZCyYoMh0xl9AX 0ApeBW1poDaX7Efl/viUBNiB0VflFqQLubzInMnTVqSt0ayNkZsNRp6XhLuedSGI9olt 6hbH6QAR1CwmU5myQbcE+OSthluvYMxrEsc+w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=84ZeDA3PbgJIR92wpGsXvhY3XJfND8oAolhr4IBGH9Q=; b=IwUY8BnSiTJdo9VHx22gtiHKmU7K4Z/bMlTTgVan5z0GSJkbQD7cY+zVn7n4kIOj98 RvrUvD9y9CNGLG8zLcLjaW4ll4nPlmbAWumj2dXFLg29tnjU8tz25UAAwbqx4Zc+x2Tc EmadY6Lbi9v3kT4bvx9acidH+5BLa9o95FMINaeEBzNiVy5h+2LBEdxpXoDEt8cW/5fR 4IUfLLxU6N5cLSfS0ElFOAtmrdRw6/c7pVlozMJai+K6y1PMpR1TGsnO84MFj3hQGf8t 1dunjN15scOwsTDm6d6nJukhS6vxr7pZiGcjP2bpU5CjBT4jUoWkUHfZ9knGXev1w03P 70JQ== X-Gm-Message-State: AD7BkJIhgN6g9XqC7F7nT/xE/PBdBCNwIQZn6WdHAvH2DYgKUkD00p9ZgFwlb1dykPvNGpiuoNDoqN5xrmu8lu1V MIME-Version: 1.0 X-Received: by 10.50.23.80 with SMTP id k16mr1432605igf.81.1456954209667; Wed, 02 Mar 2016 13:30:09 -0800 (PST) Received: by 10.36.104.7 with HTTP; Wed, 2 Mar 2016 13:30:09 -0800 (PST) In-Reply-To: <20160302082450.6f64cf8e@xeon-e3> References: <2110917.95LWFiBeeK@xps13> <20160302082450.6f64cf8e@xeon-e3> Date: Wed, 2 Mar 2016 13:30:09 -0800 Message-ID: From: Stephen Hurd To: Stephen Hemminger Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] New driver (large patch) question. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2016 21:30:10 -0000 The bulk of the patch is the hardware interface header file. With all the comments, it weighs in around 800k. If I strip the comments, it's around 300k. If I both strip all the comments and remove all the currently unused structures, I can get the entire patch down just below 300k, but that makes it much harder for someone to do further development. I'm willing to do that though if it's what's preferred. The other large file (560k) is just a bunch of extra debug output that makes it easier to debug issues. It's normally not compiled, so it sounds like it's not wanted either. I'll submit without comments in the hardware interface file and take it from there. On Wed, Mar 2, 2016 at 8:24 AM, Stephen Hemminger < stephen@networkplumber.org> wrote: > On Wed, 02 Mar 2016 11:21:26 +0100 > Thomas Monjalon wrote: > > > Hi, > > > > 2016-03-01 19:56, Stephen Hurd: > > > I submitted a new driver on Friday, and it was rejected for being over > 300k. > > > > > > The rejection email suggested contacing dev-owner@dpdk.org, which I > did on > > > Monday with no reply. > > > > > > What's the process to submit patches larger than the mailing list size > > > limit? > > > > A patch has two lives: > > 1/ it must be reviewed and accepted > > 2/ it will stay in the git history for future reference > > > > Those 2 periods require the patch to be well explained, with a > > reasonnable scope and a human readable size. > > The primary rule to think about is to introduce only one feature > > per patch. > > So the size should be naturally small and the mailing list don't need > > to accept greater sizes. > > > > To make it short, please split your driver in several introduction steps. > > > > Too many of the DPDK drivers are bloated. > Recall the venerable paraphrase of Pascal, "I made this so long because I > did not have time to make it shorter." > https://en.wikipedia.org/wiki/Wikipedia:Too_long;_didn%27t_read > > Linux went through similar stages. Many drivers ended up being rewritten > for brevity (e1000, skge, tg3). Vendor drivers seem to want to engage all > features > even if they have no value. > -- Stephen Hurd Principal Engineer - Software Development Broadcom Corporation 949-926-8039 stephen.hurd@broadcom.com