From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f176.google.com (mail-ig0-f176.google.com [209.85.213.176]) by dpdk.org (Postfix) with ESMTP id B67622BAC for ; Thu, 3 Mar 2016 20:41:00 +0100 (CET) Received: by mail-ig0-f176.google.com with SMTP id i18so2745056igh.1 for ; Thu, 03 Mar 2016 11:41:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=twpgh+PKpTtQ0JlyYXlGW57b/fcc1/MbThgXqKlK9Ko=; b=BZzc57dXPfzlvjOUQY8VcH04lH68q7XaAgPI/WyBgf12fkGPim69PYofmZSAvtFZEi E1R1Y3CqsKpe+2YQlds4M5UJUyHiWhrhP8JfcpX8tt975UmCWYYG4NkN6ejsc2gpTDLK aTtlM1DWzQofA9x1bDG4RCSbmceIY1ctcduYo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=twpgh+PKpTtQ0JlyYXlGW57b/fcc1/MbThgXqKlK9Ko=; b=Y2sE743opL2W9Ova2feF7nx0M4ZB1rohmHBRkJvxWEAdo4ZdmmC4as2gfDBWSLNbbR QkljhbR2dEnMVe1zAKWKc1y3gBdVJaKqO07g9j47LeKvXEwiXNwyFzXkisKM00C6CyQK TjHh2gkNbmcLxjfSIop95p2NbDd3CJ0tjXROR/wP8y5yDDJQh2xzML0NzwsE0prBB3XU oEHbZFnkrAZCg2v1cH3huw0bef7fQqk0QSiZpgbxUkxrw/EveO03NCN/R+GVX2wBEBWn MMwcb+qz81WeX0NTdYSnlUhNMR7bACmoYe1+XYlWWBzLrRmlGugaockWmW0hg3n86SxQ Vx0w== X-Gm-Message-State: AD7BkJIgvicuo1/BU30opaRpcD7img1UTfDffOTFrrPvC/IgTqu7L1d07UJFyBaInuo3k0oPH76Kt2uGHPmSRNFj MIME-Version: 1.0 X-Received: by 10.50.138.72 with SMTP id qo8mr806272igb.81.1457034060055; Thu, 03 Mar 2016 11:41:00 -0800 (PST) Received: by 10.36.104.7 with HTTP; Thu, 3 Mar 2016 11:40:59 -0800 (PST) In-Reply-To: <533710CFB86FA344BFBF2D6802E6028622F5BCE5@SHSMSX101.ccr.corp.intel.com> References: <1915798.D06pWLxedU@xps13> <3156888.xIWalfADA6@xps13> <533710CFB86FA344BFBF2D6802E6028622F5BCE5@SHSMSX101.ccr.corp.intel.com> Date: Thu, 3 Mar 2016 11:40:59 -0800 Message-ID: From: Stephen Hurd To: "Qiu, Michael" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" , Carl Tung , David Christensen Subject: Re: [dpdk-dev] New driver (large patch) question. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2016 19:41:01 -0000 Unfortunately no. On Wed, Mar 2, 2016 at 9:53 PM, Qiu, Michael wrote: > On 3/3/2016 7:11 AM, Stephen Hurd wrote: > > On Wed, Mar 2, 2016 at 2:15 PM, Thomas Monjalon < > thomas.monjalon@6wind.com> > > wrote: > > > >>> The comments in it are the only publicly available > >>> documentation on the hardware I'm aware of. > >> So you must keep the comments. > >> > > That's my goal, but the comments are well over the 300k limit. > > > > > >>> The driver itself doesn't have a lot of optional features in it, it's > the > >>> header file that's too big. > >> It is big because there are many different things. > >> You can split the file in different patches. > >> Examples: > >> - a patch for RSS will bring the hardware structures for RSS > >> - a patch for the stats will bring the hardware stats structures > >> etc > >> > > Should I split additional definitions/documentation that's not currently > > used in the driver as well? Or should it stay as only enough to document > > what the driver already does? > > > > The header file is expected to be publicly released in the future, so I > > tried to keep it as close to the original as possible. I'm not strongly > > attached to this approach, but it does make it easier to support future > > firmware releases. > > > > It's a fairly work-intensive project to deconstruct the existing driver > > into a series of small patches that work at each step, is this a hard > > requirement? (if so, I'd better get cracking) > > Does original header file has it's own commit log(like it in other > project)? If yes, it could make your life simpler. > > Thanks, > Michael > > PS: please answer inline > > Sorry, $work just switched us to GMail and I'm still learning the ropes. > > > > -- Stephen Hurd Principal Engineer - Software Development Broadcom Corporation 949-926-8039 stephen.hurd@broadcom.com