From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stephen.hurd@broadcom.com> Received: from mail-io0-f171.google.com (mail-io0-f171.google.com [209.85.223.171]) by dpdk.org (Postfix) with ESMTP id 969712C5A for <dev@dpdk.org>; Tue, 19 Apr 2016 22:51:33 +0200 (CEST) Received: by mail-io0-f171.google.com with SMTP id 2so32196346ioy.1 for <dev@dpdk.org>; Tue, 19 Apr 2016 13:51:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=b4862AvOvVtCGVjcZJmPk2ty9oAiYf5Kb9kL0CUp45c=; b=aTYHJGLXAzNM2RLnLr9cClf3QswAq1ch3CItpuFPLwJBHNc5KQTEedR994dew0LFLq B9PnivvvpQPdx8nP9Cmma+yyv468k33YSVAGoe7Vkwgi2MhDDM47kfbFs0SnZ5wyCk5j BdiltJD5WxC5VZPHoOYoCXieJi8WK4V3rtmng= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=b4862AvOvVtCGVjcZJmPk2ty9oAiYf5Kb9kL0CUp45c=; b=Gk9uMB5z/AUO7TlkA2kVLiQLXRRih+0WZ0EPjrBwOWW7v49GnNW92VDz6c+FgD4aGg LscfOVxRfZKi6RjSyClDkC5sHkebvyA/U3HazW9R5nhifsCSUZlBADww2jA+HY5QrrKQ F+uQJ9oq91GVspRQNRIHRPDfNFvqcGpPN8l64o+M4G3LkxI5GKt/FtnED3e0MAr5aQrO g0yxtBgCj5FflC6IYbEDo/1DToKV7RXqa0SBEjqgfeFSafwMsBJ7Y1XYcvenC7T5peBL UMEecBh0KzkDjCY4e/W7VV1b2A/WP4QqH7kMTCVH3/oTcsVTd+unPNHPMDNfDh5MJORN Gg4w== X-Gm-Message-State: AOPr4FXpcckWbexq91iG8pR1F4vUGdOAPYXefYTZsSXuUXGNhMZnq7sk4d/vPlPC6G4ji7orLpiunuMhBJgwaPKz MIME-Version: 1.0 X-Received: by 10.107.15.141 with SMTP id 13mr5917621iop.193.1461099092838; Tue, 19 Apr 2016 13:51:32 -0700 (PDT) Received: by 10.36.45.142 with HTTP; Tue, 19 Apr 2016 13:51:32 -0700 (PDT) In-Reply-To: <20160419141933.GC15456@bricha3-MOBL3> References: <1456978137-98097-1-git-send-email-stephen.hurd@broadcom.com> <1457125528-128877-4-git-send-email-stephen.hurd@broadcom.com> <20160419141933.GC15456@bricha3-MOBL3> Date: Tue, 19 Apr 2016 13:51:32 -0700 Message-ID: <CAJ9nmBZd2D1mi2va0St+vBt4_dSqPYN9qnxw6KUZx28=dXCF2Q@mail.gmail.com> From: Stephen Hurd <stephen.hurd@broadcom.com> To: Bruce Richardson <bruce.richardson@intel.com> Cc: dev@dpdk.org, Thomas Monjalon <thomas.monjalon@6wind.com> Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 19 Apr 2016 20:51:33 -0000 On Tue, Apr 19, 2016 at 7:19 AM, Bruce Richardson < bruce.richardson@intel.com> wrote: > On Fri, Mar 04, 2016 at 01:05:24PM -0800, Stephen Hurd wrote: > > New driver for Broadcom bnxt (NexXtreme C-series) devices. > > This seems a single huge commit. Can this be split up into separate commits > with self-contained changes in each one, e.g. a feature per commit, > starting > with basic init, then RX and TX etc. etc.? > I suppose it could, I'm not sure what the value of that approach would be though... it would just be a long process of copy/paste/commit/repeat. Internally, it was developed as a port/rewrite of another driver, so we don't actually have history without a large commit. Assuming each individual commit needs to be buildable, this will end up burning a lot of time, and I doubt each separate commit could be reasonably tested. -- Stephen Hurd