From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f171.google.com (mail-ig0-f171.google.com [209.85.213.171]) by dpdk.org (Postfix) with ESMTP id 839B1298F for ; Thu, 3 Mar 2016 00:10:52 +0100 (CET) Received: by mail-ig0-f171.google.com with SMTP id z8so5756667ige.0 for ; Wed, 02 Mar 2016 15:10:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=b5UhzZeUEzyyqBlPwQbewFcrml2W3FNLvdp9MsgCO80=; b=IqRwiWJ5CJPNzUQvN1fF5YcePgIFLdIzbSLlUio4N6hecTMKa7sZgsZ9MOXJo6I7Kb 51xdaOvw6/H80wrCPw5LZZ8+NZjhWEZ+ycmlWXDQl/jcKgEJKTgAC0l21Q8xW/zgw8Br JV9LIffjWlD7Za4lgfYMe2h9Ph7Xuxk2Q62FQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=b5UhzZeUEzyyqBlPwQbewFcrml2W3FNLvdp9MsgCO80=; b=Q1m7l5EdJMPXd7WPy7NtCuqaICEpdkVQOLKEZjd7lHgHiP/jAbJdEV+3Nr2DuO4TkQ xjPBmdnjdmrb13U0Mf0i98c21NU14Tz1aA3U2DculFyh/5VUItI3s1qVug8/gPzM7L6K xM+JQvduxwmbyMGD+apMzvRDVZ91kbPx/wINGjHCsZZBHMO4MTqDQm4GZMyHnWL3jbBj FjGiG8UWGju6G36TxqhVN6c0ZLC+b9WXOYqHePNIFH8ymG36Ca6OHjPiGPcC1oVmCGht 4z7zLVHHePdp5bgso8z6c8TUgH+Ig5ZbLwdFz4wD/VBrt4KifZFlTqaShVo170AgqrJB 3PYw== X-Gm-Message-State: AD7BkJLLh5wI2aZa5DILtNjbWOKBtOhPicRTdz+rQs2rJMtWY1l//uk8cW95zpNyy3iLeYLRqOrbXg2rFxhyBw9a MIME-Version: 1.0 X-Received: by 10.50.155.98 with SMTP id vv2mr2777679igb.54.1456960251786; Wed, 02 Mar 2016 15:10:51 -0800 (PST) Received: by 10.36.104.7 with HTTP; Wed, 2 Mar 2016 15:10:51 -0800 (PST) In-Reply-To: <3156888.xIWalfADA6@xps13> References: <1915798.D06pWLxedU@xps13> <3156888.xIWalfADA6@xps13> Date: Wed, 2 Mar 2016 15:10:51 -0800 Message-ID: From: Stephen Hurd To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org, David Christensen , Carl Tung Subject: Re: [dpdk-dev] New driver (large patch) question. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2016 23:10:52 -0000 On Wed, Mar 2, 2016 at 2:15 PM, Thomas Monjalon wrote: > > The comments in it are the only publicly available > > documentation on the hardware I'm aware of. > > So you must keep the comments. > That's my goal, but the comments are well over the 300k limit. > > The driver itself doesn't have a lot of optional features in it, it's the > > header file that's too big. > > It is big because there are many different things. > You can split the file in different patches. > Examples: > - a patch for RSS will bring the hardware structures for RSS > - a patch for the stats will bring the hardware stats structures > etc > Should I split additional definitions/documentation that's not currently used in the driver as well? Or should it stay as only enough to document what the driver already does? The header file is expected to be publicly released in the future, so I tried to keep it as close to the original as possible. I'm not strongly attached to this approach, but it does make it easier to support future firmware releases. It's a fairly work-intensive project to deconstruct the existing driver into a series of small patches that work at each step, is this a hard requirement? (if so, I'd better get cracking) PS: please answer inline > Sorry, $work just switched us to GMail and I'm still learning the ropes.