From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f169.google.com (mail-io0-f169.google.com [209.85.223.169]) by dpdk.org (Postfix) with ESMTP id E88972BD7 for ; Sat, 5 Mar 2016 00:58:06 +0100 (CET) Received: by mail-io0-f169.google.com with SMTP id m184so79141198iof.1 for ; Fri, 04 Mar 2016 15:58:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=Rodg3bOJzML3kld57OfqMV7U1GDqQ5gJVJx72hF0c5Q=; b=byLQeRly4OtPCVDDREyXsJe5K5+Uj9xSl+aYnr4qdQObmlotCQy+GrBHHn3ckfNfDQ xD1liO2L716Z+twZixUpRtfMAPCYk1Q3NTfKJRfNHDIW31tk6PaqbnrVDH+3bP0LkAQU n45LK7brOZted41QHRTZK/XGoLdGK2jB47Jjk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=Rodg3bOJzML3kld57OfqMV7U1GDqQ5gJVJx72hF0c5Q=; b=FhbOGeireHHe2JbwUUngPirt9MyuqFcJvKux3p0MTPmy4PbNLrHJzN0c1VhmM1EI7r KtWvEflw/TvNJDiYS2OWVi6Pdtxb3ehhZq/ha0tg2/eblxfHXh3iaCwAi2JzFLTKT40K yI/vmEwA6FER/BMxnuX5K9C7ofCXlaAVExqPCEOLMI+UakYKBlmvZriC0tpkkbPGkpGW AajiPx1EkE86NXpcrw6lHdiGTjaWTb936Chp4TMCMlQd1y81DL+Z7TQctEXrNdtSezT1 rxI8EqVamEdwHFNV8VyWpsoQqap0pSxPH1aB7mlkQhAgHNn/L5NQNV5onEw4psLKG2fa PPyA== X-Gm-Message-State: AD7BkJLC43Bxxc3y9rOCTiulNgLvh0Oll+0sFOUe2psgEvILuRk/HAXgH+cd9zaQ25zyb6TSNWel/ql8sbMXXnTV MIME-Version: 1.0 X-Received: by 10.107.131.206 with SMTP id n75mr10609868ioi.189.1457135886204; Fri, 04 Mar 2016 15:58:06 -0800 (PST) Received: by 10.36.104.7 with HTTP; Fri, 4 Mar 2016 15:58:06 -0800 (PST) In-Reply-To: <20160304150207.49d859f4@xeon-e3> References: <1457125528-128877-1-git-send-email-stephen.hurd@broadcom.com> <1457125528-128877-4-git-send-email-stephen.hurd@broadcom.com> <20160304150207.49d859f4@xeon-e3> Date: Fri, 4 Mar 2016 15:58:06 -0800 Message-ID: From: Stephen Hurd To: Stephen Hemminger Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2016 23:58:07 -0000 On Fri, Mar 4, 2016 at 3:02 PM, Stephen Hemminger < stephen@networkplumber.org> wrote: > > > New driver for Broadcom bnxt (NexXtreme C-series) devices.> > > Looks good, I just have a couple of functionality comments. > > 1. Driver does not appear to support Link State interrupt. Not a big > deal, but would be good to have. > Correct, it currently doesn't, but this is on The List of things to do. > 2. Driver does not support hotplug > I haven't looked into enabling this at all yet. > 3. Since driver does not support scattered receive, it should check > and error out on enable_scatter (ditto for other features in rxmode). > This will save pain in future when some application asks device to do > something it can not do. > Good catch, will do. 4. Does driver support SECONDARY process model, it appears secondary > device will reset hardware. > I don't actually know what this is, I'll look into it. 5. Driver does not supper per-receive queue data interrupts. > This is necessary for power-saving NAPI like code. > This is also on The List. As a somewhat-related process question, should I be submitting this as a growing patch series until the merge window opens up again, or should I submit further changes as new patches? I'm not really sure on this point, and have been holding off adding the header comment commits until I figured out the right answer.