From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f47.google.com (mail-it0-f47.google.com [209.85.214.47]) by dpdk.org (Postfix) with ESMTP id 94BF64A65 for ; Wed, 25 May 2016 22:59:01 +0200 (CEST) Received: by mail-it0-f47.google.com with SMTP id z123so35563693itg.0 for ; Wed, 25 May 2016 13:59:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=ns4y2vSDckWfiYqVF8f7JTzpnmHR7gqXuwv4k/YKUgI=; b=A3U6dCizPFSztgzPsiBCxT9MoLsW+qc84GtBppUosRR/Rei0hoRpAipS6kycI0Idwl NIRTGGluMEOo7PGaUJQ0HxuSvSZ3tFSZ53TAAJ2+BDwl+0IQ0yWNfUhQpaoVO3a57jWA v96L8Ob8crE+PcGbj4uxWhbxUvKUwkZmJIrRU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=ns4y2vSDckWfiYqVF8f7JTzpnmHR7gqXuwv4k/YKUgI=; b=N/Vd8O/gPZcunDsVURAoe2atZYly7FVCSDL6+SlT5Hz4rzeiZ1JtTCqWbW2Udc2E/m EL9YSF6Hbk/3NiRGio1TGz74ZDhzzg5vCZnKAlLLyvoZf56UJUMTBiS/EJPgRhYp5bxW 8UH2A7trxrRhFL/Js0Chf9idEMGHin4yD4VURDKwWdmXCjXPARq7RQzKSCO/Xp6ymAKn Zpkxx0ZOSLmCjc8re6RxNIKAlLh1fOKp87UE4/waG+KKY71bIHdnduyCNk6uf9oFQOL0 xninJ3ZVMdN+gEr2anOADHOk5uus/gL9cYrsk/T10suMT6EjaP73L4qiBaZ/N14xhD1z z/8g== X-Gm-Message-State: AOPr4FWZ5hs2oNj4uNayl25FMCNo8HDolvsdhHJHbVCvJSQHnYbgt6x6+0YojQvcq3KXlmc5oc0pbaS/CM7kC/h2 MIME-Version: 1.0 X-Received: by 10.36.88.129 with SMTP id f123mr24083509itb.7.1464209940736; Wed, 25 May 2016 13:59:00 -0700 (PDT) Received: by 10.36.45.142 with HTTP; Wed, 25 May 2016 13:59:00 -0700 (PDT) In-Reply-To: <20160525150216.GA12776@bricha3-MOBL3> References: <1463179589-82681-1-git-send-email-stephen.hurd@broadcom.com> <20160525150216.GA12776@bricha3-MOBL3> Date: Wed, 25 May 2016 13:59:00 -0700 Message-ID: From: Stephen Hurd To: Bruce Richardson Cc: dev@dpdk.org, Ajit Kumar Khaparde Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 01/40] bnxt: new driver for Broadcom NetXtreme-C devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2016 20:59:01 -0000 Bruce, is it better at this point to modify the existing patch that adds bnxt.rst or to create a follow-on patch? On Wed, May 25, 2016 at 8:02 AM, Bruce Richardson < bruce.richardson@intel.com> wrote: > On Fri, May 13, 2016 at 03:45:50PM -0700, Stephen Hurd wrote: > > Initial skeleton simply fails init. > > Add nic guide and tie into build system. > > > > Signed-off-by: Stephen Hurd > > --- > > MAINTAINERS | 5 ++ > > config/common_base | 5 ++ > > doc/guides/nics/bnxt.rst | 49 +++++++++++ > > drivers/net/Makefile | 1 + > > drivers/net/bnxt/Makefile | 63 ++++++++++++++ > > drivers/net/bnxt/bnxt_ethdev.c | 104 > ++++++++++++++++++++++++ > > drivers/net/bnxt/rte_pmd_bnxt_version.map | 4 + > > lib/librte_eal/common/include/rte_pci_dev_ids.h | 40 +++++++-- > > mk/rte.app.mk | 1 + > > 9 files changed, 267 insertions(+), 5 deletions(-) > > create mode 100644 doc/guides/nics/bnxt.rst > > create mode 100644 drivers/net/bnxt/Makefile > > create mode 100644 drivers/net/bnxt/bnxt_ethdev.c > > create mode 100644 drivers/net/bnxt/rte_pmd_bnxt_version.map > > > Great to see this patchset split up finer grained, and it getting compiled > from > the start. Thanks for the work. > > One error that gets flagged by the automated patch checks here is that, > although > you add in a new doc for the new driver in this patch, that document is not > included in the overall NIC guides document. > > /home/bruce/next-net/dpdk-next-net/doc/guides/nics/bnxt.rst:: WARNING: > document isn't included in any toctree > > Regards, > /Bruce > > -- Stephen Hurd Principal Engineer - Software Development Broadcom Corporation 949-926-8039 stephen.hurd@broadcom.com