From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen.hurd@broadcom.com>
Received: from mail-ig0-f178.google.com (mail-ig0-f178.google.com
 [209.85.213.178]) by dpdk.org (Postfix) with ESMTP id E9FFD2BE0
 for <dev@dpdk.org>; Thu, 26 May 2016 01:35:27 +0200 (CEST)
Received: by mail-ig0-f178.google.com with SMTP id bi2so81434193igb.0
 for <dev@dpdk.org>; Wed, 25 May 2016 16:35:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc; bh=mQMRDtVC4/NQ1hcJtnffbbOGOwNdKwP8+daSF1ohmew=;
 b=HRXHmXpiJb4KT2SKP+x7wwcHzTT2XXfQDed9q1sS0RrutIz29sHea560+wr3P912bH
 q4Uan08HRp5Hr0Tx6+PxvswQy1iWPtBA+SgOPLJkmO1sPiXx/dVNqJoznaeivqjkLLHb
 wR2ZDyG6tr5uzVFdV+nXySwODEshyXFZ3Qz8I=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc;
 bh=mQMRDtVC4/NQ1hcJtnffbbOGOwNdKwP8+daSF1ohmew=;
 b=i4OVNHw9Z1qDJSaQWkAE8w/6Ry9CuC3HxQYedxQhpk/ffDQIYZXCdXkVXC8ZZSXAcW
 nOFcnQrysCyFd21LVZ49x+7yRxO3K2Mz/8d7k+WCO8ZqpJ1wG7uLrbPERZWw2LVZJplV
 yIzXHHNU8Rk1gLUPefnbkSSX4xkrenYqXjYx7LURmy0XkWezxXIkOrY1CaiPIVJrf/NJ
 fCxc4Ny7dOhksAvOmQkIPrI1i5Px/sr8YY62mmBVbR/ooJ3C17m2mS3SsjfbfHN4deIn
 KzcWGCgaY4ihNAOii68aLXNjDxe0BUYdsE1huwOkv6NnGbzY1W2wzfsCeYEOCHzRLpm2
 HK5Q==
X-Gm-Message-State: ALyK8tIDFTpejpxEE7MH/zQHf7mrpldpPN1WkHE2Vx4+oeFLWEBrhqOgp8q+kxTygC6AjOp2JhpKHcisvxWyb/pJ
MIME-Version: 1.0
X-Received: by 10.50.114.135 with SMTP id jg7mr434558igb.53.1464219327237;
 Wed, 25 May 2016 16:35:27 -0700 (PDT)
Received: by 10.36.45.142 with HTTP; Wed, 25 May 2016 16:35:27 -0700 (PDT)
In-Reply-To: <20160525150514.GB12776@bricha3-MOBL3>
References: <CAJ9nmBYsstDhTCB4H1V5zGFD7ffTeXd=L+v+pdCjqB5KJ6AEvQ@mail.gmail.com>
 <1463179589-82681-1-git-send-email-stephen.hurd@broadcom.com>
 <1463179589-82681-2-git-send-email-stephen.hurd@broadcom.com>
 <20160525150514.GB12776@bricha3-MOBL3>
Date: Wed, 25 May 2016 16:35:27 -0700
Message-ID: <CAJ9nmBbOSnpLGmvrWprdEVDyUqjF_6inYS8gk-rQcadJJc6L4Q@mail.gmail.com>
From: Stephen Hurd <stephen.hurd@broadcom.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v2 02/40] bnxt: add HWRM init code
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 May 2016 23:35:28 -0000

On Wed, May 25, 2016 at 8:05 AM, Bruce Richardson <
bruce.richardson@intel.com> wrote:

>
> Checkpatch also highlights a few minor issues that might be worth
> addressing.
>
>   CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
>   #137: FILE: drivers/net/bnxt/bnxt.h:94:
>   +#define BNXT_FLAG_VF           (1<<1)
>                                   ^
>
>   WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
>   #259: FILE: drivers/net/bnxt/bnxt_ethdev.c:143:
>   +       /*
>   +       eth_dev->rx_pkt_burst = &bnxt_recv_pkts;
>
>   WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
>   #366: FILE: drivers/net/bnxt/bnxt_hwrm.c:56:
>   +       unsigned i;
>
>
What version of checkpatch.pl should we be using?  These were not found by
the one I had.

-- 
Stephen Hurd