From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f181.google.com (mail-io0-f181.google.com [209.85.223.181]) by dpdk.org (Postfix) with ESMTP id 4C4FB2C17 for ; Wed, 20 Apr 2016 23:32:19 +0200 (CEST) Received: by mail-io0-f181.google.com with SMTP id g185so66658158ioa.2 for ; Wed, 20 Apr 2016 14:32:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=WOG2JGhCAjlNIAFFnwpM5CBETPp8xi4Zp747Fsj9lYA=; b=Uj/Nn5wD2W4y1QwOrrPeNdcNa2dmAN3VoC2WAH3xbE2poIDHDJ47Bvl/N/2Uyzi2TF hpRHadWUWN5zuSrFC78h41EJlKI+7rd7uaB4YEpeq7nHIYcuq4KwJLlEfIt76AA3JYYX WRHlIeYC+g6UPOl67/dhxM3BOab+lCNL1Rt9o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=WOG2JGhCAjlNIAFFnwpM5CBETPp8xi4Zp747Fsj9lYA=; b=BAfteiw3IP7ErnS0EwlmDgs6CkVCw+HlTR8hFgY2NthqwfuIS1s6YXIJl8ts0SmVif N682kAVrYHAkoafPF2TePIxJeIvQZtT+tKEB1OlKEUmcNRabbp0BJfyLnCoVpGpnRQZi bVJCa4iWx+SGVPd5tJAD52Sobch9X/q4dYGfsg69Gj6QtaYk6jLIMaJLaN4rH/N5iZj1 /2qK9r/9RewAV3E2FfxHmPcaRx8ymaDUUDj1gD7hN49KTpcQc7GTdtzm1IToJsPEtm3f 8+ihfwIXo5/CuH1XJEfFCRFFrkLWjT1axS39P9dJ/sPa6Zg9yvsuJfPFuKAao7nlYfvv 3VUA== X-Gm-Message-State: AOPr4FX6DWJM28UYsMX6e7EMTdmvt3V1Rr90DlYE+vQTgmhW4ZluJF3PyVlKhnYSTOePZqE+hH8pvWYKKzVV+0av MIME-Version: 1.0 X-Received: by 10.107.146.65 with SMTP id u62mr12027606iod.189.1461187938421; Wed, 20 Apr 2016 14:32:18 -0700 (PDT) Received: by 10.36.45.142 with HTTP; Wed, 20 Apr 2016 14:32:18 -0700 (PDT) In-Reply-To: <20160420110107.GA11120@bricha3-MOBL3> References: <1456978137-98097-1-git-send-email-stephen.hurd@broadcom.com> <1457125528-128877-4-git-send-email-stephen.hurd@broadcom.com> <20160419141933.GC15456@bricha3-MOBL3> <20160420110107.GA11120@bricha3-MOBL3> Date: Wed, 20 Apr 2016 14:32:18 -0700 Message-ID: From: Stephen Hurd To: Bruce Richardson , Ajit Kumar Khaparde Cc: dev@dpdk.org, Thomas Monjalon Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 3/7] drivers/net/bnxt new driver for Broadcom bnxt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2016 21:32:19 -0000 > It's not for testing, more for code review and to help understand the code > [though > as you say, we do need to ensure that each commit doesn't actually break > the > build]. > Right now, the driver code goes in as a single commit - which makes it a > hard > enough task to review and see what is in there. One suggestion that > hopefully > wouldn't be too much work might be to split the code up into: basic device > init code, RX and TX functions, and then any additional features based on > top > of that [ideally one patch per added feature]. > The current driver doesn't have much beyond basic TX/RX, but we can give it a shot. "Too much work" is relative of course, but splitting it into self-contained easily understood chunks will absolutely be a lot of work. Adding Ajit who will also be working on this. Since he's coming up to speed on the driver code, this could be a good way for him to fully familiarize himself with it. -- Stephen Hurd