From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f172.google.com (mail-io0-f172.google.com [209.85.223.172]) by dpdk.org (Postfix) with ESMTP id B926329C7 for ; Wed, 2 Mar 2016 23:06:32 +0100 (CET) Received: by mail-io0-f172.google.com with SMTP id g203so7453380iof.2 for ; Wed, 02 Mar 2016 14:06:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=aowit+nKMaHJqWwiTWKE6AeFptKZVDFzuEDsBbVbbIE=; b=PIhbATlyyaL4pes1crz0+sm4jfetrL0E12TjgSn1ZHSznRPT7NEs03qNBSICOSUlBK 2LLZKk3DgnQS5ljc6gYu1TQEd6cwIFLX13Dtgbijte4FMCP+L/ebko8aQ1MhLY/E31EN X5KAvg1GrYOtLCFLnob9EJMTyGRk+V4S/N9YI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=aowit+nKMaHJqWwiTWKE6AeFptKZVDFzuEDsBbVbbIE=; b=Z7nqNXHMFu8HE3mVS7LqPQqQEpevTf/5eJeooHCx8wtc5jXnBBJyAqKlvvLICq9Oap YJI6cKarlVAH3voPhAEb5DJDZON8Bs24M4Sj8c3/Dw41GcTr/b7l0qeinLig9/Do1cjm Yq/+0ifwgSMaNSK7EZd4Mw4NG3GzKhPKlbf5gquebiWbkWzFf98IjEhvTB2YlkXVoOe8 xCiOxr7t7krx6Zx0AIt/aLNyGkWD2S9ncHPqLaoJ+kOCavBLgI0S+tj8PZv4bcDefztw VGohXSKPE5KYzLK7afzfuBKIi4slQiMlPdieQnBkShMlH8uJXVG5vv4VPjzFrRSCVeDZ +orQ== X-Gm-Message-State: AG10YOSb4x/hDgzhARLLSWfw8VrjOY651yow0R9Mn4Y27cPLQiut8l9HoX/DtAyMG7Km2FWxlCoOfNwCSiyRjppa MIME-Version: 1.0 X-Received: by 10.107.12.14 with SMTP id w14mr39360456ioi.8.1456956392141; Wed, 02 Mar 2016 14:06:32 -0800 (PST) Received: by 10.36.104.7 with HTTP; Wed, 2 Mar 2016 14:06:32 -0800 (PST) In-Reply-To: <1915798.D06pWLxedU@xps13> References: <20160302082450.6f64cf8e@xeon-e3> <1915798.D06pWLxedU@xps13> Date: Wed, 2 Mar 2016 14:06:32 -0800 Message-ID: From: Stephen Hurd To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] New driver (large patch) question. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2016 22:06:32 -0000 The issue is that the big header in question is the whole hardware/firmware interface definition. The comments in it are the only publicly available documentation on the hardware I'm aware of. The driver itself doesn't have a lot of optional features in it, it's the header file that's too big. On Wed, Mar 2, 2016 at 1:54 PM, Thomas Monjalon wrote: > 2016-03-02 13:30, Stephen Hurd: > > The bulk of the patch is the hardware interface header file. With all > the > > comments, it weighs in around 800k. If I strip the comments, it's around > > 300k. If I both strip all the comments and remove all the currently > unused > > structures, I can get the entire patch down just below 300k, but that > makes > > it much harder for someone to do further development. I'm willing to do > > that though if it's what's preferred. > > > > The other large file (560k) is just a bunch of extra debug output that > > makes it easier to debug issues. It's normally not compiled, so it > sounds > > like it's not wanted either. > > If the code is not needed, it's obviously better to not submit it :) > > > I'll submit without comments in the hardware interface file and take it > > from there. > > I don't think removing the comments is a good option. > Please try to split per-feature to make it readable. > You can check how fm10k was introduced as an example: > http://thread.gmane.org/gmane.comp.networking.dpdk.devel/13447 > or mlx5: > http://thread.gmane.org/gmane.comp.networking.dpdk.devel/26986 > -- Stephen Hurd Principal Engineer - Software Development Broadcom Corporation 949-926-8039 stephen.hurd@broadcom.com