From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ACE9DA0C46; Mon, 27 Sep 2021 17:03:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9B17B410EB; Mon, 27 Sep 2021 17:03:27 +0200 (CEST) Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by mails.dpdk.org (Postfix) with ESMTP id 4EBD6410DA for ; Mon, 27 Sep 2021 17:03:26 +0200 (CEST) Received: by mail-yb1-f174.google.com with SMTP id m132so4590605ybf.8 for ; Mon, 27 Sep 2021 08:03:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=otKFSD7HT5Vazz+ZMm4xsp5u6/JqtgAxAeR0a45Hup8=; b=D2w25B4Z0hSaQsL+I+j403Ij+sVYC3f5BK5g/c6R+sAXGctu3+DwCVC2XHz9MjBlIe b+M7Vr7+uRtpTqc2UwnWNafS9xkEpOrR2stNUcS9sBHO6PsGoAKFVWltQ6QW75TCrt2q rumW4k3C7dRRD8EDfU2pPCS0k5MlHP1x5VoGQbe7hY98nV4OhRXC7qXzRu/WYnL087Uu qKylg4CGD3+ECcyo6FVkH+aypWcxPRGVUd1FnxtEQNJY6mgTpaKkGyUj3k821Xho+7wp YEiBSWlrXhEsLJAjBiNzBH+jah5l7tPHYsSl2Fvj9vwhb46/hYT617ChB2Lnybe7Gt4M DNXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=otKFSD7HT5Vazz+ZMm4xsp5u6/JqtgAxAeR0a45Hup8=; b=1jNaIn0PHvtF0j6J7KKJsc/zXVuE5+4veDb+uOXiMa023p2RLv4bnQIFl7FnAP1oLg HKwDUZp1qyKz2scNPxERfxyIU2EWk+B+r1wDQk8muNC1HRikJkCZYyW2vxzxOzT1Ft1i O+dm1ZICyEejTmdZDmxcSSpvyxMBWBiQX6pxQnMAwi0Kf3tiFaezBIcW5Z3QPwM28OZQ HX6kvCtJ58hDMEQwBbyV1CtbOVRJ42MhUzMslymTenwUkaCxsVVfjXJ5QOWUaZjs9i4i gJL99cWZJdC6aqZ96gF3zfxaTZsqAGdrS2NGaG5ulM/VFCY6nZZRMsnqv9u1XY1CFut5 PecQ== X-Gm-Message-State: AOAM5330h0tV/tDGrvgLn2ZkCI4A4Z+CN+astWyBW7rqEaI1+ji9UX/X H42E1+QnP2P8OY5FK/rsIJDm2SnZhF2iXOLyWMw= X-Google-Smtp-Source: ABdhPJz9Hwio5g/ClV8AqXXKe6ujV0YnLYRPu/Rv0ilpjXeJArrESpw2wqEu/ccG5FKq28cgcRnEIss3QlvBCEbYlPI= X-Received: by 2002:a25:496:: with SMTP id 144mr325798ybe.522.1632755004628; Mon, 27 Sep 2021 08:03:24 -0700 (PDT) MIME-Version: 1.0 References: <20210902151100.140330-1-tchaikov@gmail.com> <20210908165131.133444-1-tchaikov@gmail.com> In-Reply-To: From: kefu chai Date: Mon, 27 Sep 2021 23:03:12 +0800 Message-ID: To: Bruce Richardson , Avi Kivity Cc: dev@dpdk.org, anatoly.burakov@intel.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4] build: add meson options of max_memseg_lists and atomic_mbuf_ref_counts X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 20, 2021 at 4:08 PM Bruce Richardson wrote: > > On Mon, Sep 20, 2021 at 03:51:06PM +0800, kefu chai wrote: > > hello Bruce, > > > > do you have any further concerns? is there anything i can do to move > > this forward? > > > > cheers, > > > > +Anatoly, for his input for the memory segments change. > > I still would prefer not to have these as config options, but perhaps one > or both needs to be. The atomic refcount seems more reasonable to add of > the two. For the max memseg lists, what is the impact if we were to > increase this value globally? hi Bruce, thank you for your insights. yeah, as i explained in the previous email.the atomic refcount is more critical for my work on integration of DPDK+SPDK+Seastar. since Seastar enforces share-nothing in its design, there is no need to use atomic refcount under almost all circumstances. regarding to the max memseg list, what i am trying is to port the change of https://github.com/scylladb/seastar/commit/716c7c04db693c266f52de6b0cced0252d70b3bf to the DPDK used by the latest release of SPDK. i am copying Avi also for his input. he is the author of the change above. cheers, > > /Bruce > > > On Thu, Sep 9, 2021 at 12:51 AM Kefu Chai wrote: > > > > > > RTE_MAX_MEMSEG_LISTS = 128 is not enough for high-memory machines, in our > > > case, we need to increase it to 8192. so add an option so user can > > > override it. RTE_MBUF_REFCNT_ATOMIC = 0 is not necessary for applications > > > like Seastar, where it's safe to assume that the mbuf refcnt is only > > > updated by a single core only. > > > > > > --- > > > > > > v4: > > > > > > fix the coding style issue by reduce the line length to under 75. > > > this change should silence the warning like: > > > > > > WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) > > > #81: > > > RTE_MAX_MEMSEG_LISTS = 128 is not enough for high-memory machines, in our case, > > > > > > total: 0 errors, 1 warnings, 35 lines checked > > > > > > Signed-off-by: Kefu Chai > > > --- > > > config/meson.build | 5 ++++- > > > config/rte_config.h | 2 -- > > > meson_options.txt | 4 ++++ > > > 3 files changed, 8 insertions(+), 3 deletions(-) > > > > > -- Regards Kefu Chai