[dpdk-dev] [PATCH] contigmem: include <sys/vmmeter.h> to fix FreeBSD build

[dpdk-dev] [PATCH] contigmem: include <sys/vmmeter.h> to fix FreeBSD build

[kefu chai]

otherwise the build fails with

In file included from contigmem.c:57:
/usr/srcs/head/src/sys/vm/vm_phys.h:122:10: error: use of undeclared
identifier 'vm_cnt'
        return (vm_cnt.v_free_count += adj);
                ^
1 error generated.
*** Error code 1

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
---
 lib/librte_eal/bsdapp/contigmem/contigmem.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_eal/bsdapp/contigmem/contigmem.c
b/lib/librte_eal/bsdapp/contigmem/contigmem.c
index e8fb9087d..9676d8b35 100644
--- a/lib/librte_eal/bsdapp/contigmem/contigmem.c
+++ b/lib/librte_eal/bsdapp/contigmem/contigmem.c
@@ -45,6 +45,7 @@ __FBSDID("$FreeBSD$");
 #include <sys/rwlock.h>
 #include <sys/systm.h>
 #include <sys/sysctl.h>
+#include <sys/vmmeter.h>

 #include <machine/bus.h>

--
2.15.0

Re: [dpdk-dev] [PATCH] contigmem: include <sys/vmmeter.h> to fix FreeBSD build

[Bruce Richardson]

On Thu, Nov 30, 2017 at 02:00:38PM +0800, kefu chai wrote:
> otherwise the build fails with
> 
> In file included from contigmem.c:57:
> /usr/srcs/head/src/sys/vm/vm_phys.h:122:10: error: use of undeclared
> identifier 'vm_cnt'
>         return (vm_cnt.v_free_count += adj);
>                 ^
> 1 error generated.
> *** Error code 1
> 
> Signed-off-by: Kefu Chai <tchaikov@gmail.com>
> ---

Hi,

what version of FreeBSD does this error occur on? Though it's been a few
weeks since I last tested, I haven't seen it before on other FreeBSD 10
or 11.

Regards,
/Bruce

Re: [dpdk-dev] [PATCH] contigmem: include <sys/vmmeter.h> to fix FreeBSD build

[kefu chai]

+ Willem, he reported this issue

On Thu, Nov 30, 2017 at 5:56 PM, Bruce Richardson
<bruce.richardson@intel.com> wrote:
> On Thu, Nov 30, 2017 at 02:00:38PM +0800, kefu chai wrote:
>> otherwise the build fails with
>>
>> In file included from contigmem.c:57:
>> /usr/srcs/head/src/sys/vm/vm_phys.h:122:10: error: use of undeclared
>> identifier 'vm_cnt'
>>         return (vm_cnt.v_free_count += adj);
>>                 ^
>> 1 error generated.
>> *** Error code 1
>>
>> Signed-off-by: Kefu Chai <tchaikov@gmail.com>
>> ---
>
> Hi,
>
> what version of FreeBSD does this error occur on? Though it's been a few
> weeks since I last tested, I haven't seen it before on other FreeBSD 10
> or 11.

Bruce,

wjw@cephdev:~ % uname -a
FreeBSD cephdev.digiware.nl 12.0-CURRENT FreeBSD 12.0-CURRENT #15
r324142M: Sun Oct  1 08:19:29 CEST 2017
root@cephdev.digiware.nl:/usr/obj/usr/srcs/head/src/sys/GENERIC-NODEBUG
 amd64

>
> Regards,
> /Bruce



-- 
Regards
Kefu Chai

Re: [dpdk-dev] [PATCH] contigmem: include <sys/vmmeter.h> to fix FreeBSD build

[Bruce Richardson]

On Thu, Nov 30, 2017 at 02:00:38PM +0800, kefu chai wrote:
> otherwise the build fails with
> 
> In file included from contigmem.c:57:
> /usr/srcs/head/src/sys/vm/vm_phys.h:122:10: error: use of undeclared
> identifier 'vm_cnt'
>         return (vm_cnt.v_free_count += adj);
>                 ^
> 1 error generated.
> *** Error code 1
> 
> Signed-off-by: Kefu Chai <tchaikov@gmail.com>
> ---

The commit log could do with being updated to note that the error occurs
with, currently unreleased, FreeBSD 12  Otherwise:

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

[dpdk-dev] [PATCH] contigmem: include <sys/vmmeter.h> to fix FreeBSD build

[kefu chai]

otherwise the build fails with FreeBSD 12, like

In file included from contigmem.c:57:
/usr/srcs/head/src/sys/vm/vm_phys.h:122:10: error: use of undeclared
identifier 'vm_cnt'
        return (vm_cnt.v_free_count += adj);
                ^
1 error generated.
*** Error code 1

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
---
 lib/librte_eal/bsdapp/contigmem/contigmem.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_eal/bsdapp/contigmem/contigmem.c
b/lib/librte_eal/bsdapp/contigmem/contigmem.c
index e8fb9087d..9676d8b35 100644
--- a/lib/librte_eal/bsdapp/contigmem/contigmem.c
+++ b/lib/librte_eal/bsdapp/contigmem/contigmem.c
@@ -45,6 +45,7 @@ __FBSDID("$FreeBSD$");
 #include <sys/rwlock.h>
 #include <sys/systm.h>
 #include <sys/sysctl.h>
+#include <sys/vmmeter.h>

 #include <machine/bus.h>

--
2.15.0

Re: [dpdk-dev] [PATCH] contigmem: include <sys/vmmeter.h> to fix FreeBSD build

[Bruce Richardson]

On Fri, Dec 01, 2017 at 07:22:39PM +0800, kefu chai wrote:
> otherwise the build fails with FreeBSD 12, like
> 
> In file included from contigmem.c:57:
> /usr/srcs/head/src/sys/vm/vm_phys.h:122:10: error: use of undeclared
> identifier 'vm_cnt'
>         return (vm_cnt.v_free_count += adj);
>                 ^
> 1 error generated.
> *** Error code 1
> 
> Signed-off-by: Kefu Chai <tchaikov@gmail.com>
> ---
As before:

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

NOTE: for minor changes to patches, feel free to include an acked-by tag
on the patch submission if the previous version had already been acked.
Also, it's good practice to have updated versions marked with a V2
number and posted in reply to the original submission. See dev page on
dpdk.org for more details. http://dpdk.org/dev/

Re: [dpdk-dev] [PATCH] contigmem: include <sys/vmmeter.h> to fix FreeBSD build

[Thomas Monjalon]

01/12/2017 14:20, Bruce Richardson:
> On Fri, Dec 01, 2017 at 07:22:39PM +0800, kefu chai wrote:
> > otherwise the build fails with FreeBSD 12, like
> > 
> > In file included from contigmem.c:57:
> > /usr/srcs/head/src/sys/vm/vm_phys.h:122:10: error: use of undeclared
> > identifier 'vm_cnt'
> >         return (vm_cnt.v_free_count += adj);
> >                 ^
> > 1 error generated.
> > *** Error code 1
> > 
> > Signed-off-by: Kefu Chai <tchaikov@gmail.com>
> > ---
> As before:
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks