From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C8A7A04E7; Sun, 1 Nov 2020 19:12:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3F9422C2A; Sun, 1 Nov 2020 19:11:41 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id E42E92BFE for ; Sun, 1 Nov 2020 19:11:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604254298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hPIHJWMf6JR4W89I39FfA918Tjq3IPOwfuGi105SZhg=; b=bpaMor9Ho4Y5IvpcRs0wkQrZ7oe9eIx3OMjJjr0nOOCclVhdYwWE3TCtbFIaF4BZKcvjdo M/lj7ZsMQvMo+LyVp2WG36dLCS+ueNP59QThhr9jzpzpIX9cINBEFwkGBN5JO01qqI4VyK 0fr0uAgpPvL2gL4gxN2ccC7GbF+Rslw= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-333-Hfft9-WtMIaAGwXVNY8IMg-1; Sun, 01 Nov 2020 13:11:37 -0500 X-MC-Unique: Hfft9-WtMIaAGwXVNY8IMg-1 Received: by mail-vs1-f72.google.com with SMTP id n126so3926560vsn.22 for ; Sun, 01 Nov 2020 10:11:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=hPIHJWMf6JR4W89I39FfA918Tjq3IPOwfuGi105SZhg=; b=jOTNvXveRIIHCXoyroYO5I9NTJE1JU0tpOybXGG/1XUNSQ8XWJ/5DKnLRLBEj071Zu uKUpuiOnPLGsbZKO+YSglFMQpszgafSCpMoGlYSkzZkRUCz17dZu1RhWPpmkV14HjeU0 bbWd/Y6YgcZ9jBfhkxS7U9ajBSyb1kUOFQZjRs80UOfQg6iMUCFhQwD2gziHeCNgbuRo qi9DjnwWj/M4c0ia/lZcpmYGiOgP4DL0RkVw/wzECHg5TG3X1Zk/Thjj+KyIVMPLAoe+ jW2+ZVwC579KLPtPZLcAMZmC+vm9sI4xcCkiLxcpRce6mu5XRQN8pmJI6y8ru4jJS9v5 Lzcg== X-Gm-Message-State: AOAM532p1eyq5np9Ju060naHA1BQseY08J2YtLX5piH3Fn2Gpb/Upgw8 VYHDMfquvvPla7C5L4zvUc/LLzejTmpWL4DimCV1EgrXTFNbsj57DLX6seuJVpqmadPqhTRGmq1 mtTDN77Affd/079npqts= X-Received: by 2002:a1f:1889:: with SMTP id 131mr11246538vky.20.1604254296517; Sun, 01 Nov 2020 10:11:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJw1YXQ71QaAKlYbJs0ogy7Z0xtzN3Q5hpxJ1fhyJ7xV0CZfeWuTTW40MjVxb7nMd0iI8IbU7ZQAQ/gE7ieQm/s= X-Received: by 2002:a1f:1889:: with SMTP id 131mr11246531vky.20.1604254296271; Sun, 01 Nov 2020 10:11:36 -0800 (PST) MIME-Version: 1.0 References: <20200612212434.6852-2-timothy.mcdaniel@intel.com> <1604168282-30079-1-git-send-email-timothy.mcdaniel@intel.com> <1604168282-30079-6-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: From: David Marchand Date: Sun, 1 Nov 2020 19:11:25 +0100 Message-ID: To: "McDaniel, Timothy" Cc: dev , "Carrillo, Erik G" , "Eads, Gage" , "Van Haaren, Harry" , Jerin Jacob Kollanukkaran , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v14 05/23] event/dlb: add inline functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Nov 1, 2020 at 7:07 PM McDaniel, Timothy wrote: > > Availability of the MOVDIR64B instruction is indicated by the presence > > of the CPUID feature flag MOVDIR64B (bit 28 of the ECX register in > > leaf 07H, see =E2=80=9CCPUID=E2=80=94CPU Identification=E2=80=9D in the= Intel=C2=AE 64 and IA-32 > > Architectures Software Developer=E2=80=99s Manual, Volume 2A). > > > > I understand that calling this code must be under a check for > > RTE_CPUFLAG_MOVDIR64B. > > Which I can't find in this patchset. > > Fair enough question. We currently do not check for availability of MOVDI= R64B since > every Intel part that includes DLB or DLB2 is guaranteed to have the MOVD= IR64B > instruction. A check at probe time would not hurt, but if you are sure of it, ok. --=20 David Marchand