DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] eal: change debug diagnostic message from udev handler
@ 2020-08-14 17:45 Stephen Hemminger
  2020-08-19  3:40 ` Jeff Guo
  2020-09-16 16:20 ` David Marchand
  0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2020-08-14 17:45 UTC (permalink / raw)
  To: dev; +Cc: Stephen Hemminger, jia.guo

The debug message was poorly worded and did not include the
part that would be useful. I.e it never said what was being ignored.
Change it to print the message so that if udev changes format or
other subsystems need to be added then the necessary information
will be in the debug log.

Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process")
Cc: jia.guo@intel.com
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/librte_eal/linux/eal_dev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/librte_eal/linux/eal_dev.c b/lib/librte_eal/linux/eal_dev.c
index 83c9cd660754..83b6068264cb 100644
--- a/lib/librte_eal/linux/eal_dev.c
+++ b/lib/librte_eal/linux/eal_dev.c
@@ -234,8 +234,7 @@ dev_uev_handler(__rte_unused void *param)
 
 	ret = dev_uev_parse(buf, &uevent, EAL_UEV_MSG_LEN);
 	if (ret < 0) {
-		RTE_LOG(DEBUG, EAL, "It is not an valid event "
-			"that need to be handle.\n");
+		RTE_LOG(DEBUG, EAL, "Ignoring uevent '%s'\n", buf);
 		return;
 	}
 
-- 
2.27.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] eal: change debug diagnostic message from udev handler
  2020-08-14 17:45 [dpdk-dev] [PATCH] eal: change debug diagnostic message from udev handler Stephen Hemminger
@ 2020-08-19  3:40 ` Jeff Guo
  2020-09-16 16:20 ` David Marchand
  1 sibling, 0 replies; 3+ messages in thread
From: Jeff Guo @ 2020-08-19  3:40 UTC (permalink / raw)
  To: Stephen Hemminger, dev

hi, stephen

Agree, it is make sense that the ignore event will sometimes involve the 
information which should not be ignore.

On 8/15/2020 1:45 AM, Stephen Hemminger wrote:
> The debug message was poorly worded and did not include the
> part that would be useful. I.e it never said what was being ignored.
> Change it to print the message so that if udev changes format or
> other subsystems need to be added then the necessary information
> will be in the debug log.
>
> Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process")
> Cc: jia.guo@intel.com


Should this cc line be removed? After that, please and thanks.

Acked-by: Jeff Guo <jia.guo@intel.com>.


> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>   lib/librte_eal/linux/eal_dev.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/linux/eal_dev.c b/lib/librte_eal/linux/eal_dev.c
> index 83c9cd660754..83b6068264cb 100644
> --- a/lib/librte_eal/linux/eal_dev.c
> +++ b/lib/librte_eal/linux/eal_dev.c
> @@ -234,8 +234,7 @@ dev_uev_handler(__rte_unused void *param)
>   
>   	ret = dev_uev_parse(buf, &uevent, EAL_UEV_MSG_LEN);
>   	if (ret < 0) {
> -		RTE_LOG(DEBUG, EAL, "It is not an valid event "
> -			"that need to be handle.\n");
> +		RTE_LOG(DEBUG, EAL, "Ignoring uevent '%s'\n", buf);
>   		return;
>   	}
>   

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] eal: change debug diagnostic message from udev handler
  2020-08-14 17:45 [dpdk-dev] [PATCH] eal: change debug diagnostic message from udev handler Stephen Hemminger
  2020-08-19  3:40 ` Jeff Guo
@ 2020-09-16 16:20 ` David Marchand
  1 sibling, 0 replies; 3+ messages in thread
From: David Marchand @ 2020-09-16 16:20 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev, Jeff Guo

On Fri, Aug 14, 2020 at 7:45 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The debug message was poorly worded and did not include the
> part that would be useful. I.e it never said what was being ignored.
> Change it to print the message so that if udev changes format or
> other subsystems need to be added then the necessary information
> will be in the debug log.
>
> Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Jeff Guo <jia.guo@intel.com>

Applied.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-09-16 16:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-14 17:45 [dpdk-dev] [PATCH] eal: change debug diagnostic message from udev handler Stephen Hemminger
2020-08-19  3:40 ` Jeff Guo
2020-09-16 16:20 ` David Marchand

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git