From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 493A2A04B5; Tue, 12 Jan 2021 09:14:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA652140D07; Tue, 12 Jan 2021 09:14:29 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 6FCE4140D06 for ; Tue, 12 Jan 2021 09:14:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610439268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wZ0PaQgDeVl0yT1Q7OrfQ/BXwGOhRUjNoQYKeXJf5+Q=; b=dvTcVTnZD0Knsx2GzEUZXBYs/5h4oFaRguILZJ/xuAyxCQqjFKR435JwlS6dVWpTNVuCSm 2YmAnP6tRdYfuv6jTM2fr6JppQTYvZNMIRyrfgGBProj9h7nRCTQ5vd1vNkT+QcML5Dla5 aBbD5NPcplEM3raJl4o35pT2Acb638o= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-318-xhQ5x4UCOWm2fUr1COXhrw-1; Tue, 12 Jan 2021 03:14:26 -0500 X-MC-Unique: xhQ5x4UCOWm2fUr1COXhrw-1 Received: by mail-vs1-f69.google.com with SMTP id a63so243614vsc.10 for ; Tue, 12 Jan 2021 00:14:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wZ0PaQgDeVl0yT1Q7OrfQ/BXwGOhRUjNoQYKeXJf5+Q=; b=tq7iPtwLKJAG5OA3XDZzwDYTaYsCedixSU5ScwTbZD1LFrMIKsxB5nYNtl29ifnVpT 0x6gdv53Yp7aroVSonrVJlLY5CG+r2zx6JrGTtJV1gaEFdZk/mamHO3ziSh2JBAlPpOt LOQbPhrXJFI9oGaurqN0/LHjmzsvEn7uej4WJi3X9cw3Pz/MYD5lgfBEUvb7zs6X/ZBv tF4Aho4BmsCUZylBw4cIavAxep2g+HxwTD7HJ9iWKCLcpNbbSxkKyLJn738Q2oiHvTUE olN41vbVc81YD4gwtZcLx/vaSNhGsiEukMcMjmdfoQLDt51m6W35KHzw1JIphngMZve1 T4yg== X-Gm-Message-State: AOAM530TyPU78abnIgTv9Xr88In+dOcg9goBx+MvXkD/TyfAwpIYw4JE KhmW+XPxqElfAX6lAhac729ElzHpkECWYTax9jJ9s9gTcD5/UILIfp7Jn8jnAfUi2f2QmM5UCO1 ceRzX6Ha2XXmcpFDJbd0= X-Received: by 2002:a67:f80b:: with SMTP id l11mr2590416vso.27.1610439265853; Tue, 12 Jan 2021 00:14:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJy1ypBSQULfu+eZq5hSJvd5dxrRXFsnlvvt906wYiv1dwnAZErYyQNutYBeM7I4XAsv6HeMFsE69cQSgB6waio= X-Received: by 2002:a67:f80b:: with SMTP id l11mr2590409vso.27.1610439265669; Tue, 12 Jan 2021 00:14:25 -0800 (PST) MIME-Version: 1.0 References: <1610390183-22709-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1610390183-22709-1-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Tue, 12 Jan 2021 09:14:14 +0100 Message-ID: To: Tyler Retzlaff Cc: Thomas Monjalon , dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] build rte_reciprocal.c on windows and export rte_reciprocal_value_u64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jan 11, 2021 at 7:36 PM Tyler Retzlaff wrote: Commitlog please. > > From: Tyler Retzlaff > > --- > lib/librte_eal/common/meson.build | 1 + > lib/librte_eal/rte_eal_exports.def | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build > index 39abf7a0a..9c6f18eb8 100644 > --- a/lib/librte_eal/common/meson.build > +++ b/lib/librte_eal/common/meson.build > @@ -34,6 +34,7 @@ if is_windows > 'rte_malloc.c', > 'eal_common_timer.c', > 'rte_service.c', > + 'rte_reciprocal.c', > ) > subdir_done() > endif > diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def > index 4597eb8cd..ba1443dc2 100644 > --- a/lib/librte_eal/rte_eal_exports.def > +++ b/lib/librte_eal/rte_eal_exports.def > @@ -326,3 +326,4 @@ EXPORTS > rte_mem_map > rte_mem_page_size > rte_mem_unmap > + rte_reciprocal_value_u64 Looking at rte_reciprocal.c/.h and EAL version.map, this API exports two symbols. If there is no reason why the other symbol has been skipped, please add both: rte_reciprocal_value rte_reciprocal_value_u64 -- David Marchand