From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5619CA04B1; Thu, 5 Nov 2020 09:54:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7C2B072E9; Thu, 5 Nov 2020 09:54:50 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 988D85AB3 for ; Thu, 5 Nov 2020 09:54:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604566486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jl3/gemKGg6wZdVE5aPO9bVCxMl7ChdgY+hed244Dfc=; b=DFmELZfGeNAERfmobYi21AXIDau1zCre71rzS/H19ffs+jceo3ROvc6WXiS+LUQ3vkt0ga BsZkx3NDfrcbqXUvw7ywWlMfWl/ERR5t1tPZgqADkx047f8Y50SFgTMUDpgGMOWh4knWve K+JC2bBcpfWaIQp7c0bYEdWV2FnWw6I= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-11-eDscTG7cOG225KbKvl3xEQ-1; Thu, 05 Nov 2020 03:54:45 -0500 X-MC-Unique: eDscTG7cOG225KbKvl3xEQ-1 Received: by mail-vs1-f72.google.com with SMTP id z9so482179vsl.3 for ; Thu, 05 Nov 2020 00:54:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Jl3/gemKGg6wZdVE5aPO9bVCxMl7ChdgY+hed244Dfc=; b=k2MF8vRHF8GvK/vqU5FW244baIhc8A7lKNk3WQ9PcZY58g6ncbj8/rnl5yVc3/+AeR JQS2dTnh5kbvOLqNVYz8my2Mq+qiq9R5W73iLMbPvTWRMxeao2Re8qG5o3PJ8Jl73CeO RJiyzrlUjjSWJq7a5UvmmxY/Di8djWmpqPHZkNM/INVaQm1voQGVY9Vm0erpgCLTT5Tx YyOdFnFhyw0vidTCWQEpe2aQXNPkXdwxtr2MSCkZq6ChHUfIUQMTKCKy1+7KjIPpWW/+ 1y/9BrA0p7q1KuC3AQzH0nFakCVYTL5b38cfRiO+Am6vCC3QJkaZf4eVdzPKepzNmRRW 6jgQ== X-Gm-Message-State: AOAM530v8dvczubnvJ2drJLNXpzeUOWq/6UxdhuzvBBoxmic7D4ncQ6T 70SQfxJC6WdY7GwpySKqABb0wb+BIgAdCQ8wvkcCYIvi5BvNuZVUL9Ah87ke+bJRwfo9p/PUSp8 kNGiAGYKom0l0LnDYamA= X-Received: by 2002:a1f:9004:: with SMTP id s4mr560131vkd.22.1604566484721; Thu, 05 Nov 2020 00:54:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJyqzpLjGnHrtyB45lEzjEGaiXtv83FP5ZFqSBru5qDellTIoToxydCZgmU7saROfynVyUabNfrVKYdnLe8ITQ0= X-Received: by 2002:a1f:9004:: with SMTP id s4mr560125vkd.22.1604566484483; Thu, 05 Nov 2020 00:54:44 -0800 (PST) MIME-Version: 1.0 References: <20201102111915.5279-1-ibtisam.tariq@emumba.com> In-Reply-To: <20201102111915.5279-1-ibtisam.tariq@emumba.com> From: David Marchand Date: Thu, 5 Nov 2020 09:54:33 +0100 Message-ID: To: Ibtisam Tariq Cc: "Ananyev, Konstantin" , dev , "Iremonger, Bernard" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] doc: fix typing error in example/l3_forward_access_ctrl X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 2, 2020 at 12:20 PM Ibtisam Tariq wr= ote: > > Add "--" and remove extra spaces in l3fwd-acl commands. > > Fixes: d0dff9ba4 ("doc: sample application user guide") > Cc: bernard.iremonger@intel.com > > Signed-off-by: Ibtisam Tariq > --- > doc/guides/sample_app_ug/l3_forward_access_ctrl.rst | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/doc/guides/sample_app_ug/l3_forward_access_ctrl.rst b/doc/gu= ides/sample_app_ug/l3_forward_access_ctrl.rst > index 4a96800ec..3cdfbfb17 100644 > --- a/doc/guides/sample_app_ug/l3_forward_access_ctrl.rst > +++ b/doc/guides/sample_app_ug/l3_forward_access_ctrl.rst > @@ -236,7 +236,7 @@ The application has a number of command line options: > > .. code-block:: console > > - .//examples/dpdk-l3fwd-acl [EAL options] -- -p PORTMASK [= -P] --config(port,queue,lcore)[,(port,queue,lcore)] --rule_ipv4 FILENAME ru= le_ipv6 FILENAME [--alg=3D] [--enable-jumbo [--max-pkt-len PKTLEN]] [-= -no-numa] [--eth-dest=3DX,MM:MM:MM:MM:MM:MM] > + .//examples/dpdk-l3fwd-acl [EAL options] -- -p PORTMASK [= -P] --config(port,queue,lcore)[,(port,queue,lcore)] --rule_ipv4 FILENAME --= rule_ipv6 FILENAME [--alg=3D] [--enable-jumbo [--max-pkt-len PKTLEN]] = [--no-numa] [--eth-dest=3DX,MM:MM:MM:MM:MM:MM] > > > where, > @@ -271,7 +271,7 @@ To enable L3 forwarding between two ports, assuming t= hat both ports are in the s > > .. code-block:: console > > - .//examples/dpdk-l3fwd-acl -l 1,2 -n 4 -- -p 0x3 --config= =3D"(0,0,1),(1,0,2)" --rule_ipv4=3D"./rule_ipv4.db" -- rule_ipv6=3D"./rule_= ipv6.db" --alg=3Dscalar > + .//examples/dpdk-l3fwd-acl -l 1,2 -n 4 -- -p 0x3 --config= =3D"(0,0,1),(1,0,2)" --rule_ipv4=3D"./rule_ipv4.db" --rule_ipv6=3D"./rule_i= pv6.db" --alg=3Dscalar > > In this command: > > @@ -293,9 +293,9 @@ In this command: > | | | | = | > +----------+------------+-----------+-------------------------------= ------+ > > -* The --rule_ipv4 option specifies the reading of IPv4 rules sets from= the ./ rule_ipv4.db file. > +* The --rule_ipv4 option specifies the reading of IPv4 rules sets from= the ./rule_ipv4.db file. No point in keeping the ./ and I would remove it in the cmdline example above too. > -* The --rule_ipv6 option specifies the reading of IPv6 rules sets from= the ./ rule_ipv6.db file. > +* The --rule_ipv6 option specifies the reading of IPv6 rules sets from= the ./rule_ipv6.db file. > > * The --alg=3Dscalar option specifies the performing of rule lookup wi= th a scalar function. > > -- > 2.17.1 > Reviewed-by: David Marchand Thanks. --=20 David Marchand