Re: [PATCH v6 0/3] add eal functions for thread affinity and self

[David Marchand <david.marchand@redhat.com>]

Hello Tyler,

On Thu, May 12, 2022 at 3:14 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
>
> this series provides basic dependencies for additional eal thread api
> additions. series includes
>
> * basic platform error number conversion.
> * function to get current thread identifier.
> * functions to get and set affinity with platform agnostic thread
>   identifier.
> * minimal unit test of get and set affinity demonstrating usage.
>
> note: previous series introducing these functions is now superseded by
> this series.
> http://patches.dpdk.org/project/dpdk/list/?series=20472&state=*
>
> v6:
> * rebase for asan flag addition to app/test/meson.build
> * RTE_BUILD_BUG_ON(sizeof(pthread_t) > sizeof(uintptr_t)) to raise
>   attention if pthread_t implementation exceeds storage available
>   from uintptr_t.
>   note:
>     the macro is placed in rte_thread_self() body because it not
>     valid syntax at file scope of the translation unit. ordinarily
>     the macro would be used in headers but that would leak the
>     pthread_t implementation detail into the public header.

There was a missing update of MAINTAINERS in patch 3 that I fixed.
Series lgtm, applied, thanks.


Looking at the generated documentation, rte_thread.h is not exposed,
but this was already the case before the series.
Could you look into it?


-- 
David Marchand