From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C9D2FA0505; Thu, 19 May 2022 18:28:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A755427F8; Thu, 19 May 2022 18:28:05 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 489F440156 for ; Thu, 19 May 2022 18:28:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652977683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O/bc4f+mKSLn4oMmo20ywW/Nb1RRefSUVxiFUVs/Kug=; b=JDCGv8IldpzyxEVBRiUmoIF7KWt8N6uCNdTkwYANt8QLMgaVwu1oG/gY4/X45OXLGcxaFq IQOKInb3Q9wminy77hCwP18tCaZ7n4uECLiPMKfHGr0swm3N2aylzf2Hs0tjFc6ws18qNr 1GovKCzky/FXmL8A3miyfB4mwKzMl8E= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-663-yJIy_vYrPGKSC2Ts91XJYQ-1; Thu, 19 May 2022 12:28:02 -0400 X-MC-Unique: yJIy_vYrPGKSC2Ts91XJYQ-1 Received: by mail-lf1-f69.google.com with SMTP id l19-20020ac24313000000b004739dbba717so2879087lfh.5 for ; Thu, 19 May 2022 09:28:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O/bc4f+mKSLn4oMmo20ywW/Nb1RRefSUVxiFUVs/Kug=; b=Me8w3wy/QqmuIujraMCvgnjbVea6zX14iLCYjKppGEGK6Rxvsb8mWCVFXBDWqHvyAe GmqEBTUvo+JoNWa+/Lj176FeDh20fo80j3YVd7Wc4QvgI5Z9XwR826LmcXPu6/VOGXmm v9Fl47CamRjy2lr+Wiv8Rvs5l93JklOsU9Z+4zv2UuAQ3zCtrjVZtOwuTDmTEaXxDekN gO6/vCZrDjOn9NPb5u2lHdv7kbNPxzfhtjyxKNZRlvk2b5WrgBsZTFnshFi6Ag/HvhSk 9LAvU5ZBdwOkIzDeg6BNYFK5O94M6rp14ZVF+SAhiWEhVpVqZVwLBPRlOljmNj50Pw7B uRAg== X-Gm-Message-State: AOAM530EjiXzv9BM3Eymvy/gXanBtamHSmQ8KCwsKx9sg8U3tUYJBAo8 GsyaPnXETol0C7fQvIXolGggp5Oy/X/q9LcCExO66qESSAUufbqkjlgWNYIpW7Cw5g+miujS6Cv I2bhlJnx6fsLlKP9e+lg= X-Received: by 2002:a05:6512:3f8c:b0:45d:cb2a:8779 with SMTP id x12-20020a0565123f8c00b0045dcb2a8779mr3990773lfa.499.1652977681151; Thu, 19 May 2022 09:28:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwh/zRxMGmPAkpxbwROZHiDTWhoVz0aQD/Kg8cP88+Bhrdy8vNe2fFDfUFhg/SIK1n8bD7EfP2r1PisU0pKpYI= X-Received: by 2002:a05:6512:3f8c:b0:45d:cb2a:8779 with SMTP id x12-20020a0565123f8c00b0045dcb2a8779mr3990755lfa.499.1652977680958; Thu, 19 May 2022 09:28:00 -0700 (PDT) MIME-Version: 1.0 References: <20220505102729.821075-1-maxime.coquelin@redhat.com> <20220505102729.821075-2-maxime.coquelin@redhat.com> In-Reply-To: <20220505102729.821075-2-maxime.coquelin@redhat.com> From: David Marchand Date: Thu, 19 May 2022 18:27:49 +0200 Message-ID: Subject: Re: [PATCH 1/6] Revert "app/testpmd: modify mac in csum forwarding" To: Maxime Coquelin Cc: dev , Jason Wang , "Xia, Chenbo" , Olivier Matz , dpdk stable , dts@dpdk.org, "Tu, Lijuan" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, May 5, 2022 at 12:27 PM Maxime Coquelin wrote: > > This patch reverts commit 10f4620f02e1 ("app/testpmd: modify mac in csum forwarding"), > as the checksum forwarding is expected to only perform > checksum and not also overwritte the source and destination > MAC addresses. > > Doing so, we can test checksum offloading with real traffic > without breaking broadcast packets. > > Fixes: 10f4620f02e1 ("app/testpmd: modify mac in csum forwarding") > Cc: stable@dpdk.org > > Signed-off-by: Maxime Coquelin Thanks Maxime, this lgtm. Cc: dts ml since dts was dropping this code for some tests. origin/main:test_plans/dpdk_gro_lib_cbdma_test_plan.rst: ether_addr_copy(&peer_eth_addrs[fs->peer_addr], origin/main:test_plans/dpdk_gro_lib_cbdma_test_plan.rst: ether_addr_copy(&ports[fs->tx_port].eth_addr, origin/main:test_plans/dpdk_gro_lib_test_plan.rst: ether_addr_copy(&peer_eth_addrs[fs->peer_addr], origin/main:test_plans/dpdk_gro_lib_test_plan.rst: ether_addr_copy(&ports[fs->tx_port].eth_addr, origin/main:test_plans/dpdk_gso_lib_test_plan.rst: ether_addr_copy(&peer_eth_addrs[fs->peer_addr], origin/main:test_plans/dpdk_gso_lib_test_plan.rst: ether_addr_copy(&ports[fs->tx_port].eth_addr, origin/main:test_plans/virtio_user_as_exceptional_path_test_plan.rst: ether_addr_copy(&peer_eth_addrs[fs->peer_addr], origin/main:test_plans/virtio_user_as_exceptional_path_test_plan.rst: ether_addr_copy(&ports[fs->tx_port].eth_addr, origin/main:tests/TestSuite_dpdk_gro_lib.py: "sed -i '/ether_addr_copy(&peer_eth/i\#if 0' ./app/test-pmd/csumonly.c", "#" origin/main:tests/TestSuite_dpdk_gro_lib_cbdma.py: "sed -i '/ether_addr_copy(&peer_eth/i\#if 0' ./app/test-pmd/csumonly.c", "#" origin/main:tests/TestSuite_dpdk_gso_lib.py: "sed -i '/ether_addr_copy(&peer_eth/i\#if 0' ./app/test-pmd/csumonly.c", "#" origin/main:tests/TestSuite_virtio_user_as_exceptional_path.py: "sed -i '/ether_addr_copy(&peer_eth/i\#if 0' ./app/test-pmd/csumonly.c", "#" -- David Marchand