From: David Marchand <david.marchand@redhat.com>
To: Volodymyr Fialko <vfialko@marvell.com>,
Kevin Laatz <kevin.laatz@intel.com>
Cc: dev@dpdk.org, "Bruce Richardson" <bruce.richardson@intel.com>,
"Morten Brørup" <mb@smartsharesystems.com>,
jerinj@marvell.com
Subject: Re: [PATCH] bus: fix leak for devices without driver
Date: Tue, 7 Feb 2023 14:48:06 +0100 [thread overview]
Message-ID: <CAJFAV8w0sMrweXgLp+kfmmbW529_jJYjG1mZ3cYVteDxzrakMg@mail.gmail.com> (raw)
In-Reply-To: <20230107151230.2539470-1-vfialko@marvell.com>
On Sat, Jan 7, 2023 at 4:12 PM Volodymyr Fialko <vfialko@marvell.com> wrote:
>
> For devices not assigned to any driver, we leak a pci device object since
> it is never freed from the PCI bus device list, reported by ASAN.
>
> Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown")
Worth copying stable.
>
> Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
At a quick glance, the fix lgtm.
Kevin, can you double check this fix thoroughly?
Thanks.
--
David Marchand
next prev parent reply other threads:[~2023-02-07 13:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-07 15:12 Volodymyr Fialko
2023-02-07 13:48 ` David Marchand [this message]
2023-02-08 11:30 ` Kevin Laatz
2023-02-09 13:22 ` [PATCH v2] " Volodymyr Fialko
2023-02-10 9:28 ` Kevin Laatz
2023-02-10 11:55 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8w0sMrweXgLp+kfmmbW529_jJYjG1mZ3cYVteDxzrakMg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kevin.laatz@intel.com \
--cc=mb@smartsharesystems.com \
--cc=vfialko@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).