From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCC29A0093; Wed, 9 Mar 2022 09:44:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8EE2840687; Wed, 9 Mar 2022 09:44:55 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id F2BAC40395 for ; Wed, 9 Mar 2022 09:44:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646815493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l+AKuDi0aWV9oB2hG+v3Y6eJNlytn7wZK1bk0ryBxgE=; b=gQKEX53YajXL1wBZ4MazY3bnFZx3qJPNmTBJ6joU+KMcCjekylXDuJPWBExCFi/AxaqxDJ IJbjYpAY/lxZjUJVXatiJAhsag75w9HHvILXTT9/x9hdcQbWU4eKunqEfzfghxfZGLEKIB BTXrQ6Hc40f8nnaVUo/osHVOYi8kLwU= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-639-t96lnj3aMcq1xCly9inkFg-1; Wed, 09 Mar 2022 03:44:52 -0500 X-MC-Unique: t96lnj3aMcq1xCly9inkFg-1 Received: by mail-lj1-f198.google.com with SMTP id r16-20020a2e5750000000b00247cf98271dso551451ljd.6 for ; Wed, 09 Mar 2022 00:44:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l+AKuDi0aWV9oB2hG+v3Y6eJNlytn7wZK1bk0ryBxgE=; b=Q68oDpMRH9w9dDErz1PAjxVWUDX5Z+DLA4ZHxJ4Crojaf7IQ320jCaqm5rywLt7KcQ da6zkl6U0tPRIcDS0Z3frxIUYN7yFvSbhf92kX2O+TJSSbbvGOjtwmjSj/3OR7MkZoPM zhCS1X/3O6hc5BplGXHKLyZmVMGVN5kiE2XMv+PcTotu5lm0T+vEXM2OZrJeAUx3vp3M Lpc4V917d+NlzvgIkbewdm38ms5d0PyAIug6CZElfpSGP6jwfuLDBHy78Np8ncpz2Qle uBvwCRmnU7O2o++3M3PQSGR25aFS0pN/HV+Ep512jSIM7OYda9DHYmDExQdAaEtqfg9O oaCQ== X-Gm-Message-State: AOAM532qDIZvrfJecHhJWbJrLyr6f+BPXKf/ifvosaGTudkOLsrSoT+M 1uOxXa/WaKmBuDj99XH7BIipQIfyTkw+ejf4cxM9onrx0Myz97nKEpqL9/qag0vXPiIZgfgKlpV JtHGyNn0fySx7cFcL0vw= X-Received: by 2002:a2e:9997:0:b0:247:ec9c:8efb with SMTP id w23-20020a2e9997000000b00247ec9c8efbmr5162480lji.297.1646815490558; Wed, 09 Mar 2022 00:44:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJwmkt9L05OZ1BjQPC6W+TQA3IylucsarhffWkHHobTnTax2jy8qw2JegeghKHMvP0NNJJ8EkFyBZKTq12iMhWk= X-Received: by 2002:a2e:9997:0:b0:247:ec9c:8efb with SMTP id w23-20020a2e9997000000b00247ec9c8efbmr5162474lji.297.1646815490340; Wed, 09 Mar 2022 00:44:50 -0800 (PST) MIME-Version: 1.0 References: <1646333498-18883-1-git-send-email-nicolas.chautru@intel.com> <1646333498-18883-2-git-send-email-nicolas.chautru@intel.com> <5072825.0vhOF50zNu@thomas> In-Reply-To: <5072825.0vhOF50zNu@thomas> From: David Marchand Date: Wed, 9 Mar 2022 09:44:38 +0100 Message-ID: Subject: Re: [PATCH v1] maintainers: add explicit maintainer for some bbdev PMDs To: Thomas Monjalon , Nicolas Chautru Cc: dev , Akhil Goyal , Bruce Richardson Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Mar 9, 2022 at 12:23 AM Thomas Monjalon wrote: > > 03/03/2022 19:51, Nicolas Chautru: > > These were implicit from DPDK script but adding > > separate reference to make it explicit > > > > Signed-off-by: Nicolas Chautru > > --- > > MAINTAINERS | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 7577834..004ec91 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -421,6 +421,10 @@ T: git://dpdk.org/next/dpdk-next-crypto > > F: lib/bbdev/ > > F: doc/guides/prog_guide/bbdev.rst > > F: drivers/baseband/ > > I think you can remove the above catch-all. > > > +F: drivers/baseband/turbo_sw/ > > +F: drivers/baseband/fpga_lte_fec/ > > +F: drivers/baseband/fpga_5gnr_fec/ > > +F: drivers/baseband/acc100/ > > I would prefer a separate section for Intel baseband drivers. We now have a baseband drivers section with a NXP driver. It is more clear to have Intel drivers in this section like we do for other classes of devices: one section for API, one section for drivers. Btw, the baseband drivers section is missing a global T: entry too. It means that updates on nxp (atm) and any (in the future) bbdev driver ends up in the main repo scope instead of next-crypto. > > > F: doc/guides/bbdevs/ This too is a catch all. For the API section, I'd rather see: -F: drivers/baseband/ -F: doc/guides/bbdevs/ +F: doc/guides/bbdevs/features/default.ini > > F: app/test-bbdev/ > > F: doc/guides/tools/testbbdev.rst -- David Marchand