From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-f46.google.com (mail-ua1-f46.google.com [209.85.222.46]) by dpdk.org (Postfix) with ESMTP id 861051B147 for ; Wed, 5 Dec 2018 14:22:32 +0100 (CET) Received: by mail-ua1-f46.google.com with SMTP id v24so7064566uap.13 for ; Wed, 05 Dec 2018 05:22:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e4Dt8pvWSsHhvaueRdPManJ9cUviY+SL39adv4ZV53Y=; b=leMsLi++CL/xlwww3YoeOmIWltuk2vZOr1E/YmUluaXVnKkTgCsJ2izM0VWGh+vZig CPZ0mAjaw1CF/rwy5gbvhvcScAFNcv6kMonw2+Wl6uX1CtkqDRow5xhnOw07rBhSNLoJ 2Krw/wA6W7s4o3R2QzBFiXbVz63z3E2pOlgAXK9mQlc1kMWSTyiC6S3gL+slKocHGaUd Hcbp20P1fSk+pwzq7jtFWBI8gcBgMI393jA6yj6osx1iuRUmbkN3evZg0TA1v169hd33 fDUNS7D2TIP7b9VMdCKQoFj0RsbJf7fMt6iRT4UWjdHe+sVk0B8ef7ycBhTFxLEpFrqn MTEg== X-Gm-Message-State: AA+aEWaNmb3hMY7Tq5eOUAJ20UwrC1annKsXO0hseFgPxmX2UvUqz9Yg IrSOnvBRFwOJIb7pUDU68BslgX1ddcmzY8+mqJPIEw== X-Google-Smtp-Source: AFSGD/WX2F1zxn3GFLeWqYbiWuiqA+HNGu1ktBfq8gX6ZcTf6cR4u8l7h6g4VP406gb2YqoSs29ICG942zKv/nbp5/w= X-Received: by 2002:ab0:7488:: with SMTP id n8mr3607960uap.115.1544016151544; Wed, 05 Dec 2018 05:22:31 -0800 (PST) MIME-Version: 1.0 References: <20181203164724.GA12316@hmswarspite.think-freely.org> <20181204151457.GA31778@hmswarspite.think-freely.org> <20181205122124.GA6752@hmswarspite.think-freely.org> In-Reply-To: <20181205122124.GA6752@hmswarspite.think-freely.org> From: David Marchand Date: Wed, 5 Dec 2018 14:22:20 +0100 Message-ID: To: nhorman@tuxdriver.com Cc: ferruh.yigit@intel.com, dev@dpdk.org, Timothy Redaelli , adrien.mazarguil@6wind.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] Marking symbols as experimental in the headers only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Dec 2018 13:22:32 -0000 On Wed, Dec 5, 2018 at 1:23 PM Neil Horman wrote: > On Tue, Dec 04, 2018 at 09:48:22PM +0100, David Marchand wrote: > > On Tue, Dec 4, 2018 at 4:16 PM Neil Horman > wrote: > > > If you would like to make this adjustment, I'm fine with it, though be > > > aware, > > > you will likely need to make some adjustments to the > > > check-experimental-syms > > > script to account for this > > > > > > > I am not sure I see what you mean on check-experimental-syms.sh. > > I would only do a s/definition/declaration/ in the error message. > > Do you have something else in mind ? > All I was saying was that if you wanted to document the policy change, you > might > need to check that script as its a reflection of that policy, and I > couldn't > recall if it was grepping through .c and .h files (which might imply it > needs to > change to reflect this policy). I just looked however, and its checking > object > files, so you should be ok. > Yes, thanks for the confirmation. -- David Marchand