From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86DEC4264F; Wed, 27 Sep 2023 09:56:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CDCB1402DB; Wed, 27 Sep 2023 09:56:23 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 04F41402CA for ; Wed, 27 Sep 2023 09:56:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695801382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D7U0wcfCZi3tBKO4YbFtUryGNyViovkPGtKqyaH8IZk=; b=IXw5kvKLs7DXi75xinyaHrrmoGgWNCWiuHJo/1aQGXiYJCR19P+Z/FpSW3BLQTrEJFQci5 aaaaVvPwrUVk+IG6ieWgiwl7js7bY7YbcYhhPTw2yvipLEMNgT6i00FTTKf1w7m9fVsnsC K32isG2Y6NrF8G1j+etWDKK662spX1s= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-36-bs3Fzvr8N86VL2e9J7STvA-1; Wed, 27 Sep 2023 03:56:21 -0400 X-MC-Unique: bs3Fzvr8N86VL2e9J7STvA-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2c00605ff0cso96889581fa.1 for ; Wed, 27 Sep 2023 00:56:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695801379; x=1696406179; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D7U0wcfCZi3tBKO4YbFtUryGNyViovkPGtKqyaH8IZk=; b=pwtYYxsLimIVjJPkGMd29aud/e38zHC8AySCvY4C03R/Kgjfb/WKaBAoGk+g+JFWnR EBlJtxabAJBuriGc/5cvLpOgJskzWaEEbXz6WVDzF4GG/9cMWP4S1x/+w4hU4VW+rVzR dbXCoEZwvDfPRg7/4YVCHrJuwf96Ljhr6hx2gm2BaJhSpfdFOp2bI6gS7ngdqglqcknR h/ddjySy2SSo70tkt3gAhfKxPnJ2l62/4PbIhedCRmXr5MJnmF/6VhRxOMVWUiknL6WV CFM2dU7UKPV5EekymXexgNkRh1mCFksAHiBaiKIHExS+KSLMr8bgbD900Ey119Gu7LTN dBkQ== X-Gm-Message-State: AOJu0YzmaRMSm4gj4wXJDM2xzqXdpH7rXta93JWizltnZX5MhKSZaA5a 4n3B5h6w3YFW5MOqwLPj9IhcxSDR1zb5D2TcojHPQe/uezhyohsYgMJXbW30xwp3r0SmS9vaUvG ZbTKO1fCa7e/pAWz61Vk= X-Received: by 2002:a05:6512:36c6:b0:502:a964:84b1 with SMTP id e6-20020a05651236c600b00502a96484b1mr516362lfs.25.1695801379629; Wed, 27 Sep 2023 00:56:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEyVkITDu62Nak9RY2BYUsQORisMaWMWpXN+qHpTcdySLpuRFxcBYQVtRpZjvrmb/uIl0z0UvlUVlTlF3DJswQ= X-Received: by 2002:a05:6512:36c6:b0:502:a964:84b1 with SMTP id e6-20020a05651236c600b00502a96484b1mr516352lfs.25.1695801379043; Wed, 27 Sep 2023 00:56:19 -0700 (PDT) MIME-Version: 1.0 References: <20230919102012.419201-2-rjarry@redhat.com> In-Reply-To: <20230919102012.419201-2-rjarry@redhat.com> From: David Marchand Date: Wed, 27 Sep 2023 09:56:07 +0200 Message-ID: Subject: Re: [PATCH] usertools/pmdinfo: fix usage typos To: Robin Jarry Cc: dev@dpdk.org, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Sep 19, 2023 at 12:20=E2=80=AFPM Robin Jarry wr= ote: > > The docs and script usages are not consistent. > > There is no .devices, .vendor_id nor .device_id fields. Fix usage to the > correct field names. > > Some drivers do not expose any pci_ids, show how to use the []? jq > operator to avoid spurious errors. > > Fixes: 0ce3cf4afd04 ("usertools/pmdinfo: rewrite simpler script") > Cc: stable@dpdk.org > > Signed-off-by: Robin Jarry My jq-ryu was not enough, thanks for the fix :-). Reviewed-by: David Marchand --=20 David Marchand