From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com,
vladimir.medvedkin@intel.com, ian.stokes@intel.com,
john.mcnamara@intel.com, Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] build: remove support for icc compiler
Date: Wed, 5 Feb 2025 18:03:16 +0100 [thread overview]
Message-ID: <CAJFAV8w1ROF3rGGyrpDWokpxZT+tiG1vWXbfwFemqSYzt3vPBw@mail.gmail.com> (raw)
In-Reply-To: <20250205161823.2849595-1-bruce.richardson@intel.com>
On Wed, Feb 5, 2025 at 5:19 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> The Intel-produced compiler "icc" has been replaced by the newer
> clang-based "icx" compiler. DPDK compilation has also not been tested
> recently with the icc compiler, so let's remove doc and code references
> to icc, and any special macros or build support that was added for it.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
I noticed remaining references, from which some can be cleaned up too:
app/test-pmd/testpmd.h: * Work-around of a compilation error with ICC
on invocations of the
lib/eal/common/eal_common_dynmem.c: /* to prevent
icc errors */
lib/eal/x86/include/rte_vect.h:#if defined(__ICC) || defined(_WIN64)
buildtools/check-symbols.sh:# Filter out symbols suffixed with a . for icc
buildtools/check-symbols.sh:# Filter out symbols suffixed with a . for icc
And please add a release note update.
Thanks.
--
David Marchand
next prev parent reply other threads:[~2025-02-05 17:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 16:18 Bruce Richardson
2025-02-05 16:33 ` Stephen Hemminger
2025-02-05 17:03 ` David Marchand [this message]
2025-02-05 17:32 ` Bruce Richardson
2025-02-05 17:46 ` Bruce Richardson
2025-02-05 18:29 ` [PATCH v2 0/2] replace icc support with icx Bruce Richardson
2025-02-05 18:29 ` [PATCH v2 1/2] drivers: fix build warnings when using icx Bruce Richardson
2025-02-05 18:29 ` [PATCH v2 2/2] build: replace support for icc with icx Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8w1ROF3rGGyrpDWokpxZT+tiG1vWXbfwFemqSYzt3vPBw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ian.stokes@intel.com \
--cc=john.mcnamara@intel.com \
--cc=thomas@monjalon.net \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).