From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1309A051C; Fri, 26 Jun 2020 16:43:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 86D531C0BE; Fri, 26 Jun 2020 16:43:39 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 9DDCD1C0B5 for <dev@dpdk.org>; Fri, 26 Jun 2020 16:43:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593182618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZL/h6mJn6xyiHb/VFyzoWPDUacMLdhXNKZspVsAevpk=; b=BKdIM6jFuDmXmOdp3BJyy8EUEvumgqxChhxlT80eM/SYB+8HbAQYiePFl8pPSlk9L60pO4 SwvQ5x1F5H4pADDreWwwCUvxK05YO6Kp6bFg+Pr0DC3BB+qJLGFgqIljQPN5y3uCoMiUVd eJ7VwgN89uoBsBVhgfLoPHlM0Zh4qg8= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-230-E2__S9lgOaqxgzsbzShwBA-1; Fri, 26 Jun 2020 10:43:32 -0400 X-MC-Unique: E2__S9lgOaqxgzsbzShwBA-1 Received: by mail-vs1-f69.google.com with SMTP id w26so3149466vso.19 for <dev@dpdk.org>; Fri, 26 Jun 2020 07:43:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZL/h6mJn6xyiHb/VFyzoWPDUacMLdhXNKZspVsAevpk=; b=biBzrIm2FA4/LLNIqQMHjpfbNguH3BvYB8KdHyXd8oFcrOpLPEfRJ4JyUl/Gv9Eqwz 1/TT4w4eyXnQH+yaeJV5MDV0A7eOtNeIh3KWVTQV2ZPKmFej4twIVeHonn9mrdj25qwk yX6Wi+UMFSC8zdSZtn0b9dsC1tpigoCPpzoLerm2ogjL8OV9zbQHEaMdAhBk3SQoYAHb S+0+B6W+qbEXaAwDn8h1oiK4YGesJUhFcV54Vjr7C67oAX+3WmHmEEIhKCVUmgUafu4+ DmrcURcrEhfnuTCP+z92DkkYJ+J42aizTXqe8YxZrKg+HeOgf+ycxoM1/Kz0SUwgPz7Y EmLA== X-Gm-Message-State: AOAM532cEwHH/XAhC2xE5VRbGfkvyNQMYuBIrObFiegmm92d2jj3W1nq yP2x5qLKigMNE3hOQ42CrOwLDlCmeE17NB1X8v2xUNyJ3y1W1Qqq2yxG8hiM/jRme1bjagdeXIe QMTl7jEI+9BG2BSfusYE= X-Received: by 2002:a67:26c2:: with SMTP id m185mr2733017vsm.39.1593182611770; Fri, 26 Jun 2020 07:43:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzIQM7JHjRS/fk/Tdpmvs5UdscwMY6ywYWLwQ5aJTNagoD3ORy1mAgOUSZe0TdOG0X9O52ve9yIPJyLhf0C+Hg= X-Received: by 2002:a67:26c2:: with SMTP id m185mr2733004vsm.39.1593182611542; Fri, 26 Jun 2020 07:43:31 -0700 (PDT) MIME-Version: 1.0 References: <20200610144506.30505-1-david.marchand@redhat.com> <20200622132531.21857-1-david.marchand@redhat.com> <20200622132531.21857-7-david.marchand@redhat.com> <BYAPR11MB33010EBC5471E7157AA664359A970@BYAPR11MB3301.namprd11.prod.outlook.com> <CAJFAV8y_X_7K+vxXz1xT5V1RPY9R_hAdLTCBBgiexKtvdESjng@mail.gmail.com> <BYAPR11MB3301F1258A2D4B38A79E1CA79A940@BYAPR11MB3301.namprd11.prod.outlook.com> <CAJFAV8zCHKNnUpnm0V2pzsnEOA2hYNampgOAgCsMSV5487U8+A@mail.gmail.com> <BYAPR11MB3301411E7CA79B951F96BD219A950@BYAPR11MB3301.namprd11.prod.outlook.com> <CAJFAV8ySxY+MvsrpPo8sTCnxzXx0QM4UiKy8AiQwrFNwU6ea-Q@mail.gmail.com> <BYAPR11MB330106BD35DAF644BC1A7EDF9A950@BYAPR11MB3301.namprd11.prod.outlook.com> In-Reply-To: <BYAPR11MB330106BD35DAF644BC1A7EDF9A950@BYAPR11MB3301.namprd11.prod.outlook.com> From: David Marchand <david.marchand@redhat.com> Date: Fri, 26 Jun 2020 16:43:20 +0200 Message-ID: <CAJFAV8w1WkUZYOy6tJxJtnwT5uH1KUsW5STf5f9eATtsjej+6w@mail.gmail.com> To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "jerinjacobk@gmail.com" <jerinjacobk@gmail.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, "mdr@ashroe.eu" <mdr@ashroe.eu>, "ktraynor@redhat.com" <ktraynor@redhat.com>, "Stokes, Ian" <ian.stokes@intel.com>, "i.maximets@ovn.org" <i.maximets@ovn.org>, Thomas Monjalon <thomas@monjalon.net>, "Mcnamara, John" <john.mcnamara@intel.com>, "Kovacevic, Marko" <marko.kovacevic@intel.com>, "Burakov, Anatoly" <anatoly.burakov@intel.com>, Olivier Matz <olivier.matz@6wind.com>, Andrew Rybchenko <arybchenko@solarflare.com>, Neil Horman <nhorman@tuxdriver.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Wed, Jun 24, 2020 at 1:59 PM Ananyev, Konstantin <konstantin.ananyev@intel.com> wrote: > > > Do you mean - make this new dynamic-lcore API return an error if callied > > > from secondary process? > > > > > > > Yes, and prohibiting from attaching a secondary process if dynamic > > lcore API has been used in primary. > > I intend to squash in patch 6: > > https://github.com/david-marchand/dpdk/commit/e5861ee734bfe2e4dc23d9b919b0db2a32a58aee > > But secondary process can attach before lcore_register, so we'll have some sort of inconsistency in behaviour. If the developer tries to use both features, he gets an ERROR log in the two init path. So whatever the order at runtime, we inform the developer (who did not read/understand the rte_thread_register() documentation) that what he is doing is unsupported. > If we really want to go ahead with such workaround - > probably better to introduce explicit EAL flag ( --single-process or so). > As Thomas and Bruce suggested, if I understood them properly. A EAL flag is a stable API from the start, as there is nothing describing how we can remove one. So a new EAL flag for an experimental API/feature seems contradictory. Going with a new features status API... I think it is beyond this series. Thomas seems to suggest an automatic resolution when features conflict happens.. ? I'll send the v4, let's discuss it there if you want. Thanks. -- David Marchand